| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2cbfefcb-863a-afb9-6c4c-b481a2fd814e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 882E:141FAF:9B43A8:D830F6:6A4E7E4A |
| html-safe-nonce | 0d89cc1ce7fd6cfa2eb18ae88130acd62ca7561b52e4f9ad587b1f7d9bb29c15 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODJFOjE0MUZBRjo5QjQzQTg6RDgzMEY2OjZBNEU3RTRBIiwidmlzaXRvcl9pZCI6IjkwNzc4MjU5MjIwNzgyNDQ0MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d90d943154e710de7531e997c70f416f8310171c21a577b1d572d5fd95ed660f |
| hovercard-subject-tag | pull_request:3017531813 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/30756/files |
| twitter:image | https://avatars.githubusercontent.com/u/8823157?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8823157?s=400&v=4 |
| og:image:alt | PR summary
Closes #23998
Why is this change necessary?
PatchCollection instances do not currently display in legends even when assigned a label. This has been a long-standing limitation that forces... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/30756/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F30756%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F30756%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/30756/files |
| Reload | https://github.com/matplotlib/matplotlib/pull/30756/files |
| Reload | https://github.com/matplotlib/matplotlib/pull/30756/files |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/30756/files |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/30756/files |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
410
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose |
| story645 | https://github.com/story645 |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| FazeelUsmani:fix-patchcollection-legend | https://github.com/FazeelUsmani/matplotlib/tree/fix-patchcollection-legend |
|
Conversation
32
| https://github.com/matplotlib/matplotlib/pull/30756 |
|
Commits
18
| https://github.com/matplotlib/matplotlib/pull/30756/commits |
|
Checks
36
| https://github.com/matplotlib/matplotlib/pull/30756/checks |
|
Files changed
| https://github.com/matplotlib/matplotlib/pull/30756/files |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/30756/files |
|
Add legend support for PatchCollection
| https://github.com/matplotlib/matplotlib/pull/30756/files#top |
|
Show all changes
18 commits
| https://github.com/matplotlib/matplotlib/pull/30756/files |
|
0f13209
Add support for PatchCollection legends and update documentation
FazeelUsmani Nov 17, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/0f13209076c905800159b328d27f69d4ecd9d7ef |
|
3f013f6
Add type stub for HandlerPatchCollection
FazeelUsmani Nov 17, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/3f013f62e111d499ccc8cfd0a85b4e3df60b27eb |
|
567b478
Remove visual regression test (baseline image needed)
FazeelUsmani Nov 17, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/567b478c3af62b3d8277e4274f87909f226a0fe5 |
|
8fc57eb
Trigger CI re-run
FazeelUsmani Nov 17, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/8fc57eb516459be9be10276c971b66f82c6141c6 |
|
478de45
Add explicit figure cleanup in PatchCollection legend tests
FazeelUsmani Nov 17, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/478de4522aef189337353fa8e8debd4bc06c576f |
|
8536bfc
Update lib/matplotlib/tests/test_legend.py
FazeelUsmani Nov 18, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/8536bfca7998ea3a47af99673b5cd159be6800bd |
|
71c9a86
Update lib/matplotlib/tests/test_legend.py
FazeelUsmani Nov 18, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/71c9a866e92a2856f1ae1fbb27763a2182c729d9 |
|
618d426
Update lib/matplotlib/tests/test_legend.py
FazeelUsmani Nov 18, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/618d426cf387108a11eb9319ff19181e6076b935 |
|
122a7d6
Update lib/matplotlib/tests/test_legend.py
FazeelUsmani Nov 18, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/122a7d638145bb49ca63e6451087d172dbc811b9 |
|
83adf5c
Update lib/matplotlib/tests/test_legend.py
FazeelUsmani Nov 18, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/83adf5ce86aa1af65780c4fa23513a3881222a66 |
|
477bf97
Update lib/matplotlib/tests/test_legend.py
FazeelUsmani Nov 18, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/477bf9705a3e6318a6edb164665c516c4a66a010 |
|
1a1b20a
Update lib/matplotlib/tests/test_legend.py
FazeelUsmani Nov 18, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/1a1b20aa096d450dd48f2553866959ea5e661169 |
|
bd2f926
Update lib/matplotlib/tests/test_legend.py
FazeelUsmani Nov 18, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/bd2f926ce0ada6367eb855ea52678cac23cdb64b |
|
33242ca
Update lib/matplotlib/tests/test_legend.py
FazeelUsmani Nov 18, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/33242cacc51c0d53e3a062c642fb1059b1290238 |
|
b669f4d
Remove redundant test_patchcollection_legend_match_original test
FazeelUsmani Nov 18, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/b669f4d9409a64e2035d0b18ff04db1547b68fda |
|
92aaeca
Test behavior instead of implementation details
FazeelUsmani Nov 18, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/92aaecaa3ffc925d52a76a424be8a5fbec0ff791 |
|
555faa6
Address story645's review: simplify implementation and improve tests
FazeelUsmani Nov 20, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/555faa660d1ee864f0202aa9dda9960be589059b |
|
84a911e
Update documentation and tests for PatchCollection legend support
FazeelUsmani Nov 24, 2025
| https://github.com/matplotlib/matplotlib/pull/30756/commits/84a911ed2de902704bfbaef6434908b534d937da |
|
Clear filters
| https://github.com/matplotlib/matplotlib/pull/30756/files |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/30756/files |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/30756/files |
|
patchcollection_legend.rst
| https://github.com/matplotlib/matplotlib/pull/30756/files#diff-08deaf904d41991799789536cd418da417340e2b49c4aeb1e7dfa240cfbc27f4 |
|
legend.py
| https://github.com/matplotlib/matplotlib/pull/30756/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a |
|
test_legend.py
| https://github.com/matplotlib/matplotlib/pull/30756/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579 |
| doc/release/next_whats_new/patchcollection_legend.rst | https://github.com/matplotlib/matplotlib/pull/30756/files#diff-08deaf904d41991799789536cd418da417340e2b49c4aeb1e7dfa240cfbc27f4 |
|
View file
| https://github.com/FazeelUsmani/matplotlib/blob/84a911ed2de902704bfbaef6434908b534d937da/doc/release/next_whats_new/patchcollection_legend.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/30756/{{ revealButtonHref }} |
| lib/matplotlib/legend.py | https://github.com/matplotlib/matplotlib/pull/30756/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a |
|
View file
| https://github.com/FazeelUsmani/matplotlib/blob/84a911ed2de902704bfbaef6434908b534d937da/lib/matplotlib/legend.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/30756/{{ revealButtonHref }} |
|
| https://github.com/matplotlib/matplotlib/pull/30756/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a |
|
| https://github.com/matplotlib/matplotlib/pull/30756/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a |
|
| https://github.com/matplotlib/matplotlib/pull/30756/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a |
|
| https://github.com/matplotlib/matplotlib/pull/30756/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a |
| lib/matplotlib/tests/test_legend.py | https://github.com/matplotlib/matplotlib/pull/30756/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579 |
|
View file
| https://github.com/FazeelUsmani/matplotlib/blob/84a911ed2de902704bfbaef6434908b534d937da/lib/matplotlib/tests/test_legend.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/30756/{{ revealButtonHref }} |
|
| https://github.com/matplotlib/matplotlib/pull/30756/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/30756/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |