Title: tests: extend QtAgg figureoptions coverage (follow-up to #30128) by YQ157 · Pull Request #30587 · matplotlib/matplotlib · GitHub
Open Graph Title: tests: extend QtAgg figureoptions coverage (follow-up to #30128) by YQ157 · Pull Request #30587 · matplotlib/matplotlib
X Title: tests: extend QtAgg figureoptions coverage (follow-up to #30128) by YQ157 · Pull Request #30587 · matplotlib/matplotlib
Description: This PR extends the test suite for the QtAgg figureoptions dialog, addressing coverage gaps reported on PR #30128 (Codecov) and related to issue #11109. What’s included: Parameterized legend scenarios (legend present/absent, visible/invisible) Date axis handling Lines labeled "nolegend" (skipped from legend) Mappables without array data Preserving existing legend when regenerate=False Stronger assertions for redraw and navigation stack updates The underlying implementation was originally proposed in #30128. This PR only adds tests (with minimal supporting changes), to ensure more complete coverage and to make it easier for maintainers to review and merge the fix. Refs #30128, #11109 ℹ️ Note: This is my first open-source contribution. It directly addresses the same problem described in issue #11109, which was marked as a good first issue.
Open Graph Description: This PR extends the test suite for the QtAgg figureoptions dialog, addressing coverage gaps reported on PR #30128 (Codecov) and related to issue #11109. What’s included: Parameterized legend scena...
X Description: This PR extends the test suite for the QtAgg figureoptions dialog, addressing coverage gaps reported on PR #30128 (Codecov) and related to issue #11109. What’s included: Parameterized legend scena...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/30587
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:13c358f1-709d-68b5-f4a3-604f105da88d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A8D4:24AEC:182A9F7:2335749:6A54D2D3 |
| html-safe-nonce | b1274bb251c5018b978b69ec9ff12b45ab89bd6ba0c9555f2a66bf2f2ca6107a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEQ0OjI0QUVDOjE4MkE5Rjc6MjMzNTc0OTo2QTU0RDJEMyIsInZpc2l0b3JfaWQiOiI4NjUxNDE0MzA2MTQyMDgxNzQ3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5a9087ff9bee086f3ff938e7818c22d1aa1ca0318f51748cb2b78e3a113e61bd |
| hovercard-subject-tag | pull_request:2844334487 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/30587/files |
| twitter:image | https://avatars.githubusercontent.com/u/99072422?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/99072422?s=400&v=4 |
| og:image:alt | This PR extends the test suite for the QtAgg figureoptions dialog, addressing coverage gaps reported on PR #30128 (Codecov) and related to issue #11109. What’s included: Parameterized legend scena... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | a556215b071af6609619e2bbe6f00bdfbf0812ad723b1ae6c301858a7a829f54 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 840b5d20d5a883c23cf56f5240b2c343d6cc0867 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width