Title: Fixed incomplete deletion of all images that have passed tests before upload by ayshih · Pull Request #30188 · matplotlib/matplotlib · GitHub
Open Graph Title: Fixed incomplete deletion of all images that have passed tests before upload by ayshih · Pull Request #30188 · matplotlib/matplotlib
X Title: Fixed incomplete deletion of all images that have passed tests before upload by ayshih · Pull Request #30188 · matplotlib/matplotlib
Description: PR summary This PR fixes a bug with #27882, which intended to delete all images that have passed tests before uploading the artifact. However, due to the specification of -type f in the find call, it inadvertently skips over images where the expected image is a symbolic link rather than an actual file. All of the baseline images in the repository are symbolically linked in the results folder (#10222), so #27882 actually deleted only those images where the expected image was dynamically generated. This PR also extends the cleanup to GIF files (of which there is exactly one test). I've tested this modification in a different PR, so I know that it successfully reduces the size of the uploaded artifact by ~50 MB. A few images (total of 370 kB) manage to still escape the cleanup, but I think that's small enough to put up with: empty.eps and empty_eps.png from test_backend_ps.py, which seems to be because the comparison image is empty-expected.pdf (PDF, not EPS), so the cleanup isn't smart enough to clean them up Many of the images from test_backend_pgf.py, which use a different approach for image comparisons PR checklist [N/A] "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested [N/A] Plotting related features are demonstrated in an example [N/A] New Features and API Changes are noted with a directive and release note [N/A] Documentation complies with general and docstring guidelines
Open Graph Description: PR summary This PR fixes a bug with #27882, which intended to delete all images that have passed tests before uploading the artifact. However, due to the specification of -type f in the find call...
X Description: PR summary This PR fixes a bug with #27882, which intended to delete all images that have passed tests before uploading the artifact. However, due to the specification of -type f in the find call...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/30188
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9804973f-e989-08d4-61ae-446e5f5540d8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 809E:199219:1F5147A:2963CC1:6A51EE0C |
| html-safe-nonce | c9ae60537b62dda1e202b5226503f093edfe0320a92c3f580bf9a147842c726f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDlFOjE5OTIxOToxRjUxNDdBOjI5NjNDQzE6NkE1MUVFMEMiLCJ2aXNpdG9yX2lkIjoiMTk3NjM4ODE0NjA0MzI0MzY0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1b2f1218c8754b2e22142aaff43ab0484364615e92a3a2d98daa3db6b24b085a |
| hovercard-subject-tag | pull_request:2605558595 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/30188/files |
| twitter:image | https://avatars.githubusercontent.com/u/991759?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/991759?s=400&v=4 |
| og:image:alt | PR summary This PR fixes a bug with #27882, which intended to delete all images that have passed tests before uploading the artifact. However, due to the specification of -type f in the find call... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width