Title: Remove cutout for missing font file in PdfFile._embedTeXFont. by anntzer · Pull Request #30036 · matplotlib/matplotlib · GitHub
Open Graph Title: Remove cutout for missing font file in PdfFile._embedTeXFont. by anntzer · Pull Request #30036 · matplotlib/matplotlib
X Title: Remove cutout for missing font file in PdfFile._embedTeXFont. by anntzer · Pull Request #30036 · matplotlib/matplotlib
Description: If fontfile is None, an error would already have been raised earlier in dviFontName (which explicitly checks for this case). (The cutout in _embedTeXFont was introduced first, in ed0066f (2009), but support for that case appears to have been broken a bit later and the check in dviFontName was then introduced in 4fcc0e7 (2016) where it simply improved the clarity of the exception ultimately raised. -- attn @jkseppan, who wrote both commits?) Noted in relation to #29807. PR summary PR checklist "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested Plotting related features are demonstrated in an example New Features and API Changes are noted with a directive and release note Documentation complies with general and docstring guidelines
Open Graph Description: If fontfile is None, an error would already have been raised earlier in dviFontName (which explicitly checks for this case). (The cutout in _embedTeXFont was introduced first, in ed0066f (2009), bu...
X Description: If fontfile is None, an error would already have been raised earlier in dviFontName (which explicitly checks for this case). (The cutout in _embedTeXFont was introduced first, in ed0066f (2009), bu...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/30036
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:920e5116-7a88-4d18-7410-f7053868358f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB18:16E576:70FFE6:970569:6A51D685 |
| html-safe-nonce | 81cd1ad2073076d969f5b22bf459832515870afcb3c33d026e0af68d0d363783 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjE4OjE2RTU3Njo3MEZGRTY6OTcwNTY5OjZBNTFENjg1IiwidmlzaXRvcl9pZCI6IjY0MDE0NDU3ODQ5MDcyNzM4NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0a76796889eae83473e06474790249042472758335561ee059b1f5ce84836ed3 |
| hovercard-subject-tag | pull_request:2511529078 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/30036/files |
| twitter:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| og:image:alt | If fontfile is None, an error would already have been raised earlier in dviFontName (which explicitly checks for this case). (The cutout in _embedTeXFont was introduced first, in ed0066f (2009), bu... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width