René's URL Explorer Experiment


Title: Ensure text metric calculation always uses the text cache by QuLogic · Pull Request #29907 · matplotlib/matplotlib · GitHub

Open Graph Title: Ensure text metric calculation always uses the text cache by QuLogic · Pull Request #29907 · matplotlib/matplotlib

X Title: Ensure text metric calculation always uses the text cache by QuLogic · Pull Request #29907 · matplotlib/matplotlib

Description: These locations outside of Text were calling Renderer.get_text_width_height_descent directly which meant that they were not cached, and the text_placeholders fixture did not catch their use. Fortunately, this only affected one test figure. PR summary PR checklist "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested Plotting related features are demonstrated in an example New Features and API Changes are noted with a directive and release note Documentation complies with general and docstring guidelines

Open Graph Description: These locations outside of Text were calling Renderer.get_text_width_height_descent directly which meant that they were not cached, and the text_placeholders fixture did not catch their use. Fort...

X Description: These locations outside of Text were calling Renderer.get_text_width_height_descent directly which meant that they were not cached, and the text_placeholders fixture did not catch their use. Fort...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/29907

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e60a739a-f4d0-02d0-c9e9-b13333cdf1cd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8EA:264DFC:58FEC:76CC5:6A52D3BD
html-safe-nonce8a42e0df11f1036cca46d3e5ff23b34bdcfddcd4694c6f76dcb9234e3feee829
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEVBOjI2NERGQzo1OEZFQzo3NkNDNTo2QTUyRDNCRCIsInZpc2l0b3JfaWQiOiIyMTEzMDAxODA5NzkwNTU1MDY5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb153344eaaf2f96d667694f4e69f5656dd19347d1bf3484300f8e9640fb13544
hovercard-subject-tagpull_request:2455163542
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/29907/files
twitter:imagehttps://avatars.githubusercontent.com/u/302469?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302469?s=400&v=4
og:image:altThese locations outside of Text were calling Renderer.get_text_width_height_descent directly which meant that they were not cached, and the text_placeholders fixture did not catch their use. Fort...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/29907/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F29907%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F29907%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/29907/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/29907/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/29907/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29907/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29907/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
tacaswellhttps://github.com/tacaswell
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
QuLogic:text-cachinghttps://github.com/QuLogic/matplotlib/tree/text-caching
Conversation 3 https://github.com/matplotlib/matplotlib/pull/29907
Commits 1 https://github.com/matplotlib/matplotlib/pull/29907/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/29907/checks
Files changed https://github.com/matplotlib/matplotlib/pull/29907/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29907/files
Ensure text metric calculation always uses the text cache https://github.com/matplotlib/matplotlib/pull/29907/files#top
Show all changes 1 commit https://github.com/matplotlib/matplotlib/pull/29907/files
1840d9b Ensure text metric calculation always uses the text cache QuLogic Apr 12, 2025 https://github.com/matplotlib/matplotlib/pull/29907/commits/1840d9b91f0763e039a356a4cd7f02b7e6a5b727
Clear filters https://github.com/matplotlib/matplotlib/pull/29907/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29907/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29907/files
offsetbox.py https://github.com/matplotlib/matplotlib/pull/29907/files#diff-c0f3394227ee94f97502e7cfb9b128bb8249d8f68ea51c9e0552ed885bcd81a7
constrained_layout10.png https://github.com/matplotlib/matplotlib/pull/29907/files#diff-e322340333d6a1114e8036aaf3d3531883faf836b94098e0447d8d0c8c9b42b9
text.py https://github.com/matplotlib/matplotlib/pull/29907/files#diff-2889b798b7f9a072d882bef4f0fc033db63538a9317df59fa963e9a82401bf40
axis_artist.py https://github.com/matplotlib/matplotlib/pull/29907/files#diff-01aadf87231fd89bcf103f9ccb1c762fc9ab2d53b01780bfb28024ed7225ce69
lib/matplotlib/offsetbox.pyhttps://github.com/matplotlib/matplotlib/pull/29907/files#diff-c0f3394227ee94f97502e7cfb9b128bb8249d8f68ea51c9e0552ed885bcd81a7
View file https://github.com/QuLogic/matplotlib/blob/1840d9b91f0763e039a356a4cd7f02b7e6a5b727/lib/matplotlib/offsetbox.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/29907/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/29907/files#diff-c0f3394227ee94f97502e7cfb9b128bb8249d8f68ea51c9e0552ed885bcd81a7
https://github.com/matplotlib/matplotlib/pull/29907/files#diff-c0f3394227ee94f97502e7cfb9b128bb8249d8f68ea51c9e0552ed885bcd81a7
...atplotlib/tests/baseline_images/test_constrainedlayout/constrained_layout10.pnghttps://github.com/matplotlib/matplotlib/pull/29907/files#diff-e322340333d6a1114e8036aaf3d3531883faf836b94098e0447d8d0c8c9b42b9
View file https://github.com/QuLogic/matplotlib/blob/1840d9b91f0763e039a356a4cd7f02b7e6a5b727/lib/matplotlib/tests/baseline_images/test_constrainedlayout/constrained_layout10.png
Open in desktop https://desktop.github.com
Reload?https://github.com/matplotlib/matplotlib/pull/29907/files
lib/matplotlib/text.pyhttps://github.com/matplotlib/matplotlib/pull/29907/files#diff-2889b798b7f9a072d882bef4f0fc033db63538a9317df59fa963e9a82401bf40
View file https://github.com/QuLogic/matplotlib/blob/1840d9b91f0763e039a356a4cd7f02b7e6a5b727/lib/matplotlib/text.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/29907/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/29907/files#diff-2889b798b7f9a072d882bef4f0fc033db63538a9317df59fa963e9a82401bf40
https://github.com/matplotlib/matplotlib/pull/29907/files#diff-2889b798b7f9a072d882bef4f0fc033db63538a9317df59fa963e9a82401bf40
lib/mpl_toolkits/axisartist/axis_artist.pyhttps://github.com/matplotlib/matplotlib/pull/29907/files#diff-01aadf87231fd89bcf103f9ccb1c762fc9ab2d53b01780bfb28024ed7225ce69
View file https://github.com/QuLogic/matplotlib/blob/1840d9b91f0763e039a356a4cd7f02b7e6a5b727/lib/mpl_toolkits/axisartist/axis_artist.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/29907/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/29907/files#diff-01aadf87231fd89bcf103f9ccb1c762fc9ab2d53b01780bfb28024ed7225ce69
https://github.com/matplotlib/matplotlib/pull/29907/files#diff-01aadf87231fd89bcf103f9ccb1c762fc9ab2d53b01780bfb28024ed7225ce69
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.