René's URL Explorer Experiment


Title: ENH: Type the possible str legend locs as Literals by timhoffm · Pull Request #29465 · matplotlib/matplotlib · GitHub

Open Graph Title: ENH: Type the possible str legend locs as Literals by timhoffm · Pull Request #29465 · matplotlib/matplotlib

X Title: ENH: Type the possible str legend locs as Literals by timhoffm · Pull Request #29465 · matplotlib/matplotlib

Description: Instead of accepting any str, we only accept as set of predefined literals. For simplicity, we don't distinguish the between allowed positions for Axes legend and figure legend. It's still better to limit the allowed range to the union of both rather than to accept abitrary strings. This is a bit cumbersome, but since loc names are hard to remember and easy to misspell, I believe it's a real benefit if in-editor type checkers could notify on an invalid loc name.

Open Graph Description: Instead of accepting any str, we only accept as set of predefined literals. For simplicity, we don't distinguish the between allowed positions for Axes legend and figure legend. It's still ...

X Description: Instead of accepting any str, we only accept as set of predefined literals. For simplicity, we don't distinguish the between allowed positions for Axes legend and figure legend. It'...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/29465

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0c6de52b-0e3a-71d9-e4cf-199e5b04ac44
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD502:25680F:C1BBD4:10ACE83:6A520EA3
html-safe-nonce96cddcfc66188cbfe973f9fe096701e20c2db53053b99c7ee764af4221b90d4d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTAyOjI1NjgwRjpDMUJCRDQ6MTBBQ0U4Mzo2QTUyMEVBMyIsInZpc2l0b3JfaWQiOiI4ODE5MzgxMjM4NjEzODA2NzU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5f2133a39bbb2e9904bb9355be3b297056e99a66ea0775824668f0fbe3e5cdc3
hovercard-subject-tagpull_request:2272516567
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/29465/files
twitter:imagehttps://avatars.githubusercontent.com/u/2836374?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2836374?s=400&v=4
og:image:altInstead of accepting any str, we only accept as set of predefined literals. For simplicity, we don't distinguish the between allowed positions for Axes legend and figure legend. It's still ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/29465/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F29465%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F29465%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/29465/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/29465/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/29465/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29465/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29465/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
ksundenhttps://github.com/ksunden
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
timhoffm:type-legend-lochttps://github.com/timhoffm/matplotlib/tree/type-legend-loc
Conversation 4 https://github.com/matplotlib/matplotlib/pull/29465
Commits 1 https://github.com/matplotlib/matplotlib/pull/29465/commits
Checks 37 https://github.com/matplotlib/matplotlib/pull/29465/checks
Files changed 4 https://github.com/matplotlib/matplotlib/pull/29465/files
ENH: Type the possible str legend locs as Literals https://github.com/matplotlib/matplotlib/pull/29465/files#top
Show all changes 1 commit https://github.com/matplotlib/matplotlib/pull/29465/files
0ab6890 ENH: Type the possible str legend locs as Literals timhoffm Jan 12, 2025 https://github.com/matplotlib/matplotlib/pull/29465/commits/0ab689095ab8ab0e7234ec0b970af07928fdeee6
Clear filters https://github.com/matplotlib/matplotlib/pull/29465/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29465/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29465/files
_axes.pyi https://github.com/matplotlib/matplotlib/pull/29465/files#diff-eadd15a7040334f239a70a5be507c694c92b6e7b709de5eadd2ee53231200215
figure.pyi https://github.com/matplotlib/matplotlib/pull/29465/files#diff-b3caa5521fc735e54a17e5195018ff8cd78b70e3c0e4be2b020b082cd710023a
legend.pyi https://github.com/matplotlib/matplotlib/pull/29465/files#diff-d0478557b998f49a871fd84d77dec7e5df30c68ea5200979d1e126aa17bdaf03
typing.py https://github.com/matplotlib/matplotlib/pull/29465/files#diff-6750465c8af86d76be10fbd15828ce3e15a411de5f4fdf1a5be07d7a8d137f18
lib/matplotlib/axes/_axes.pyihttps://github.com/matplotlib/matplotlib/pull/29465/files#diff-eadd15a7040334f239a70a5be507c694c92b6e7b709de5eadd2ee53231200215
View file https://github.com/timhoffm/matplotlib/blob/0ab689095ab8ab0e7234ec0b970af07928fdeee6/lib/matplotlib/axes/_axes.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/29465/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-eadd15a7040334f239a70a5be507c694c92b6e7b709de5eadd2ee53231200215
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-eadd15a7040334f239a70a5be507c694c92b6e7b709de5eadd2ee53231200215
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-eadd15a7040334f239a70a5be507c694c92b6e7b709de5eadd2ee53231200215
timhoffmhttps://github.com/timhoffm
Jan 12, 2025https://github.com/matplotlib/matplotlib/pull/29465/files#r1912449006
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29465/files
QuLogichttps://github.com/QuLogic
Jan 14, 2025https://github.com/matplotlib/matplotlib/pull/29465/files#r1914039527
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29465/files
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-eadd15a7040334f239a70a5be507c694c92b6e7b709de5eadd2ee53231200215
lib/matplotlib/figure.pyihttps://github.com/matplotlib/matplotlib/pull/29465/files#diff-b3caa5521fc735e54a17e5195018ff8cd78b70e3c0e4be2b020b082cd710023a
View file https://github.com/timhoffm/matplotlib/blob/0ab689095ab8ab0e7234ec0b970af07928fdeee6/lib/matplotlib/figure.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/29465/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-b3caa5521fc735e54a17e5195018ff8cd78b70e3c0e4be2b020b082cd710023a
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-b3caa5521fc735e54a17e5195018ff8cd78b70e3c0e4be2b020b082cd710023a
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-b3caa5521fc735e54a17e5195018ff8cd78b70e3c0e4be2b020b082cd710023a
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-b3caa5521fc735e54a17e5195018ff8cd78b70e3c0e4be2b020b082cd710023a
lib/matplotlib/legend.pyihttps://github.com/matplotlib/matplotlib/pull/29465/files#diff-d0478557b998f49a871fd84d77dec7e5df30c68ea5200979d1e126aa17bdaf03
View file https://github.com/timhoffm/matplotlib/blob/0ab689095ab8ab0e7234ec0b970af07928fdeee6/lib/matplotlib/legend.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/29465/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-d0478557b998f49a871fd84d77dec7e5df30c68ea5200979d1e126aa17bdaf03
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-d0478557b998f49a871fd84d77dec7e5df30c68ea5200979d1e126aa17bdaf03
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-d0478557b998f49a871fd84d77dec7e5df30c68ea5200979d1e126aa17bdaf03
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-d0478557b998f49a871fd84d77dec7e5df30c68ea5200979d1e126aa17bdaf03
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-d0478557b998f49a871fd84d77dec7e5df30c68ea5200979d1e126aa17bdaf03
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-d0478557b998f49a871fd84d77dec7e5df30c68ea5200979d1e126aa17bdaf03
lib/matplotlib/typing.pyhttps://github.com/matplotlib/matplotlib/pull/29465/files#diff-6750465c8af86d76be10fbd15828ce3e15a411de5f4fdf1a5be07d7a8d137f18
View file https://github.com/timhoffm/matplotlib/blob/0ab689095ab8ab0e7234ec0b970af07928fdeee6/lib/matplotlib/typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/29465/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/29465/files#diff-6750465c8af86d76be10fbd15828ce3e15a411de5f4fdf1a5be07d7a8d137f18
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29465/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.