Title: Add QtCore.Slot() decorations to FigureCanvasQT by pijyoi · Pull Request #29355 · matplotlib/matplotlib · GitHub
Open Graph Title: Add QtCore.Slot() decorations to FigureCanvasQT by pijyoi · Pull Request #29355 · matplotlib/matplotlib
X Title: Add QtCore.Slot() decorations to FigureCanvasQT by pijyoi · Pull Request #29355 · matplotlib/matplotlib
Description: PR summary This PR adds QtCore.Slot decorations to the methods in FigureCanvasQT. (It is similar to #27215) The motivation for this PR was found due to pyqtgraph/pyqtgraph#3205, which can be summarized as: when tests are run with pytest-qt installed, a QtWarningMsg will be emitted concerning non-decorated methods used as slots. PR checklist [N/A] "closes #0000" is in the body of the PR description to link the related issue [N/A] new and changed code is tested [N/A] Plotting related features are demonstrated in an example [N/A] New Features and API Changes are noted with a directive and release note [N/A] Documentation complies with general and docstring guidelines The pyqtgraph tests that were failing prior to this PR have been tested to be passing with this PR with PySide6 6.8.1, PyQt6 6.8.0, PyQt5 5.15, PySide2 5.15
Open Graph Description: PR summary This PR adds QtCore.Slot decorations to the methods in FigureCanvasQT. (It is similar to #27215) The motivation for this PR was found due to pyqtgraph/pyqtgraph#3205, which can be summar...
X Description: PR summary This PR adds QtCore.Slot decorations to the methods in FigureCanvasQT. (It is similar to #27215) The motivation for this PR was found due to pyqtgraph/pyqtgraph#3205, which can be summar...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/29355
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:33d75944-2898-6941-cebb-6f65386273a5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A688:39F5AD:2447AD4:31229A4:6A542844 |
| html-safe-nonce | 1b0fc8051801087445f06a004308e3c0f1489a4dfa5d954deecd272a10ec907d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjg4OjM5RjVBRDoyNDQ3QUQ0OjMxMjI5QTQ6NkE1NDI4NDQiLCJ2aXNpdG9yX2lkIjoiNjQ4NTcwODM2NjAzNTU2MDUxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f5e159f0e64fe5082dcbbe25ef5aa5ffed25d94bbded8c13752e6c25e85988c9 |
| hovercard-subject-tag | pull_request:2246400648 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/29355/files |
| twitter:image | https://avatars.githubusercontent.com/u/2657027?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2657027?s=400&v=4 |
| og:image:alt | PR summary This PR adds QtCore.Slot decorations to the methods in FigureCanvasQT. (It is similar to #27215) The motivation for this PR was found due to pyqtgraph/pyqtgraph#3205, which can be summar... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width