René's URL Explorer Experiment


Title: Raise warning if both c and facecolors are used in scatter plot (... and related improvements in the test suite). by NGWi · Pull Request #29130 · matplotlib/matplotlib · GitHub

Open Graph Title: Raise warning if both c and facecolors are used in scatter plot (... and related improvements in the test suite). by NGWi · Pull Request #29130 · matplotlib/matplotlib

X Title: Raise warning if both c and facecolors are used in scatter plot (... and related improvements in the test suite). by NGWi · Pull Request #29130 · matplotlib/matplotlib

Description: This is to fulfill @tacaswell's recommendation (at the PyData sprint I joined last week) that for a quick fix to close issue #24404, we raise a warning when such a script is attempted. The complaint in that issue was: that if both c and facecolors args are specified for a plot's markers (specifically a scatterplot), then the facecolors arg is ignored, while a user might expect that facecolors would be used for the fill and the 'c' color would remain at the edges. I have the code raise a warning in the style of others I saw in _axes.py : "You passed both c and facecolor/facecolors for the markers. " "Matplotlib is ignoring the facecolor " "in favor of what you specified in c. " "This behavior may change in the future." I am hoping that in the future we can implement c as edgecolors in that case, and we are not forced at some point to cause the plot to fail. PR checklist [✅ ] "Resolves #24404 " is in the body of the PR description to Resolve #24404 [✅ ] new and changed code is tested [N/A] Plotting related features are demonstrated in an example [I think N/A, but let me know.] New Features and API Changes are noted with a directive and release note [I think N/A, but let me know. ] Documentation complies with general and docstring guidelines

Open Graph Description: This is to fulfill @tacaswell's recommendation (at the PyData sprint I joined last week) that for a quick fix to close issue #24404, we raise a warning when such a script is attempted. The comp...

X Description: This is to fulfill @tacaswell's recommendation (at the PyData sprint I joined last week) that for a quick fix to close issue #24404, we raise a warning when such a script is attempted. The ...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/29130

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5c847df6-0550-d7ce-4683-e7a0bb1182a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id88EA:195DA5:E4D27A:133F65A:6A5171B4
html-safe-nonce059e303a0d138fd9ad97fbb9ad3a89e3f64861d29d07929d0bc5234f0c98fe34
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OEVBOjE5NURBNTpFNEQyN0E6MTMzRjY1QTo2QTUxNzFCNCIsInZpc2l0b3JfaWQiOiIzOTk1MjY2MzMwOTk5NzQ2OTk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf34598b9260179616c4e8f080657386cc7a1099417e4378c6e912b6db10ffd5c
hovercard-subject-tagpull_request:2175938486
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/29130/files
twitter:imagehttps://avatars.githubusercontent.com/u/55075327?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/55075327?s=400&v=4
og:image:altThis is to fulfill @tacaswell's recommendation (at the PyData sprint I joined last week) that for a quick fix to close issue #24404, we raise a warning when such a script is attempted. The comp...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb19955a9dd40fd99462443f7911b522d7216776a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/29130/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F29130%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F29130%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/29130/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/29130/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/29130/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29130/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29130/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
story645https://github.com/story645
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
NGWi:issue24404_addwarninghttps://github.com/NGWi/matplotlib/tree/issue24404_addwarning
Conversation 34 https://github.com/matplotlib/matplotlib/pull/29130
Commits 21 https://github.com/matplotlib/matplotlib/pull/29130/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/29130/checks
Files changed https://github.com/matplotlib/matplotlib/pull/29130/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29130/files
Raise warning if both c and facecolors are used in scatter plot (... and related improvements in the test suite). https://github.com/matplotlib/matplotlib/pull/29130/files#top
Show all changes 21 commits https://github.com/matplotlib/matplotlib/pull/29130/files
5a26bb9 Raise warning if both c and facecolors are used in scatter plot. In t… NGWi Nov 12, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/5a26bb9511bcfa8c2fc375fda7233aa0f33dbf81
f1966c2 Corrected flake8 formatting warnings. NGWi Nov 12, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/f1966c2eb416f553d86d30cc5ac6d8598c2ac77b
53a0825 Removed offending whitespace and extra line. NGWi Nov 13, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/53a082516f02b9d564a45d81d85b720d9b7b41b1
a777a15 Merge branch 'issue24404_addwarning' of https://github.com/NGWi/matpl… NGWi Nov 13, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/a777a1566e3f8e83a4a7a24dad630d82959f4e28
8031809 Corrected old test that qualified for the new warning. NGWi Nov 13, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/80318093766a8822a983cffc71576f43d9f74312
8ae213c Made message more concise, and straightened old test, to fulfill @tim… NGWi Nov 18, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/8ae213cd15a9791b350fa9b1d9a0b68e90ed6d6d
49f03f7 Added test. NGWi Nov 18, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/49f03f723ebb18a6e498a80abdfc006a97ba840b
8234066 Corrected flake8 linting objections. NGWi Nov 18, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/8234066c28c254e2bc043e6fb96c4ef5a6f1dc4f
38c092a Added direct test of _parse method to attempt to make Codecov happy. NGWi Nov 18, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/38c092a8faa029842484264b4b490f24a1a74723
e6e49aa Added pragma tags for code coverage to ignore unused but untested sim… NGWi Dec 3, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/e6e49aa3d200da802c23297075cfc20dae2bb510
39e1899 Raise warning if both c and facecolors are used in scatter plot. In t… NGWi Nov 12, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/39e18997a2d680fb8f2e260f4e5325f166b3a0f5
06c8a76 Corrected flake8 formatting warnings. NGWi Nov 12, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/06c8a76eb27942c8f83bc401bc934a9a0eb783e1
72138c6 Corrected old test that qualified for the new warning. NGWi Nov 13, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/72138c6ce0f45b053e54eea8ff89e2e0983c780a
319b92b Made message more concise, and straightened old test, to fulfill @tim… NGWi Nov 18, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/319b92b002920f4a4440dc2cd06c32d59b470e80
e348dfc Added test. NGWi Nov 18, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/e348dfc52b43040cc704160f17022a667cab05a6
fcf6ce2 Corrected flake8 linting objections. NGWi Nov 18, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/fcf6ce2589474fb2be1d35c444e5af1d8d5e8957
9601975 Added direct test of _parse method to attempt to make Codecov happy. NGWi Nov 18, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/96019754b07f48c3ff3058007bc3a1a7637740ae
a18364c Added pragma tags for code coverage to ignore unused but untested sim… NGWi Dec 3, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/a18364c78bd6b93b33a99bcf7c5f7dcbf1a18ab4
310a15f Corrected placement of pragma tags and added 'currently unused' to Je… NGWi Dec 4, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/310a15f512dc2ac3e5f6e10e1e7247cbc33ebeef
7c01a7b Tim's suggestion for naming test's list of colors. NGWi Dec 4, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/7c01a7b2dc4ff837dffbcb703ad632e7889bc02f
fd3d9db Corrected call to changed variable name. NGWi Dec 4, 2024 https://github.com/matplotlib/matplotlib/pull/29130/commits/fd3d9db791b14432dc0f6477c706de3e3f93dee9
Clear filters https://github.com/matplotlib/matplotlib/pull/29130/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29130/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29130/files
_axes.py https://github.com/matplotlib/matplotlib/pull/29130/files#diff-608e2a1bf3d32fd631b0763599a3334d59822c11cb4fec1fa7398c9714592900
test_axes.py https://github.com/matplotlib/matplotlib/pull/29130/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
test_legend.py https://github.com/matplotlib/matplotlib/pull/29130/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579
lib/matplotlib/axes/_axes.pyhttps://github.com/matplotlib/matplotlib/pull/29130/files#diff-608e2a1bf3d32fd631b0763599a3334d59822c11cb4fec1fa7398c9714592900
View file https://github.com/NGWi/matplotlib/blob/fd3d9db791b14432dc0f6477c706de3e3f93dee9/lib/matplotlib/axes/_axes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/29130/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/29130/files#diff-608e2a1bf3d32fd631b0763599a3334d59822c11cb4fec1fa7398c9714592900
https://github.com/matplotlib/matplotlib/pull/29130/files#diff-608e2a1bf3d32fd631b0763599a3334d59822c11cb4fec1fa7398c9714592900
lib/matplotlib/tests/test_axes.pyhttps://github.com/matplotlib/matplotlib/pull/29130/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
View file https://github.com/NGWi/matplotlib/blob/fd3d9db791b14432dc0f6477c706de3e3f93dee9/lib/matplotlib/tests/test_axes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/29130/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/29130/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
https://github.com/matplotlib/matplotlib/pull/29130/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
https://github.com/matplotlib/matplotlib/pull/29130/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
https://github.com/matplotlib/matplotlib/pull/29130/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
https://github.com/matplotlib/matplotlib/pull/29130/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
https://github.com/matplotlib/matplotlib/pull/29130/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
https://github.com/matplotlib/matplotlib/pull/29130/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
https://github.com/matplotlib/matplotlib/pull/29130/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
https://github.com/matplotlib/matplotlib/pull/29130/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
lib/matplotlib/tests/test_legend.pyhttps://github.com/matplotlib/matplotlib/pull/29130/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579
View file https://github.com/NGWi/matplotlib/blob/fd3d9db791b14432dc0f6477c706de3e3f93dee9/lib/matplotlib/tests/test_legend.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/29130/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/29130/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29130/files
https://github.com/matplotlib/matplotlib/pull/29130/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.