Title: fixed #24617 bug - Added subplot params and figsize getter setter methods to Figure.__init__ with tests by Thanushri16 · Pull Request #29116 · matplotlib/matplotlib · GitHub
Open Graph Title: fixed #24617 bug - Added subplot params and figsize getter setter methods to Figure.__init__ with tests by Thanushri16 · Pull Request #29116 · matplotlib/matplotlib
X Title: fixed #24617 bug - Added subplot params and figsize getter setter methods to Figure.__init__ with tests by Thanushri16 · Pull Request #29116 · matplotlib/matplotlib
Description: PR summary This is the first PR I am proposing and this PR fixes #24617 - [ENH]: Add setter/getter methods for all keyword parameters to Figure.init Few of the arguments passed to Figure.init did not have matching get_{kwarg}/set_{kwarg} methods on Figure (Bug #24617). This PR focuses on adding getter/setter methods and test coverage for the following: figsize (which wraps around get_size_inches and set_size_inches) subplotparams What problem does this PR solve? Two of the properties/parameters of Figure class didn't have getter/setter methods implemented - figsize, subplotparams. Without these getter/setter methods, use of the properties in the Figure class is inconsistent and neither does the class provide a way to set properties for these two attributes without the getter/setter methods. Relevant PRs (Both of these PRs have failing tests and failing checks for PR reviews): PR #25901 - This PR focuses on getter/setter methods to resolve Bug #24617 . The PR encounters AttributeError: 'Figure' object has no attribute 'get_subplotpars' that is not resolved and also has failing PR checks. PR #28936 - This PR resolves the AttributeError issues in PR #25901. However, the PR still had some failing test cases in pytest and has some failing PR checks. PR checklist: "closes #24617" is in the body of the PR description to link the related issue new and changed code is tested [N/A] Plotting related features are demonstrated in an example [N/A] New Features and API Changes are noted with a directive and release note Documentation complies with general and docstring guidelines ##Review Since, this is my first contribution in the open source, I would like to know the feedback and tips to improve my contributions.
Open Graph Description: PR summary This is the first PR I am proposing and this PR fixes #24617 - [ENH]: Add setter/getter methods for all keyword parameters to Figure.init Few of the arguments passed to Figure.init did n...
X Description: PR summary This is the first PR I am proposing and this PR fixes #24617 - [ENH]: Add setter/getter methods for all keyword parameters to Figure.init Few of the arguments passed to Figure.init did n...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/29116
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:06b8fc6e-a528-0667-2deb-53caeaec11f9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DDAC:1E68A5:209C4A6:2C74ECE:6A538BE4 |
| html-safe-nonce | 520c0a2aa6b6efba8d1f775d0bc61c486ea57389682027836e46b3a0d50de06e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREFDOjFFNjhBNToyMDlDNEE2OjJDNzRFQ0U6NkE1MzhCRTQiLCJ2aXNpdG9yX2lkIjoiMTc3NDExOTAwNzQxNjQ1NDExNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c8ed7cd266443b89d7c22b726c88be3d010b8d5d3c4c9f308d6eb6e2d524262a |
| hovercard-subject-tag | pull_request:2171668042 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/29116/files |
| twitter:image | https://avatars.githubusercontent.com/u/56839189?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/56839189?s=400&v=4 |
| og:image:alt | PR summary This is the first PR I am proposing and this PR fixes #24617 - [ENH]: Add setter/getter methods for all keyword parameters to Figure.init Few of the arguments passed to Figure.init did n... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width