René's URL Explorer Experiment

Title: Avoid timer drift during long callbacks by greglucas · Pull Request #29023 · matplotlib/matplotlib · GitHub

Open Graph Title: Avoid timer drift during long callbacks by greglucas · Pull Request #29023 · matplotlib/matplotlib

X Title: Avoid timer drift during long callbacks by greglucas · Pull Request #29023 · matplotlib/matplotlib

Description: PR summary Updating the interval or single_shot attributes of a timer would call the underlying timer update functions regardless of if a new value was present or not. This caused issues in animations that set the interval to the same value in each iteration of the loop and when a long-running function was taking place this would cause the timers to drift. Note that even with the interval/single_shot updates, Tk was still drifting so we need to update that repeating timer code to avoid the time it takes within the callback itself. ping @richardsheridan for thoughts/suggestions on the Tk updates. closes #28647 alternative to #28997 Example to test with from the main issue. All backends before this produced ~300ms, all backends produce ~200ms after these updates for me. import matplotlib.pyplot as plt import numpy as np from matplotlib import animation def update(frame): if len(frame) < 2: return [] diff = np.diff(frame) avg.set_text(avg_txt.format(diff.mean()*1e3)) cur.set_text(cur_txt.format(diff[-1]*1e3)) return [avg, cur] def frame(): times = deque(maxlen=100) while True: time.sleep(0.1) times.append(time.perf_counter()) yield times fig, ax = plt.subplots(figsize=(1,1)) ax.axis('off') avg_txt = 'avg: {:.3g} ms' cur_txt = 'cur: {:.3g} ms' avg = ax.text(0.5, 0.75, avg_txt.format(0), va='center', ha='center') cur = ax.text(0.5, 0.25, cur_txt.format(0), va='center', ha='center') anim = animation.FuncAnimation(fig, update, frame, repeat=False, cache_frame_data=False, interval=200) PR checklist "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested [n/a] Plotting related features are demonstrated in an example [n/a] New Features and API Changes are noted with a directive and release note [n/a] Documentation complies with general and docstring guidelines

Open Graph Description: PR summary Updating the interval or single_shot attributes of a timer would call the underlying timer update functions regardless of if a new value was present or not. This caused issues in animati...

X Description: PR summary Updating the interval or single_shot attributes of a timer would call the underlying timer update functions regardless of if a new value was present or not. This caused issues in animati...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/29023

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width