René's URL Explorer Experiment


Title: Avoid timer drift during long callbacks by greglucas · Pull Request #29023 · matplotlib/matplotlib · GitHub

Open Graph Title: Avoid timer drift during long callbacks by greglucas · Pull Request #29023 · matplotlib/matplotlib

X Title: Avoid timer drift during long callbacks by greglucas · Pull Request #29023 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR summary Updating the interval or single_shot attributes of a timer would call the underlying timer update functions regardless of if a new value was present or not. This caused issues in animati...

X Description: PR summary Updating the interval or single_shot attributes of a timer would call the underlying timer update functions regardless of if a new value was present or not. This caused issues in animati...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/29023

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:44b0008e-34e5-0a5c-b60c-80987be6e3e8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9B0:4DD3F:FA1988:14B8C67:6A533372
html-safe-nonce6f932d5b0a1792ea6a3daf7104c3f4b37377fe266e7dee0a625afa4ba334aab4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUIwOjRERDNGOkZBMTk4ODoxNEI4QzY3OjZBNTMzMzcyIiwidmlzaXRvcl9pZCI6IjM4MTAyMDQ2NjQxODU2OTcxMzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5ca15e0bd44893c94025836b7d6e72e69eacd80b4bbc7fe8458139ea9106bde9
hovercard-subject-tagpull_request:2146406870
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/29023/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0b79cf7eb30bfd0157f7dcaa69ada709fffd9e435cb73a60322a5cffacf75ee1/matplotlib/matplotlib/pull/29023
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0b79cf7eb30bfd0157f7dcaa69ada709fffd9e435cb73a60322a5cffacf75ee1/matplotlib/matplotlib/pull/29023
og:image:altPR summary Updating the interval or single_shot attributes of a timer would call the underlying timer update functions regardless of if a new value was present or not. This caused issues in animati...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegreglucas
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/29023#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F29023
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F29023
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/29023
Reloadhttps://github.com/matplotlib/matplotlib/pull/29023
Reloadhttps://github.com/matplotlib/matplotlib/pull/29023
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29023
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29023
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
greglucashttps://github.com/greglucas
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
greglucas:timer-interval-resethttps://github.com/greglucas/matplotlib/tree/timer-interval-reset
Conversationhttps://github.com/matplotlib/matplotlib/pull/29023
Commits4 (4)https://github.com/matplotlib/matplotlib/pull/29023/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/29023/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/29023/files
Avoid timer drift during long callbackshttps://github.com/matplotlib/matplotlib/pull/29023#top
greglucashttps://github.com/greglucas
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
greglucas:timer-interval-resethttps://github.com/greglucas/matplotlib/tree/timer-interval-reset
https://github.com/greglucas
greglucashttps://github.com/greglucas
Oct 25, 2024https://github.com/matplotlib/matplotlib/pull/29023#issue-2614732801
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29023
@richardsheridanhttps://github.com/richardsheridan
#28647https://github.com/matplotlib/matplotlib/issues/28647
#28997https://github.com/matplotlib/matplotlib/pull/28997
link the related issuehttps://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
testedhttps://matplotlib.org/devdocs/devel/testing.html
examplehttps://matplotlib.org/devdocs/devel/document.html#write-examples-and-tutorials
directive and release notehttps://matplotlib.org/devdocs/devel/api_changes.html#announce-changes-deprecations-and-new-features
generalhttps://matplotlib.org/devdocs/devel/document.html#write-rest-pages
docstringhttps://matplotlib.org/devdocs/devel/document.html#write-docstrings
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29023
https://github.com/greglucas
greglucashttps://github.com/greglucas
GUI: tk https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20tk%22
topic: animation https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20animation%22
topic: backends https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20backends%22
Oct 25, 2024https://github.com/matplotlib/matplotlib/pull/29023#event-14880728387
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
topic: canvas and figure manager https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20canvas%20and%20figure%20manager%22
topic: animation https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20animation%22
Oct 25, 2024https://github.com/matplotlib/matplotlib/pull/29023#event-14880731053
https://github.com/greglucas
greglucashttps://github.com/greglucas
Oct 25, 2024https://github.com/matplotlib/matplotlib/pull/29023#event-14880769348
https://github.com/richardsheridan
richardsheridanhttps://github.com/richardsheridan
Oct 25, 2024 https://github.com/matplotlib/matplotlib/pull/29023#pullrequestreview-2396121525
View reviewed changes https://github.com/matplotlib/matplotlib/pull/29023/files
richardsheridanhttps://github.com/richardsheridan
https://github.com/matplotlib/matplotlib/pull/29023#pullrequestreview-2396121525
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29023
lib/matplotlib/backends/_backend_tk.pyhttps://github.com/matplotlib/matplotlib/pull/29023/files#diff-0fcc17e00b4190b5c5d3fe025742c63fb70ffbd8bc9fc4fdee43064b8bc27e81
richardsheridanhttps://github.com/richardsheridan
Oct 25, 2024https://github.com/matplotlib/matplotlib/pull/29023#discussion_r1817169315
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29023
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29023
greglucashttps://github.com/greglucas
Oct 25, 2024https://github.com/matplotlib/matplotlib/pull/29023#discussion_r1817441752
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29023
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29023
greglucashttps://github.com/greglucas
Oct 26, 2024https://github.com/matplotlib/matplotlib/pull/29023#discussion_r1817600768
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29023
https://github.com/greglucas
greglucashttps://github.com/greglucas
force-pushedhttps://github.com/matplotlib/matplotlib/compare/dde708976c71b27dde0d4081df04a5c532da1b2b..1409c6c130178ca89acd6e49fd3041f20bb8f4a5
dde7089https://github.com/matplotlib/matplotlib/commit/dde708976c71b27dde0d4081df04a5c532da1b2b
1409c6chttps://github.com/matplotlib/matplotlib/commit/1409c6c130178ca89acd6e49fd3041f20bb8f4a5
Compare https://github.com/matplotlib/matplotlib/compare/dde708976c71b27dde0d4081df04a5c532da1b2b..1409c6c130178ca89acd6e49fd3041f20bb8f4a5
October 25, 2024 23:03https://github.com/matplotlib/matplotlib/pull/29023#event-14886707093
https://github.com/richardsheridan
richardsheridanhttps://github.com/richardsheridan
Oct 26, 2024 https://github.com/matplotlib/matplotlib/pull/29023#pullrequestreview-2396923213
View reviewed changes https://github.com/matplotlib/matplotlib/pull/29023/files
lib/matplotlib/backends/_backend_tk.pyhttps://github.com/matplotlib/matplotlib/pull/29023/files#diff-0fcc17e00b4190b5c5d3fe025742c63fb70ffbd8bc9fc4fdee43064b8bc27e81
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29023
https://github.com/greglucas
greglucashttps://github.com/greglucas
Oct 28, 2024 https://github.com/matplotlib/matplotlib/pull/29023#ref-issue-2619011019
Timer + long-running callback expectations #29029 https://github.com/matplotlib/matplotlib/issues/29029
greglucashttps://github.com/greglucas
October 30, 2024 14:41https://github.com/matplotlib/matplotlib/pull/29023#commits-pushed-5bdd545
https://github.com/greglucas
FIX: Only call timer updates when things change on the timerhttps://github.com/matplotlib/matplotlib/pull/29023/commits/5bdd545e0560885e2206c6d4535c434067e7ef6a
5bdd545https://github.com/matplotlib/matplotlib/pull/29023/commits/5bdd545e0560885e2206c6d4535c434067e7ef6a
https://github.com/greglucas
FIX: Avoid drift in Tk's repeating timerhttps://github.com/matplotlib/matplotlib/pull/29023/commits/9c8300d5790fd85fbff1351bd39c8712dd90e2ec
9c8300dhttps://github.com/matplotlib/matplotlib/pull/29023/commits/9c8300d5790fd85fbff1351bd39c8712dd90e2ec
https://github.com/greglucas
TST: Add test for timer drift in interactive backendshttps://github.com/matplotlib/matplotlib/pull/29023/commits/9d7343cc13d76cc3798f460814da41e946f733e8
9d7343chttps://github.com/matplotlib/matplotlib/pull/29023/commits/9d7343cc13d76cc3798f460814da41e946f733e8
https://github.com/greglucas
TST: Add backend bases testhttps://github.com/matplotlib/matplotlib/pull/29023/commits/2be06d425e283c0d244324a4fcbc1b0abbbd822d
2be06d4https://github.com/matplotlib/matplotlib/pull/29023/commits/2be06d425e283c0d244324a4fcbc1b0abbbd822d
https://github.com/greglucas
greglucashttps://github.com/greglucas
force-pushedhttps://github.com/matplotlib/matplotlib/compare/1409c6c130178ca89acd6e49fd3041f20bb8f4a5..2be06d425e283c0d244324a4fcbc1b0abbbd822d
1409c6chttps://github.com/matplotlib/matplotlib/commit/1409c6c130178ca89acd6e49fd3041f20bb8f4a5
2be06d4https://github.com/matplotlib/matplotlib/commit/2be06d425e283c0d244324a4fcbc1b0abbbd822d
Compare https://github.com/matplotlib/matplotlib/compare/1409c6c130178ca89acd6e49fd3041f20bb8f4a5..2be06d425e283c0d244324a4fcbc1b0abbbd822d
October 30, 2024 20:41https://github.com/matplotlib/matplotlib/pull/29023#event-15017944150
https://github.com/greglucas
greglucashttps://github.com/greglucas
Nov 1, 2024https://github.com/matplotlib/matplotlib/pull/29023#issuecomment-2452317491
#29062https://github.com/matplotlib/matplotlib/pull/29062
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29023
https://github.com/greglucas
greglucashttps://github.com/greglucas
Nov 1, 2024https://github.com/matplotlib/matplotlib/pull/29023#event-15073037264
https://github.com/greglucas
greglucashttps://github.com/greglucas
November 1, 2024 17:49https://github.com/matplotlib/matplotlib/pull/29023#event-15073037764
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
status: superseded https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20superseded%22
Nov 1, 2024https://github.com/matplotlib/matplotlib/pull/29023#event-15075489010
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F29023
https://github.com/richardsheridan
richardsheridan https://github.com/richardsheridan
https://github.com/matplotlib/matplotlib/pull/29023/files/1409c6c130178ca89acd6e49fd3041f20bb8f4a5
GUI: tk https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20tk%22
status: superseded https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20superseded%22
topic: backends https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20backends%22
topic: canvas and figure manager https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20canvas%20and%20figure%20manager%22
[MNT]: TimedAnimation event loop interval https://github.com/matplotlib/matplotlib/issues/28647
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/29023
https://github.com/greglucas
https://github.com/richardsheridan
https://github.com/QuLogic
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.