Title: Improve fallback font export tests by QuLogic · Pull Request #28784 · matplotlib/matplotlib · GitHub
Open Graph Title: Improve fallback font export tests by QuLogic · Pull Request #28784 · matplotlib/matplotlib
X Title: Improve fallback font export tests by QuLogic · Pull Request #28784 · matplotlib/matplotlib
Description: PR summary Working on #28765, I realized that we don't need an external font to test font fallback, as cmr10, and related, fonts have fairly low coverage compared to DejaVu Sans. Thus font fallback can easily be tested by starting with cmr10, and pulling additional characters from DejaVu Sans. In addition, this change increases unique characters in the figure to 491, which triggers some code paths for tables that are normally limited to 256 characters. The latter may be a bit overkill, but it shows that EPS is broken for a large set of unique characters, at least when viewed with evince. In that case, about half the bottom set of accented characters is missing, without any warnings produce. I have not yet determined the cause of this problem, but it looks like both type 3 and 42 use the ttconv extension to subset, though for large character sets, type 3 is forced to 42. It is possible that #20866 might be helpful here, but it would also be helpful if someone could confirm with a different EPS viewer. PR checklist [n/a] "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested [n/a] Plotting related features are demonstrated in an example [n/a] New Features and API Changes are noted with a directive and release note [n/a] Documentation complies with general and docstring guidelines
Open Graph Description: PR summary Working on #28765, I realized that we don't need an external font to test font fallback, as cmr10, and related, fonts have fairly low coverage compared to DejaVu Sans. Thus font fall...
X Description: PR summary Working on #28765, I realized that we don't need an external font to test font fallback, as cmr10, and related, fonts have fairly low coverage compared to DejaVu Sans. Thus font ...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/28784
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ed686f9b-d2ea-5f6a-86cb-baadb5ab0cfb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C722:274DA4:7C72EC:A92274:6A5376E2 |
| html-safe-nonce | 7c60809a3eac66f4f68ab71ddbd2f8271cd07c883803c1b880d84dc4a2237bbd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzIyOjI3NERBNDo3QzcyRUM6QTkyMjc0OjZBNTM3NkUyIiwidmlzaXRvcl9pZCI6IjY0NDcxODQ1ODgxNTQ1NjYzNzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 78135e2f8f2a16103348071f10264c6f820c4efa6c9178678de3546eb5f92750 |
| hovercard-subject-tag | pull_request:2056931356 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/28784/files |
| twitter:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| og:image:alt | PR summary Working on #28765, I realized that we don't need an external font to test font fallback, as cmr10, and related, fonts have fairly low coverage compared to DejaVu Sans. Thus font fall... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width