| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:73b1f8de-8bf5-88ec-1159-7cccdea7fee6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A3CC:2D3512:1CB9EE8:2605AB6:6A52DB34 |
| html-safe-nonce | 9bf54b1ac1c018da17ed84900273e0a0e46267a58dd56e1597149488518e5774 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0NDOjJEMzUxMjoxQ0I5RUU4OjI2MDVBQjY6NkE1MkRCMzQiLCJ2aXNpdG9yX2lkIjoiMjE5NjkwMjIwOTIxMTUyMTg0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 14cc29ea822ffcc9e3caa8d51c17819c2addc38845effd4102d7f496318fd062 |
| hovercard-subject-tag | pull_request:2043535808 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/28765/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8c7dc58853eb7b3f19b308b32d883167c0581a03370014569c42e51706810830/matplotlib/matplotlib/pull/28765 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8c7dc58853eb7b3f19b308b32d883167c0581a03370014569c42e51706810830/matplotlib/matplotlib/pull/28765 |
| og:image:alt | PR summary
I tried to cross-compare these against something external, like FontForge or fonttools, though a lot are just "make sure it keeps working the same way".
I left out FT2Font.get_... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | QuLogic |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/28765#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F28765 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F28765 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/28765 |
| Reload | https://github.com/matplotlib/matplotlib/pull/28765 |
| Reload | https://github.com/matplotlib/matplotlib/pull/28765 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28765 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28765 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
408
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| tacaswell | https://github.com/tacaswell |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| QuLogic:ft2font-tests | https://github.com/QuLogic/matplotlib/tree/ft2font-tests |
| Conversation | https://github.com/matplotlib/matplotlib/pull/28765 |
| Commits11 (11) | https://github.com/matplotlib/matplotlib/pull/28765/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/28765/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/28765/files |
| Add tests for most of FT2Font, and fix some bugs | https://github.com/matplotlib/matplotlib/pull/28765#top |
| tacaswell | https://github.com/tacaswell |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| QuLogic:ft2font-tests | https://github.com/QuLogic/matplotlib/tree/ft2font-tests |
|
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| Aug 29, 2024 | https://github.com/matplotlib/matplotlib/pull/28765#issue-2493903599 |
| link the related issue | https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
| tested | https://matplotlib.org/devdocs/devel/testing.html |
| example | https://matplotlib.org/devdocs/devel/document.html#write-examples-and-tutorials |
| directive and release note | https://matplotlib.org/devdocs/devel/api_changes.html#announce-changes-deprecations-and-new-features |
| general | https://matplotlib.org/devdocs/devel/document.html#write-rest-pages |
| docstring | https://matplotlib.org/devdocs/devel/document.html#write-docstrings |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28765 |
| QuLogic | https://github.com/QuLogic |
| August 24, 2024 03:32 | https://github.com/matplotlib/matplotlib/pull/28765#commits-pushed-2c3cae2 |
|
| https://github.com/QuLogic |
| TST: Add a test for FT2Image | https://github.com/matplotlib/matplotlib/pull/28765/commits/2c3cae2c610e1e56696607030e618e9eca7de0ba |
| 2c3cae2 | https://github.com/matplotlib/matplotlib/pull/28765/commits/2c3cae2c610e1e56696607030e618e9eca7de0ba |
|
| https://github.com/QuLogic |
| TST: Add tests for FT2Font attributes | https://github.com/matplotlib/matplotlib/pull/28765/commits/720aed081b8a805ba5e6be1d841f5e2acce191c5 |
| 720aed0 | https://github.com/matplotlib/matplotlib/pull/28765/commits/720aed081b8a805ba5e6be1d841f5e2acce191c5 |
|
| https://github.com/QuLogic |
| TST: Add tests for invalid FT2Font arguments | https://github.com/matplotlib/matplotlib/pull/28765/commits/a1b449865bf7c7252e5d42e19761c64868b357f2 |
| a1b4498 | https://github.com/matplotlib/matplotlib/pull/28765/commits/a1b449865bf7c7252e5d42e19761c64868b357f2 |
|
| https://github.com/QuLogic |
| TST: Add tests for FT2Font.clear | https://github.com/matplotlib/matplotlib/pull/28765/commits/2387233bfa860064310a55ffb1d950dc90628eda |
| 2387233 | https://github.com/matplotlib/matplotlib/pull/28765/commits/2387233bfa860064310a55ffb1d950dc90628eda |
|
| https://github.com/QuLogic |
| TST: Add tests for FT2Font charmaps | https://github.com/matplotlib/matplotlib/pull/28765/commits/6bad7f09906c5d748c54a54e766667cd29c16fab |
| 6bad7f0 | https://github.com/matplotlib/matplotlib/pull/28765/commits/6bad7f09906c5d748c54a54e766667cd29c16fab |
|
| https://github.com/QuLogic |
| TST: Add tests for FT2Font.get_sfnt{,_table} | https://github.com/matplotlib/matplotlib/pull/28765/commits/2754aaa42774aa89a6172b22140b86bb118223c1 |
| 2754aaa | https://github.com/matplotlib/matplotlib/pull/28765/commits/2754aaa42774aa89a6172b22140b86bb118223c1 |
|
| https://github.com/QuLogic |
| TST: Add tests for FT2Font.get_kerning | https://github.com/matplotlib/matplotlib/pull/28765/commits/3748c992c82688eb015e3ddc782678f2e045606f |
| 3748c99 | https://github.com/matplotlib/matplotlib/pull/28765/commits/3748c992c82688eb015e3ddc782678f2e045606f |
|
| https://github.com/QuLogic |
| Fix return value of FT2Font.set_text and add tests for it | https://github.com/matplotlib/matplotlib/pull/28765/commits/833a2593b694145ee7912737ce33274690851cf2 |
| 833a259 | https://github.com/matplotlib/matplotlib/pull/28765/commits/833a2593b694145ee7912737ce33274690851cf2 |
|
| https://github.com/QuLogic |
| TST: Add test for FT2Font.set_size | https://github.com/matplotlib/matplotlib/pull/28765/commits/f618fc21ca805b1b9dccecb364c1acea6c1fe30c |
| f618fc2 | https://github.com/matplotlib/matplotlib/pull/28765/commits/f618fc21ca805b1b9dccecb364c1acea6c1fe30c |
|
| https://github.com/QuLogic |
| TST: Add tests for FT2Font.load_{char,glyph} | https://github.com/matplotlib/matplotlib/pull/28765/commits/7c390dec98d0952057723f64aeb82d1b2a7e37d5 |
| 7c390de | https://github.com/matplotlib/matplotlib/pull/28765/commits/7c390dec98d0952057723f64aeb82d1b2a7e37d5 |
|
| https://github.com/QuLogic |
| TST: Add tests for FT2Font drawing and path generation | https://github.com/matplotlib/matplotlib/pull/28765/commits/06df2537df7250f87885a8d67140f2eeb0990f8c |
| 06df253 | https://github.com/matplotlib/matplotlib/pull/28765/commits/06df2537df7250f87885a8d67140f2eeb0990f8c |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
topic: text/fonts
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20text%2Ffonts%22 |
| Aug 29, 2024 | https://github.com/matplotlib/matplotlib/pull/28765#event-14058534693 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Aug 30, 2024
| https://github.com/matplotlib/matplotlib/pull/28765#ref-issue-1946502506 |
|
[MNT]: Add more tests for FT2Font.load_char
#27115
| https://github.com/matplotlib/matplotlib/issues/27115 |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
|
Sep 3, 2024
| https://github.com/matplotlib/matplotlib/pull/28765#pullrequestreview-2277568767 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/28765/files/06df2537df7250f87885a8d67140f2eeb0990f8c |
| QuLogic | https://github.com/QuLogic |
|
Sep 6, 2024
| https://github.com/matplotlib/matplotlib/pull/28765#ref-commit-9c5136f |
|
| https://github.com/QuLogic |
| Improve fallback font export tests | https://github.com/QuLogic/matplotlib/commit/9c5136f7df42a284eae8a65170f662689100a20d |
| 9c5136f | https://github.com/QuLogic/matplotlib/commit/9c5136f7df42a284eae8a65170f662689100a20d |
| matplotlib#28765 | https://github.com/matplotlib/matplotlib/pull/28765 |
| QuLogic | https://github.com/QuLogic |
|
Sep 6, 2024
| https://github.com/matplotlib/matplotlib/pull/28765#ref-commit-0129d60 |
|
| https://github.com/QuLogic |
| Improve fallback font export tests | https://github.com/QuLogic/matplotlib/commit/0129d60e01914cb7074b6c66e734af7b83ac293d |
| 0129d60 | https://github.com/QuLogic/matplotlib/commit/0129d60e01914cb7074b6c66e734af7b83ac293d |
| matplotlib#28765 | https://github.com/matplotlib/matplotlib/pull/28765 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Sep 6, 2024
| https://github.com/matplotlib/matplotlib/pull/28765#ref-pullrequest-2509219818 |
|
Improve fallback font export tests
#28784
| https://github.com/matplotlib/matplotlib/pull/28784 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| v3.10.0 | https://github.com/matplotlib/matplotlib/milestone/84 |
| Sep 6, 2024 | https://github.com/matplotlib/matplotlib/pull/28765#event-14155206336 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| cb9cf3b | https://github.com/matplotlib/matplotlib/commit/cb9cf3bbb1017797dd4bf18589c376ff88539fa7 |
| Sep 6, 2024 | https://github.com/matplotlib/matplotlib/pull/28765#event-14155209681 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| September 6, 2024 01:55 | https://github.com/matplotlib/matplotlib/pull/28765#event-14155241623 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Sep 6, 2024 | https://github.com/matplotlib/matplotlib/pull/28765#issuecomment-2333063572 |
| 5f2a89a | https://github.com/matplotlib/matplotlib/commit/5f2a89ab3a85e90eab41492acd94a78432ad2bf5 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28765 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| Sep 6, 2024 | https://github.com/matplotlib/matplotlib/pull/28765#issuecomment-2333065973 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28765 |
| QuLogic | https://github.com/QuLogic |
|
Oct 16, 2024
| https://github.com/matplotlib/matplotlib/pull/28765#ref-commit-4f6cf0e |
|
| https://github.com/QuLogic |
| Improve fallback font export tests | https://github.com/QuLogic/matplotlib/commit/4f6cf0e57c54214e2ce050ee28a44d8da90f9c6b |
| 4f6cf0e | https://github.com/QuLogic/matplotlib/commit/4f6cf0e57c54214e2ce050ee28a44d8da90f9c6b |
| matplotlib#28765 | https://github.com/matplotlib/matplotlib/pull/28765 |
| QuLogic | https://github.com/QuLogic |
|
Dec 3, 2024
| https://github.com/matplotlib/matplotlib/pull/28765#ref-commit-e17491d |
|
| https://github.com/QuLogic |
| Improve fallback font export tests | https://github.com/QuLogic/matplotlib/commit/e17491d5139cea94a9cb82537c34a4b6514afa54 |
| e17491d | https://github.com/QuLogic/matplotlib/commit/e17491d5139cea94a9cb82537c34a4b6514afa54 |
| matplotlib#28765 | https://github.com/matplotlib/matplotlib/pull/28765 |
| QuLogic | https://github.com/QuLogic |
|
Dec 11, 2024
| https://github.com/matplotlib/matplotlib/pull/28765#ref-commit-73dbb38 |
|
| https://github.com/QuLogic |
| Improve fallback font export tests | https://github.com/QuLogic/matplotlib/commit/73dbb381615313fc282531f54f1e9214b261f04c |
| 73dbb38 | https://github.com/QuLogic/matplotlib/commit/73dbb381615313fc282531f54f1e9214b261f04c |
| matplotlib#28765 | https://github.com/matplotlib/matplotlib/pull/28765 |
| QuLogic | https://github.com/QuLogic |
|
Dec 18, 2024
| https://github.com/matplotlib/matplotlib/pull/28765#ref-commit-0636690 |
|
| https://github.com/QuLogic |
| Improve fallback font export tests | https://github.com/QuLogic/matplotlib/commit/0636690700dc3f383081265b1bdcb19e419905c7 |
| 0636690 | https://github.com/QuLogic/matplotlib/commit/0636690700dc3f383081265b1bdcb19e419905c7 |
| matplotlib#28765 | https://github.com/matplotlib/matplotlib/pull/28765 |
| QuLogic | https://github.com/QuLogic |
|
Dec 19, 2024
| https://github.com/matplotlib/matplotlib/pull/28765#ref-commit-d48cc1c |
|
| https://github.com/QuLogic |
| Improve fallback font export tests | https://github.com/QuLogic/matplotlib/commit/d48cc1c4380d70e8149a2969f92e512dcd961d68 |
| d48cc1c | https://github.com/QuLogic/matplotlib/commit/d48cc1c4380d70e8149a2969f92e512dcd961d68 |
| matplotlib#28765 | https://github.com/matplotlib/matplotlib/pull/28765 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F28765 |
|
| https://github.com/oscargus |
|
oscargus
| https://github.com/oscargus |
|
| https://github.com/matplotlib/matplotlib/pull/28765/files/06df2537df7250f87885a8d67140f2eeb0990f8c |
|
topic: text/fonts
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20text%2Ffonts%22 |
|
v3.10.0
| https://github.com/matplotlib/matplotlib/milestone/84 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28765 |
|
| https://github.com/QuLogic |
|
| https://github.com/tacaswell |
|
| https://github.com/oscargus |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |