Title: MEP27 Part1: WindowGTK, Refactoring the FigureManagerGTK classes by OceanWolf · Pull Request #28699 · matplotlib/matplotlib · GitHub
Open Graph Title: MEP27 Part1: WindowGTK, Refactoring the FigureManagerGTK classes by OceanWolf · Pull Request #28699 · matplotlib/matplotlib
X Title: MEP27 Part1: WindowGTK, Refactoring the FigureManagerGTK classes by OceanWolf · Pull Request #28699 · matplotlib/matplotlib
Description: PR summary This PR exists as Part 1 of an attempt to resolve MEP 27 by splitting my previous PR (#4143) into smaller, more manageable, and thus easier to review chunks. Whilst my previous PR focussed solely on GTK3, this PR focuses solely on the windowing aspect of GTK3/4 with the rest of GTK3/4 refactor and MEP 27 infrastructure to follow in future PRs. Each of the other backends will then have the additional classes added in one PR per backend (~300 lines of code) This MEP has the ultimate goal of deprecating FigureManagerBase and all of its subclasses, in favour of a single GUI agnostic FigureManager class, similar to what FigureManagerGTK looks like in this PR. The Window API of MEP27, implemented here, allows for the possibility for (multiple) toolbars to get placed along any edge of the window. I had written an example in my previous PR, but I have left that for a future PR, but can also easily get added here (~50 lines of code) This PR has mainly been a copy/paste from my previous PR, but for: the addition of GTK4 which was released in the meantime; and taking into account other changes that have occurred in the MPL GTK codebase since then. In doing so, I have taken the opportunity to clean the codebase with respect to the differences between GTK3 and GTK4. PR checklist [N/A] "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested [N/A] Plotting related features are demonstrated in an example New Features and API Changes are noted with a directive and release note Documentation complies with general and docstring guidelines
Open Graph Description: PR summary This PR exists as Part 1 of an attempt to resolve MEP 27 by splitting my previous PR (#4143) into smaller, more manageable, and thus easier to review chunks. Whilst my previous PR focus...
X Description: PR summary This PR exists as Part 1 of an attempt to resolve MEP 27 by splitting my previous PR (#4143) into smaller, more manageable, and thus easier to review chunks. Whilst my previous PR focus...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/28699
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b0a366de-0f73-8314-a092-360806837c37 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C942:33F819:144EDFC:1B68DB6:6A534D02 |
| html-safe-nonce | 0090653c02340a81ad6fdd2e7c9e7e6e8f3d8d6ce5fd0cee721aee825b1844d6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTQyOjMzRjgxOToxNDRFREZDOjFCNjhEQjY6NkE1MzREMDIiLCJ2aXNpdG9yX2lkIjoiMzc0NzM3ODU2ODY0OTMxMDc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d3b5dca23104c8b320e1047d2450392691aeac194ac948dd7b26db1e8b977ea9 |
| hovercard-subject-tag | pull_request:2013162929 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/28699/files |
| twitter:image | https://avatars.githubusercontent.com/u/3758703?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3758703?s=400&v=4 |
| og:image:alt | PR summary This PR exists as Part 1 of an attempt to resolve MEP 27 by splitting my previous PR (#4143) into smaller, more manageable, and thus easier to review chunks. Whilst my previous PR focus... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width