Title: Copy all internals from initial Tick to lazy ones by QuLogic · Pull Request #28577 · matplotlib/matplotlib · GitHub
Open Graph Title: Copy all internals from initial Tick to lazy ones by QuLogic · Pull Request #28577 · matplotlib/matplotlib
X Title: Copy all internals from initial Tick to lazy ones by QuLogic · Pull Request #28577 · matplotlib/matplotlib
Description: PR summary Ticks will follow the rcParams at the time of their creation, if there were no other settings used. If the rcParams are set in a context, then the lazily-generated ticks may start fetching the wrong values. This is fixed via Axis._copy_tick_props by copying the properties from the Tick's child Artist's to the new ones. However, internal attributes from Tick are not copied, which is generally fine for drawing because nothing is every re-synced from there. However, in the case of Spine's window extent, it is generated from the tick direction and size attributes on the Tick, so being out of sync may cause an incorrect bounding box if the tick direction changes. Since Spine chooses a random Tick, this will cause tight/constrained layout to be nondeterministic. Since this is nondeterministic, I'm debating how best to write a test. Fixes #28574. PR checklist "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested [n/a] Plotting related features are demonstrated in an example [n/a] New Features and API Changes are noted with a directive and release note [n/a] Documentation complies with general and docstring guidelines
Open Graph Description: PR summary Ticks will follow the rcParams at the time of their creation, if there were no other settings used. If the rcParams are set in a context, then the lazily-generated ticks may start fetchi...
X Description: PR summary Ticks will follow the rcParams at the time of their creation, if there were no other settings used. If the rcParams are set in a context, then the lazily-generated ticks may start fetchi...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/28577
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:32c3809a-d36f-4b67-7b49-95b7fb4fde48 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 932C:24AEC:181B2AC:231F5EE:6A54D297 |
| html-safe-nonce | a1f36f7761e2dee09a18e3bfaad23afc65963994bf1149b7a79e143210c4b2ff |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzJDOjI0QUVDOjE4MUIyQUM6MjMxRjVFRTo2QTU0RDI5NyIsInZpc2l0b3JfaWQiOiI5MjIyMTM3MDg4Mzg3ODU2ODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f1b3de122445d4eb9643c0ea73614e1df51f3f64fefd340694da737ae8f4d434 |
| hovercard-subject-tag | pull_request:1968568393 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/28577/files |
| twitter:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| og:image:alt | PR summary Ticks will follow the rcParams at the time of their creation, if there were no other settings used. If the rcParams are set in a context, then the lazily-generated ticks may start fetchi... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | a556215b071af6609619e2bbe6f00bdfbf0812ad723b1ae6c301858a7a829f54 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 840b5d20d5a883c23cf56f5240b2c343d6cc0867 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width