| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:040a87c0-e326-8aee-a761-84eda12108b2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B690:34F7A0:45A6A42:60C9303:6A54E692 |
| html-safe-nonce | 20677adab148e74fad344dbaf603b7fd8486b98c09037c6a26b646f4e71c3040 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjkwOjM0RjdBMDo0NUE2QTQyOjYwQzkzMDM6NkE1NEU2OTIiLCJ2aXNpdG9yX2lkIjoiMzExMzEzNDg0Nzg4OTMwMzE4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b1b716e1a5b744d65d310475998fc375c93232df272f56ad2086ced5c2927a9d |
| hovercard-subject-tag | pull_request:1948020835 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/28495/files |
| twitter:image | https://avatars.githubusercontent.com/u/10998835?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10998835?s=400&v=4 |
| og:image:alt | PR summary
Solve #28463 by making ticker.EngFormatter be a subclass of ticker.ScalarFormatter (and not upon ticker.Formatter).
PR checklist
"closes #0000" is in the body of the PR descr... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | eae2aab99907699a22d2c8449aa683ca74454fca87211b98f7c7b722086b2839 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bb1b4ffdc07c66de20ad344214f55df0aa364bd3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/28495/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F28495%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F28495%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/28495/files |
| Reload | https://github.com/matplotlib/matplotlib/pull/28495/files |
| Reload | https://github.com/matplotlib/matplotlib/pull/28495/files |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28495/files |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28495/files |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
409
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose |
| ksunden | https://github.com/ksunden |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| doronbehar:tickerEngOffset | https://github.com/doronbehar/matplotlib/tree/tickerEngOffset |
|
Conversation
93
| https://github.com/matplotlib/matplotlib/pull/28495 |
|
Commits
10
| https://github.com/matplotlib/matplotlib/pull/28495/commits |
|
Checks
0
| https://github.com/matplotlib/matplotlib/pull/28495/checks |
|
Files changed
| https://github.com/matplotlib/matplotlib/pull/28495/files |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28495/files |
|
ticker.EngFormatter: allow offset
| https://github.com/matplotlib/matplotlib/pull/28495/files#top |
|
Show all changes
10 commits
| https://github.com/matplotlib/matplotlib/pull/28495/files |
|
facb403
ticker.ScalarFormatter: allow changing usetex like in EngFormatter
doronbehar Jul 1, 2024
| https://github.com/matplotlib/matplotlib/pull/28495/commits/facb403e944ccdc3464ea39b236651c5754cbfae |
|
7cb3f33
ticker.EngFormatter: base upon ScalarFormatter
doronbehar Jul 1, 2024
| https://github.com/matplotlib/matplotlib/pull/28495/commits/7cb3f3307aecc0c18edacf451eacba2457209abf |
|
bc85731
Fix small documentation issues from QuLogic's review
doronbehar Oct 12, 2024
| https://github.com/matplotlib/matplotlib/pull/28495/commits/bc8573180581bfe3a5db114825b904eb68a063c6 |
|
744b544
Small comment fixups from review
doronbehar Oct 12, 2024
| https://github.com/matplotlib/matplotlib/pull/28495/commits/744b5440c9b255bf8fdaf244b0a3821f695702ab |
|
5eec9e1
test_ticker.py: small cleanups after review
doronbehar Oct 13, 2024
| https://github.com/matplotlib/matplotlib/pull/28495/commits/5eec9e137e9e2e316662c0e7fd1c404aa8ae87f6 |
|
b0da1aa
ticker.py: small cleanups after review
doronbehar Oct 13, 2024
| https://github.com/matplotlib/matplotlib/pull/28495/commits/b0da1aabcc49736f8a8c3d7220e4e293d51892e0 |
|
8e34c06
ticker.ScalarFormatter: Fix type hints & document new attributes
doronbehar Oct 13, 2024
| https://github.com/matplotlib/matplotlib/pull/28495/commits/8e34c06317d920651e9ee4c7bdb78d09a9fdc210 |
|
a02eb9a
engformatter_offset.rst: fix title
doronbehar Oct 19, 2024
| https://github.com/matplotlib/matplotlib/pull/28495/commits/a02eb9a92aace32ee560f6baac7e703d68da859c |
|
b7c6f90
engformatter related small fixes
doronbehar Oct 23, 2024
| https://github.com/matplotlib/matplotlib/pull/28495/commits/b7c6f903150c7ea05af3d736ebac1195b049f21c |
|
b2c35fa
test_engformatter_offset_oom: parametrize center & noise directly
doronbehar Oct 23, 2024
| https://github.com/matplotlib/matplotlib/pull/28495/commits/b2c35faa6f2a8f946369d70829870d530d2c07de |
|
Clear filters
| https://github.com/matplotlib/matplotlib/pull/28495/files |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28495/files |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28495/files |
|
engformatter_offset.rst
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ad2d15b270b93a635bcb96748d4043fd6763179833e5068c512cca743bf777b1 |
|
update_features.rst
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-93dc8cb98b09e3857dd9a30cef86ec682a7bc1005823b9d994b5cff25f5bfec5 |
|
engformatter_offset.py
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-084d93ffa5a74cfb3428acb81eeff74edc5a1deb3a84e7e07e2d76ee9bdeb318 |
|
test_ticker.py
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-fd4f809a4a2ca8b97875eff013bac232c55ca3f92f165117f778960ca1795869 |
|
ticker.py
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66 |
|
ticker.pyi
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-9e5a9e5464f7ae8c955576c148959962faf4fe31043e293f161c067be8c0f788 |
| doc/users/next_whats_new/engformatter_offset.rst | https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ad2d15b270b93a635bcb96748d4043fd6763179833e5068c512cca743bf777b1 |
|
View file
| https://github.com/doronbehar/matplotlib/blob/b2c35faa6f2a8f946369d70829870d530d2c07de/doc/users/next_whats_new/engformatter_offset.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/28495/{{ revealButtonHref }} |
| doc/users/next_whats_new/update_features.rst | https://github.com/matplotlib/matplotlib/pull/28495/files#diff-93dc8cb98b09e3857dd9a30cef86ec682a7bc1005823b9d994b5cff25f5bfec5 |
|
View file
| https://github.com/doronbehar/matplotlib/blob/b2c35faa6f2a8f946369d70829870d530d2c07de/doc/users/next_whats_new/update_features.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/28495/{{ revealButtonHref }} |
| galleries/examples/ticks/engformatter_offset.py | https://github.com/matplotlib/matplotlib/pull/28495/files#diff-084d93ffa5a74cfb3428acb81eeff74edc5a1deb3a84e7e07e2d76ee9bdeb318 |
|
View file
| https://github.com/doronbehar/matplotlib/blob/b2c35faa6f2a8f946369d70829870d530d2c07de/galleries/examples/ticks/engformatter_offset.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/28495/{{ revealButtonHref }} |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28495/files |
| lib/matplotlib/tests/test_ticker.py | https://github.com/matplotlib/matplotlib/pull/28495/files#diff-fd4f809a4a2ca8b97875eff013bac232c55ca3f92f165117f778960ca1795869 |
|
View file
| https://github.com/doronbehar/matplotlib/blob/b2c35faa6f2a8f946369d70829870d530d2c07de/lib/matplotlib/tests/test_ticker.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/28495/{{ revealButtonHref }} |
|
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-fd4f809a4a2ca8b97875eff013bac232c55ca3f92f165117f778960ca1795869 |
|
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-fd4f809a4a2ca8b97875eff013bac232c55ca3f92f165117f778960ca1795869 |
| lib/matplotlib/ticker.py | https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66 |
|
View file
| https://github.com/doronbehar/matplotlib/blob/b2c35faa6f2a8f946369d70829870d530d2c07de/lib/matplotlib/ticker.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/28495/{{ revealButtonHref }} |
|
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28495/files |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28495/files |
|
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66 |
|
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66 |
|
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66 |
|
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66 |
|
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66 |
|
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66 |
|
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66 |
|
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28495/files |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28495/files |
|
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66 |
|
| https://github.com/matplotlib/matplotlib/pull/28495/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/28495/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |