Title: Fix `is_color_like` for 2-tuple of strings and fix `to_rgba` for `(nth_color, alpha)` by rcomer · Pull Request #28436 · matplotlib/matplotlib · GitHub
Open Graph Title: Fix `is_color_like` for 2-tuple of strings and fix `to_rgba` for `(nth_color, alpha)` by rcomer · Pull Request #28436 · matplotlib/matplotlib
X Title: Fix `is_color_like` for 2-tuple of strings and fix `to_rgba` for `(nth_color, alpha)` by rcomer · Pull Request #28436 · matplotlib/matplotlib
Description: PR summary Currently if we do is_color_like(('red', 'blue')) we get the unhelpful error shown in #28434. I couldn't find any existing tests for is_color_like so added a few. In the process of adding tests, found that to_rgba(('C3', 0.5)) is also broken (see #28436 (comment)), so fixed that too. Closes #28434, since this fixes the reported bug. There was a suggestion there about supporting color sequences in plot but it seems like that would be difficult to do. If we do want to discuss it further it might make sense to open a separate feature request issue. PR checklist "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested [n/a] Plotting related features are demonstrated in an example [n/a] New Features and API Changes are noted with a directive and release note [n/a] Documentation complies with general and docstring guidelines
Open Graph Description: PR summary Currently if we do is_color_like(('red', 'blue')) we get the unhelpful error shown in #28434. I couldn't find any existing tests for is_color_like so added a few. ...
X Description: PR summary Currently if we do is_color_like(('red', 'blue')) we get the unhelpful error shown in #28434. I couldn't find any existing tests for is_color_li...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/28436
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6f960b4e-09ab-575b-3481-cfba9d2b025f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D176:23560F:9F57D0:D70031:6A53123E |
| html-safe-nonce | 5a5c73589ce8576f36fb982a2a1d61dda54e145990424c9009dbf8ea791d565c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTc2OjIzNTYwRjo5RjU3RDA6RDcwMDMxOjZBNTMxMjNFIiwidmlzaXRvcl9pZCI6IjQyNDE0MjE2NDQxNTE4NTM2MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | da6c079646fa7cf0a2ec0f808393ddfc8ca70e2bc180a61079db85172ca946ed |
| hovercard-subject-tag | pull_request:1933457109 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/28436/files |
| twitter:image | https://avatars.githubusercontent.com/u/10599679?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10599679?s=400&v=4 |
| og:image:alt | PR summary Currently if we do is_color_like(('red', 'blue')) we get the unhelpful error shown in #28434. I couldn't find any existing tests for is_color_like so added a few. ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width