René's URL Explorer Experiment


Title: Promote mpltype Sphinx role to a public extension by QuLogic · Pull Request #28289 · matplotlib/matplotlib · GitHub

Open Graph Title: Promote mpltype Sphinx role to a public extension by QuLogic · Pull Request #28289 · matplotlib/matplotlib

X Title: Promote mpltype Sphinx role to a public extension by QuLogic · Pull Request #28289 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR summary When projects derive from our types, but don't override all the docstrings, they may want to use these extensions so that their docs build. Fixes #28234 However, this does mean that ...

X Description: PR summary When projects derive from our types, but don't override all the docstrings, they may want to use these extensions so that their docs build. Fixes #28234 However, this does mean t...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/28289

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0b0f0f6e-53a3-4d68-0b8b-8847fe7d87d6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id99CE:1C5BDD:303698:4050BF:6A518D13
html-safe-noncef487dc63ffb73659f85937603968628a82357761f993bf4d53942cc71a7c008b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUNFOjFDNUJERDozMDM2OTg6NDA1MEJGOjZBNTE4RDEzIiwidmlzaXRvcl9pZCI6Ijc4Njg1MDU1MTcxNTQzMzc0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9f4b892839355d5a5dc7372580b1e3c70fcfb3fa0d5cc44f09fd2bcd99a1de01
hovercard-subject-tagpull_request:1885354530
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/28289/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d2b3466a2584fc942c13f889ee82d4f2947b73566580896144e6938e7bea42e6/matplotlib/matplotlib/pull/28289
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d2b3466a2584fc942c13f889ee82d4f2947b73566580896144e6938e7bea42e6/matplotlib/matplotlib/pull/28289
og:image:altPR summary When projects derive from our types, but don't override all the docstrings, they may want to use these extensions so that their docs build. Fixes #28234 However, this does mean that ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameQuLogic
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/28289#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F28289
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F28289
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/28289
Reloadhttps://github.com/matplotlib/matplotlib/pull/28289
Reloadhttps://github.com/matplotlib/matplotlib/pull/28289
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/28289
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/28289
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
ksundenhttps://github.com/ksunden
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
QuLogic:public-roleshttps://github.com/QuLogic/matplotlib/tree/public-roles
Conversationhttps://github.com/matplotlib/matplotlib/pull/28289
Commits2 (2)https://github.com/matplotlib/matplotlib/pull/28289/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/28289/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/28289/files
Promote mpltype Sphinx role to a public extensionhttps://github.com/matplotlib/matplotlib/pull/28289#top
ksundenhttps://github.com/ksunden
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
QuLogic:public-roleshttps://github.com/QuLogic/matplotlib/tree/public-roles
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
May 23, 2024https://github.com/matplotlib/matplotlib/pull/28289#issue-2313746733
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/28289
#28234https://github.com/matplotlib/matplotlib/issues/28234
link the related issuehttps://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
testedhttps://matplotlib.org/devdocs/devel/testing.html
examplehttps://matplotlib.org/devdocs/devel/document.html#write-examples-and-tutorials
directive and release notehttps://matplotlib.org/devdocs/devel/api_changes.html#announce-changes-deprecations-and-new-features
generalhttps://matplotlib.org/devdocs/devel/document.html#write-rest-pages
docstringhttps://matplotlib.org/devdocs/devel/document.html#write-docstrings
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/28289
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
topic: sphinx extension https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20sphinx%20extension%22
Documentation: build https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Documentation%3A%20build%22
May 23, 2024https://github.com/matplotlib/matplotlib/pull/28289#event-12914716841
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
May 23, 2024https://github.com/matplotlib/matplotlib/pull/28289#issuecomment-2128054226
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/28289
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/28289
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
May 24, 2024https://github.com/matplotlib/matplotlib/pull/28289#issuecomment-2129703711
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/28289
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
v3.9.1https://github.com/matplotlib/matplotlib/milestone/91
May 24, 2024https://github.com/matplotlib/matplotlib/pull/28289#event-12926075744
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
May 26, 2024https://github.com/matplotlib/matplotlib/pull/28289#issuecomment-2132329475
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/28289
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/28289
https://github.com/QuLogic
Promote mpltype Sphinx role to a public extensionhttps://github.com/matplotlib/matplotlib/pull/28289/commits/8e957490d84b1f84bad0ec6f67d9370d38c408c0
8e95749https://github.com/matplotlib/matplotlib/pull/28289/commits/8e957490d84b1f84bad0ec6f67d9370d38c408c0
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
force-pushedhttps://github.com/matplotlib/matplotlib/compare/5fee0fa97e883fb691e5711dc7dba0481eda4907..8e957490d84b1f84bad0ec6f67d9370d38c408c0
5fee0fahttps://github.com/matplotlib/matplotlib/commit/5fee0fa97e883fb691e5711dc7dba0481eda4907
8e95749https://github.com/matplotlib/matplotlib/commit/8e957490d84b1f84bad0ec6f67d9370d38c408c0
Compare https://github.com/matplotlib/matplotlib/compare/5fee0fa97e883fb691e5711dc7dba0481eda4907..8e957490d84b1f84bad0ec6f67d9370d38c408c0
June 1, 2024 01:12https://github.com/matplotlib/matplotlib/pull/28289#event-13007396220
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
June 1, 2024 01:13https://github.com/matplotlib/matplotlib/pull/28289#event-13007397621
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Jun 1, 2024https://github.com/matplotlib/matplotlib/pull/28289#issuecomment-2143192905
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/28289
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Jun 1, 2024 https://github.com/matplotlib/matplotlib/pull/28289#pullrequestreview-2092048730
View reviewed changes https://github.com/matplotlib/matplotlib/pull/28289/files/8e957490d84b1f84bad0ec6f67d9370d38c408c0
doc/api/next_api_changes/development/28289-ES.rsthttps://github.com/matplotlib/matplotlib/pull/28289/files/8e957490d84b1f84bad0ec6f67d9370d38c408c0#diff-fdcef6ed2a4a3858ec2a5eab6b70790229e496bda946c81de65330ae26224aa8
timhoffmhttps://github.com/timhoffm
Jun 1, 2024https://github.com/matplotlib/matplotlib/pull/28289#discussion_r1623175175
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/28289
timhoffmhttps://github.com/timhoffm
Jun 1, 2024https://github.com/matplotlib/matplotlib/pull/28289#discussion_r1623176087
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/28289
https://github.com/timhoffm
Document sphinxext.roleshttps://github.com/matplotlib/matplotlib/pull/28289/commits/3fe382dd89313be3feeb7620cde64c2c0dbe0ba4
3fe382dhttps://github.com/matplotlib/matplotlib/pull/28289/commits/3fe382dd89313be3feeb7620cde64c2c0dbe0ba4
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Jun 1, 2024https://github.com/matplotlib/matplotlib/pull/28289#issuecomment-2143620629
@QuLogichttps://github.com/QuLogic
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/28289
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jun 26, 2024 https://github.com/matplotlib/matplotlib/pull/28289#pullrequestreview-2142818925
View reviewed changes https://github.com/matplotlib/matplotlib/pull/28289/files/3fe382dd89313be3feeb7620cde64c2c0dbe0ba4
https://github.com/ksunden
ksundenhttps://github.com/ksunden
Jun 26, 2024 https://github.com/matplotlib/matplotlib/pull/28289#pullrequestreview-2142822478
View reviewed changes https://github.com/matplotlib/matplotlib/pull/28289/files/3fe382dd89313be3feeb7620cde64c2c0dbe0ba4
https://github.com/ksunden
ksundenhttps://github.com/ksunden
664b457https://github.com/matplotlib/matplotlib/commit/664b45729aa6ac2d6ef9459d8c0ad04f50af847c
Jun 26, 2024https://github.com/matplotlib/matplotlib/pull/28289#event-13303549809
meeseeksmachinehttps://github.com/meeseeksmachine
Jun 26, 2024 https://github.com/matplotlib/matplotlib/pull/28289#ref-commit-8709791
https://github.com/ksunden
https://github.com/meeseeksmachine
Backport PRhttps://github.com/meeseeksmachine/matplotlib/commit/8709791007cf4c8cbc745e314ac6d3d5f6d24ccf
matplotlib#28289https://github.com/matplotlib/matplotlib/pull/28289
: Promote mpltype Sphinx role to a public…https://github.com/meeseeksmachine/matplotlib/commit/8709791007cf4c8cbc745e314ac6d3d5f6d24ccf
8709791https://github.com/meeseeksmachine/matplotlib/commit/8709791007cf4c8cbc745e314ac6d3d5f6d24ccf
https://github.com/meeseeksmachine
meeseeksmachinehttps://github.com/meeseeksmachine
Jun 26, 2024 https://github.com/matplotlib/matplotlib/pull/28289#ref-pullrequest-2376158865
Backport PR #28289 on branch v3.9.x (Promote mpltype Sphinx role to a public extension) #28472 https://github.com/matplotlib/matplotlib/pull/28472
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
June 26, 2024 20:15https://github.com/matplotlib/matplotlib/pull/28289#event-13303729319
QuLogichttps://github.com/QuLogic
Jun 26, 2024 https://github.com/matplotlib/matplotlib/pull/28289#ref-commit-826575f
https://github.com/QuLogic
Merge pull requesthttps://github.com/matplotlib/matplotlib/commit/826575ff855f082994ce502e7493ac8f8661a2e4
#28472https://github.com/matplotlib/matplotlib/pull/28472
from meeseeksmachine/auto-backport-of-pr-28…https://github.com/matplotlib/matplotlib/commit/826575ff855f082994ce502e7493ac8f8661a2e4
826575fhttps://github.com/matplotlib/matplotlib/commit/826575ff855f082994ce502e7493ac8f8661a2e4
#28289https://github.com/matplotlib/matplotlib/pull/28289
DOC: New extension to use mpltype custom role in doc build to avoid warnings astropy/astropy#16681 https://github.com/astropy/astropy/pull/16681
[Bug]: mpltype custom role breaks sphinx build for third-party projects that have intersphinx links to matplotlib #28234 https://github.com/matplotlib/matplotlib/issues/28234
bocklundhttps://github.com/bocklund
Aug 25, 2025 https://github.com/matplotlib/matplotlib/pull/28289#ref-commit-e1ea8cc
https://github.com/bocklund
DOC: matplotlib docs fixhttps://github.com/bocklund/pycalphad/commit/e1ea8cc79f9c08e2621d0681bcdaca108fd73f84
e1ea8cchttps://github.com/bocklund/pycalphad/commit/e1ea8cc79f9c08e2621d0681bcdaca108fd73f84
matplotlib/matplotlib#28289https://github.com/matplotlib/matplotlib/pull/28289
https://github.com/bocklund
bocklundhttps://github.com/bocklund
Aug 25, 2025 https://github.com/matplotlib/matplotlib/pull/28289#ref-pullrequest-3350097345
MAINT: Drop Python 3.10, fix CI coverage failures pycalphad/pycalphad#622 https://github.com/pycalphad/pycalphad/pull/622
bocklundhttps://github.com/bocklund
Sep 12, 2025 https://github.com/matplotlib/matplotlib/pull/28289#ref-commit-2b0e00c
https://github.com/bocklund
MAINT: Drop Python 3.10, fix CI failures (https://github.com/pycalphad/pycalphad/commit/2b0e00cd187b3e1b6f52cc53cc0d549bc2b1f0d1
#622https://github.com/pycalphad/pycalphad/pull/622
)https://github.com/pycalphad/pycalphad/commit/2b0e00cd187b3e1b6f52cc53cc0d549bc2b1f0d1
2b0e00chttps://github.com/pycalphad/pycalphad/commit/2b0e00cd187b3e1b6f52cc53cc0d549bc2b1f0d1
matplotlib/matplotlib#28289https://github.com/matplotlib/matplotlib/pull/28289
https://numpy.org/neps/nep-0029-deprecation_policy.htmlhttps://numpy.org/neps/nep-0029-deprecation_policy.html
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F28289
https://github.com/timhoffm
timhoffm https://github.com/timhoffm
https://github.com/matplotlib/matplotlib/pull/28289/files/8e957490d84b1f84bad0ec6f67d9370d38c408c0
https://github.com/tacaswell
tacaswell https://github.com/tacaswell
https://github.com/matplotlib/matplotlib/pull/28289/files/3fe382dd89313be3feeb7620cde64c2c0dbe0ba4
https://github.com/ksunden
ksunden https://github.com/ksunden
https://github.com/matplotlib/matplotlib/pull/28289/files/3fe382dd89313be3feeb7620cde64c2c0dbe0ba4
Documentation: build https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Documentation%3A%20build%22
topic: sphinx extension https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20sphinx%20extension%22
v3.9.1 https://github.com/matplotlib/matplotlib/milestone/91
[Bug]: mpltype custom role breaks sphinx build for third-party projects that have intersphinx links to matplotlib https://github.com/matplotlib/matplotlib/issues/28234
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/28289
https://github.com/QuLogic
https://github.com/timhoffm
https://github.com/tacaswell
https://github.com/ksunden
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.