Title: Artist autolim by jayyxiao · Pull Request #28071 · matplotlib/matplotlib · GitHub
Open Graph Title: Artist autolim by jayyxiao · Pull Request #28071 · matplotlib/matplotlib
X Title: Artist autolim by jayyxiao · Pull Request #28071 · matplotlib/matplotlib
Description: PR summary Move auto-limit logic inside respective Artists This will allow for relim to work with Collections. closes #25139 . _update_*_limits() were moved inside respective Artists. An _in_autoscale flag was created in base Artist, with setters and getters. This flag can be a bool or tuple, as specified in #15595 . Also, _update_limits() was created in Collection. Thus, relim checks the _in_autoscale flag and calls a generic _update_limits(), which now exists in Collection. _in_autoscale is set to True in the Artist constructor. Expansion to a tuple will be done by the setter. _in_autoscale can be set to False when theautolim parameter of add_collection is False. Since I am a new contributor, I hope this can be a starting point. I'm just looking for some feedback. PR checklist "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested [N/A] Plotting related features are demonstrated in an example New Features and API Changes are noted with a directive and release note Documentation complies with general and docstring guidelines
Open Graph Description: PR summary Move auto-limit logic inside respective Artists This will allow for relim to work with Collections. closes #25139 . _update_*_limits() were moved inside respective Artists. An _in_autos...
X Description: PR summary Move auto-limit logic inside respective Artists This will allow for relim to work with Collections. closes #25139 . _update_*_limits() were moved inside respective Artists. An _in_autos...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/28071
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f93a3b63-f7d6-7cc1-ecfc-26b03e4544fa |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D22C:2F0FE8:1E83524:28F7D2D:6A537679 |
| html-safe-nonce | 73ba8589cfb36242eadd22fef7fae1d1e3eaf0a14cf719e4533a20efc4adff92 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjJDOjJGMEZFODoxRTgzNTI0OjI4RjdEMkQ6NkE1Mzc2NzkiLCJ2aXNpdG9yX2lkIjoiMzI1OTU2ODAzODQwNDY1MDYxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9a01e0ce73dabf05f18064b1d57e883d8de2d6c0371be743efe1cb4a381dd9e0 |
| hovercard-subject-tag | pull_request:1821336233 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/28071/files |
| twitter:image | https://avatars.githubusercontent.com/u/123917335?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/123917335?s=400&v=4 |
| og:image:alt | PR summary Move auto-limit logic inside respective Artists This will allow for relim to work with Collections. closes #25139 . _update_*_limits() were moved inside respective Artists. An _in_autos... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width