Title: TST: Remove superfluous chdir from tests by QuLogic · Pull Request #27985 · matplotlib/matplotlib · GitHub
Open Graph Title: TST: Remove superfluous chdir from tests by QuLogic · Pull Request #27985 · matplotlib/matplotlib
X Title: TST: Remove superfluous chdir from tests by QuLogic · Pull Request #27985 · matplotlib/matplotlib
Description: PR summary These tests don't chdir back to the original directory on exit, so anything using the current directory would be in the temporary directory of this test. Most notably, any image comparison results would be dumped in that temporary directory instead of the usual result_images in the current directory. I noticed this while debugging #27723, as the failing test images were not in the artifacts, and logs showed them saved in a temporary directory: https://github.com/matplotlib/matplotlib/actions/runs/8458560380/job/23173084420#step:13:183 PR checklist [n/a] "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested [n/a] Plotting related features are demonstrated in an example [n/a] New Features and API Changes are noted with a directive and release note [n/a] Documentation complies with general and docstring guidelines
Open Graph Description: PR summary These tests don't chdir back to the original directory on exit, so anything using the current directory would be in the temporary directory of this test. Most notably, any image comp...
X Description: PR summary These tests don't chdir back to the original directory on exit, so anything using the current directory would be in the temporary directory of this test. Most notably, any image ...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/27985
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7d29eaf6-0903-b394-aff6-a3ddd66da296 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DDAE:1D4F69:20B8F2:2B7745:6A52E723 |
| html-safe-nonce | e08ae3c568dbc8b91a2ff06ed8db6dee5e0b68f4360987747f8a1d0cb590b98b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREFFOjFENEY2OToyMEI4RjI6MkI3NzQ1OjZBNTJFNzIzIiwidmlzaXRvcl9pZCI6IjQ4MDQ2Nzk4Njg4NTA4MjQ5OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5155b9a877044a122e5478801916a0dd7904cc68a6f9b4a53cbb6e89d7ce16a5 |
| hovercard-subject-tag | pull_request:1795209907 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/27985/files |
| twitter:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| og:image:alt | PR summary These tests don't chdir back to the original directory on exit, so anything using the current directory would be in the temporary directory of this test. Most notably, any image comp... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width