Title: Work around pyparsing diagnostic warnings by ksunden · Pull Request #27685 · matplotlib/matplotlib · GitHub
Open Graph Title: Work around pyparsing diagnostic warnings by ksunden · Pull Request #27685 · matplotlib/matplotlib
X Title: Work around pyparsing diagnostic warnings by ksunden · Pull Request #27685 · matplotlib/matplotlib
Description: Closes #25204 PR summary This feels a bit more "workaround" than I'd really like, but it seems to work. Pyparsing warns when you try to name a forward reference before it is defined As far as I can tell, it actually does work currently, but discussion on pyparsing/pyparsing#95 leads me to believe that we are relying on something that could change When names are given, a copy is produced, and thus in theory the forward references won't get their definitions In practice, they appear to There is a warning which is disabled by default for this behavior. Enabled with python -Wdefault, but not enabled in our test suite The solution I came up with was to wrap it in another layer of forward reference This feels like a hack, but the reference the outer forward holds gets filled out and a copy to that reference is transmitted to the copies. I also considered defining early Can't do completely due to cycles, redefining is possible, but likely to be more fragile Supressing warnings Works for now, but seems not by design Removing names Would require (at least) more extensive code changes, as many test failures result. Not using a Forward Was unable to find something that did not obstruct values used by parsing functions (tried e.g. Group, + Empty(), etc) The _fontconfig_pattern.py is a compatibility change adding a Group which was suggested by a similar warning. PR checklist "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested Plotting related features are demonstrated in an example New Features and API Changes are noted with a directive and release note Documentation complies with general and docstring guidelines
Open Graph Description: Closes #25204 PR summary This feels a bit more "workaround" than I'd really like, but it seems to work. Pyparsing warns when you try to name a forward reference before it is define...
X Description: Closes #25204 PR summary This feels a bit more "workaround" than I'd really like, but it seems to work. Pyparsing warns when you try to name a forward reference before ...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/27685
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:207c4893-f9bf-5a82-e2b5-e51ce71b252a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F14:FB8AB:F65941:14E2B4D:6A517507 |
| html-safe-nonce | 828af26e8408f296d039534d7a7c26bef11706fab7cf4b54f1ef6fd25c31d9fc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjE0OkZCOEFCOkY2NTk0MToxNEUyQjREOjZBNTE3NTA3IiwidmlzaXRvcl9pZCI6IjE3MzQxNzE3MTQxNjQ3MTY4MDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7c812ee93b335454055aeca61fa5392c74ff2e574a0aa8a95ec289bf419bb519 |
| hovercard-subject-tag | pull_request:1690547430 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/27685/files |
| twitter:image | https://avatars.githubusercontent.com/u/2501846?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2501846?s=400&v=4 |
| og:image:alt | Closes #25204 PR summary This feels a bit more "workaround" than I'd really like, but it seems to work. Pyparsing warns when you try to name a forward reference before it is define... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b19955a9dd40fd99462443f7911b522d7216776a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width