Title: MNT: prevent merging using labels + branch protection rules by story645 · Pull Request #27668 · matplotlib/matplotlib · GitHub
Open Graph Title: MNT: prevent merging using labels + branch protection rules by story645 · Pull Request #27668 · matplotlib/matplotlib
X Title: MNT: prevent merging using labels + branch protection rules by story645 · Pull Request #27668 · matplotlib/matplotlib
Description: PR summary Kinda been bugging @QuLogic about this for a while... This PR + some one w. org access adding a branch protection rule that blocks merges when this status check fails would allow us to grey out merging using a specific set of labels. As you can see in the workflow, the status check fails b/c this is labeled "status: needs comment/discussion" (and I tried to turn off most of the CI checks so folks can play with adding and removing the label) The motivation is b/c 'request changes' for reviews can be used in two ways: needs change but will be merged after change is implemented needs meta discussion, may not be merged And I think using it for 2. has made folks wary of using it for 1, and instead some maintainers use "leave comment" to communicate what they would need to see changed before they merge. My hope is that decoupling small comments from requesting technical changes from blocking a PR b/c there isn't consensus (or on some other label b/c it's an or list) can help us better communicate and manage expectations around what needs to happen next in the PR - make small set of changes or wait on discussion - and make maintainers more likely to use 'request changes' instead of 'comment' to communicate what they're waiting on being implemented before approving. If a maintainer disagrees on a "requested change", then they can always add a blocking label. Bonus is it also is a way to flag "this is not in draft, but also not ready for merging" for POC type work. PR checklist "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested Plotting related features are demonstrated in an example New Features and API Changes are noted with a directive and release note Documentation complies with general and docstring guidelines
Open Graph Description: PR summary Kinda been bugging @QuLogic about this for a while... This PR + some one w. org access adding a branch protection rule that blocks merges when this status check fails would allow us to...
X Description: PR summary Kinda been bugging @QuLogic about this for a while... This PR + some one w. org access adding a branch protection rule that blocks merges when this status check fails would allow us to...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/27668
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:61d90e85-c308-3311-09fa-4b0d9f15cfb1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A3BC:2DA3FB:11D3FD:191343:6A5465FE |
| html-safe-nonce | 47650f431f728ebcc4da9df262c61239346f155e86e022ef89c1040df50585d0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0JDOjJEQTNGQjoxMUQzRkQ6MTkxMzQzOjZBNTQ2NUZFIiwidmlzaXRvcl9pZCI6IjM4NTMyMDkwNDI2NTgyNTI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 711b933a7798ab14a4f9c837d1ceef809804f90fbe1fae172b689b1b482c131d |
| hovercard-subject-tag | pull_request:1685567848 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/27668/files |
| twitter:image | https://avatars.githubusercontent.com/u/1300499?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1300499?s=400&v=4 |
| og:image:alt | PR summary Kinda been bugging @QuLogic about this for a while... This PR + some one w. org access adding a branch protection rule that blocks merges when this status check fails would allow us to... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6d28624802c2f7d9500239dd6870ed7031b7353b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width