René's URL Explorer Experiment


Title: Change return type of `ion` and `ioff` to fix unbound variable errors with Pyright by FeldrinH · Pull Request #27667 · matplotlib/matplotlib · GitHub

Open Graph Title: Change return type of `ion` and `ioff` to fix unbound variable errors with Pyright by FeldrinH · Pull Request #27667 · matplotlib/matplotlib

X Title: Change return type of `ion` and `ioff` to fix unbound variable errors with Pyright by FeldrinH · Pull Request #27667 · matplotlib/matplotlib

Description: PR summary Closes #27659. By changing the return type annotation to AbstractContextManager, Pyright considers the context managers returned by ion and ioff as not supressing errors and does not give warnings about possibly unbound variables after the with block. This change has absolutely no effect on runtime behavior. It might cause type errors for users who store the return value of ion or ioff and attempt to call ExitStack-specific methods on it. However, the runtime behavior of such usage has not changed and the number of users who actually do this should be very small, given that the documentation explicitly forbids "storing or accessing" the returned context manager. PR checklist "closes #0000" is in the body of the PR description to link the related issue [N/A] new and changed code is tested [N/A] Plotting related features are demonstrated in an example [N/A] New Features and API Changes are noted with a directive and release note Documentation complies with general and docstring guidelines PS: I couldn't figure out from the developer documentation if changing a type hint constitutes an API change. Let me know if I need to add something to release notes.

Open Graph Description: PR summary Closes #27659. By changing the return type annotation to AbstractContextManager, Pyright considers the context managers returned by ion and ioff as not supressing errors and does not giv...

X Description: PR summary Closes #27659. By changing the return type annotation to AbstractContextManager, Pyright considers the context managers returned by ion and ioff as not supressing errors and does not giv...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/27667

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ab0d2142-d4d8-c592-86b8-494e2a24541b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD4B8:1EF2:EFDCD7:14C4214:6B0043B2
html-safe-nonce0d56a4af8e43da64f7f53ac66b3f6b4586e333c0d9bcf8a93eb03a0a5068422a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEI4OjFFRjI6RUZEQ0Q3OjE0QzQyMTQ6NkIwMDQzQjIiLCJ2aXNpdG9yX2lkIjoiNjE0MDYyMzUxNDkzMzE1MDY0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacebb753454a34068480f1e9eac6d6fc9a7d0cb3b49c4c53d10b182d2ddaf12a71
hovercard-subject-tagpull_request:1685494093
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/27667/files
twitter:imagehttps://avatars.githubusercontent.com/u/5256211?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5256211?s=400&v=4
og:image:altPR summary Closes #27659. By changing the return type annotation to AbstractContextManager, Pyright considers the context managers returned by ion and ioff as not supressing errors and does not giv...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/27667/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27667%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27667%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/27667/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/27667/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/27667/files
matplotlibhttps://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Codehttps://github.com/matplotlib/matplotlib
Issues1k (1k)https://github.com/matplotlib/matplotlib/issues
Pull requests430 (430)https://github.com/matplotlib/matplotlib/pulls
Actionshttps://github.com/matplotlib/matplotlib/actions
Projectshttps://github.com/matplotlib/matplotlib/projects
Wikihttps://github.com/matplotlib/matplotlib/wiki
Security and qualityhttps://github.com/matplotlib/matplotlib/security
Insightshttps://github.com/matplotlib/matplotlib/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
QuLogichttps://github.com/QuLogic
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
FeldrinH:ion-ioff-typinghttps://github.com/FeldrinH/matplotlib/tree/ion-ioff-typing
Conversation 7 https://github.com/matplotlib/matplotlib/pull/27667
Commits 4 https://github.com/matplotlib/matplotlib/pull/27667/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/27667/checks
Files changed https://github.com/matplotlib/matplotlib/pull/27667/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667/files
Change return type of ion and ioff to fix unbound variable errors with Pyright https://github.com/matplotlib/matplotlib/pull/27667/files#top
Show all changes 4 commits https://github.com/matplotlib/matplotlib/pull/27667/files
bafbe9c Change return type of ion and ioff to fix unbound variable errors wit… FeldrinH Jan 18, 2024 https://github.com/matplotlib/matplotlib/pull/27667/commits/bafbe9c27488ab8e018274131c4f9315bcfb2682
7a1461c Add comment explaining rationale FeldrinH Jan 18, 2024 https://github.com/matplotlib/matplotlib/pull/27667/commits/7a1461cbe0d51f7d6b7da61d1fcffc5ac4ed95ed
2f56a2a Fix flake8 lint error FeldrinH Jan 18, 2024 https://github.com/matplotlib/matplotlib/pull/27667/commits/2f56a2aaa8d7d7456d3f578d2136e7f2ebeaa62a
f49c0e3 Actually fix flake8 lint FeldrinH Jan 18, 2024 https://github.com/matplotlib/matplotlib/pull/27667/commits/f49c0e3d0bb51e9e7f613eb8967b82166e312c98
Clear filters https://github.com/matplotlib/matplotlib/pull/27667/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667/files
lib/matplotlib/pyplot.pyhttps://github.com/matplotlib/matplotlib/pull/27667/files#diff-d1edb5a528e7423f485b24cac2083d05d365a19352f886bf15af3ef442bdda92
View file https://github.com/FeldrinH/matplotlib/blob/f49c0e3d0bb51e9e7f613eb8967b82166e312c98/lib/matplotlib/pyplot.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/27667/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/27667/files#diff-d1edb5a528e7423f485b24cac2083d05d365a19352f886bf15af3ef442bdda92
https://github.com/matplotlib/matplotlib/pull/27667/files#diff-d1edb5a528e7423f485b24cac2083d05d365a19352f886bf15af3ef442bdda92
https://github.com/matplotlib/matplotlib/pull/27667/files#diff-d1edb5a528e7423f485b24cac2083d05d365a19352f886bf15af3ef442bdda92
https://github.com/matplotlib/matplotlib/pull/27667/files#diff-d1edb5a528e7423f485b24cac2083d05d365a19352f886bf15af3ef442bdda92
https://github.com/matplotlib/matplotlib/pull/27667/files#diff-d1edb5a528e7423f485b24cac2083d05d365a19352f886bf15af3ef442bdda92
https://github.com/matplotlib/matplotlib/pull/27667/files#diff-d1edb5a528e7423f485b24cac2083d05d365a19352f886bf15af3ef442bdda92
https://github.com/matplotlib/matplotlib/pull/27667/files#diff-d1edb5a528e7423f485b24cac2083d05d365a19352f886bf15af3ef442bdda92
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.