| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:448f7745-2739-8912-4124-bf2ac8bc5591 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9E32:2AD163:25C8A53:336D197:6B0039AB |
| html-safe-nonce | c01df986a3384a84c5e295607a7342c2e73b6881715fca58dce7a60d97cb03a0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTMyOjJBRDE2MzoyNUM4QTUzOjMzNkQxOTc6NkIwMDM5QUIiLCJ2aXNpdG9yX2lkIjoiMjM5MjgwMDg4MTY4Mzc0MTA5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 86ea1e57ad25051566ad6961922089fbb6bd546ab562af1383e3df0457226ce2 |
| hovercard-subject-tag | pull_request:1685494093 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/27667/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bba5efb8a877e0da51bff6e6d3d2bab19c2e97542e6ebcfc0bd4344037344aa7/matplotlib/matplotlib/pull/27667 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bba5efb8a877e0da51bff6e6d3d2bab19c2e97542e6ebcfc0bd4344037344aa7/matplotlib/matplotlib/pull/27667 |
| og:image:alt | PR summary
Closes #27659.
By changing the return type annotation to AbstractContextManager, Pyright considers the context managers returned by ion and ioff as not supressing errors and does not giv... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | FeldrinH |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/27667#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27667 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27667 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/27667 |
| Reload | https://github.com/matplotlib/matplotlib/pull/27667 |
| Reload | https://github.com/matplotlib/matplotlib/pull/27667 |
| matplotlib | https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Code | https://github.com/matplotlib/matplotlib |
| Issues1k (1k) | https://github.com/matplotlib/matplotlib/issues |
| Pull requests430 (430) | https://github.com/matplotlib/matplotlib/pulls |
| Actions | https://github.com/matplotlib/matplotlib/actions |
| Projects | https://github.com/matplotlib/matplotlib/projects |
| Wiki | https://github.com/matplotlib/matplotlib/wiki |
| Security and quality | https://github.com/matplotlib/matplotlib/security |
| Insights | https://github.com/matplotlib/matplotlib/insights |
| https://github.com/matplotlib/matplotlib |
| QuLogic | https://github.com/QuLogic |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| FeldrinH:ion-ioff-typing | https://github.com/FeldrinH/matplotlib/tree/ion-ioff-typing |
| Conversation | https://github.com/matplotlib/matplotlib/pull/27667 |
| Commits4 (4) | https://github.com/matplotlib/matplotlib/pull/27667/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/27667/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/27667/files |
| Change return type of ion and ioff to fix unbound variable errors with Pyright | https://github.com/matplotlib/matplotlib/pull/27667#top |
| QuLogic | https://github.com/QuLogic |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| FeldrinH:ion-ioff-typing | https://github.com/FeldrinH/matplotlib/tree/ion-ioff-typing |
|
| https://github.com/FeldrinH |
| FeldrinH | https://github.com/FeldrinH |
| Jan 18, 2024 | https://github.com/matplotlib/matplotlib/pull/27667#issue-2089006751 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27667 |
| #27659 | https://github.com/matplotlib/matplotlib/issues/27659 |
| link the related issue | https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
| tested | https://matplotlib.org/devdocs/devel/testing.html |
| example | https://matplotlib.org/devdocs/devel/document.html#write-examples-and-tutorials |
| directive and release note | https://matplotlib.org/devdocs/devel/api_changes.html#announce-changes-deprecations-and-new-features |
| general | https://matplotlib.org/devdocs/devel/document.html#write-rest-pages |
| docstring | https://matplotlib.org/devdocs/devel/document.html#write-docstrings |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27667 |
|
| https://github.com/FeldrinH |
| Change return type of ion and ioff to fix unbound variable errors wit… | https://github.com/matplotlib/matplotlib/pull/27667/commits/bafbe9c27488ab8e018274131c4f9315bcfb2682 |
| bafbe9c | https://github.com/matplotlib/matplotlib/pull/27667/commits/bafbe9c27488ab8e018274131c4f9315bcfb2682 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
topic: pyplot API
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20pyplot%20API%22 |
| Jan 18, 2024 | https://github.com/matplotlib/matplotlib/pull/27667#event-11529826402 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jan 18, 2024
| https://github.com/matplotlib/matplotlib/pull/27667#pullrequestreview-1830521118 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/27667/files/bafbe9c27488ab8e018274131c4f9315bcfb2682 |
| github-actions | https://github.com/apps/github-actions |
| https://github.com/matplotlib/matplotlib/pull/27667#pullrequestreview-1830521118 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| on gitter | https://gitter.im/matplotlib/matplotlib |
| the developer guide | https://matplotlib.org/devdocs/devel/index.html |
| Code of Conduct | https://github.com/matplotlib/matplotlib/blob/main/CODE_OF_CONDUCT.md |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27667 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Jan 18, 2024
| https://github.com/matplotlib/matplotlib/pull/27667#pullrequestreview-1830557149 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/27667/files/bafbe9c27488ab8e018274131c4f9315bcfb2682 |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
| Jan 18, 2024 | https://github.com/matplotlib/matplotlib/pull/27667#issuecomment-1899275421 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27667 |
| https://github.com/FeldrinH |
| FeldrinH | https://github.com/FeldrinH |
| Jan 18, 2024 | https://github.com/matplotlib/matplotlib/pull/27667#issuecomment-1899311872 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27667 |
| microsoft/pyright#7009 (comment) | https://github.com/microsoft/pyright/issues/7009#issuecomment-1894182975 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27667 |
| https://github.com/FeldrinH |
| FeldrinH | https://github.com/FeldrinH |
| Jan 18, 2024 | https://github.com/matplotlib/matplotlib/pull/27667#issuecomment-1899332638 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27667 |
| FeldrinH | https://github.com/FeldrinH |
| January 19, 2024 00:55 | https://github.com/matplotlib/matplotlib/pull/27667#commits-pushed-7a1461c |
|
| https://github.com/FeldrinH |
| Add comment explaining rationale | https://github.com/matplotlib/matplotlib/pull/27667/commits/7a1461cbe0d51f7d6b7da61d1fcffc5ac4ed95ed |
| 7a1461c | https://github.com/matplotlib/matplotlib/pull/27667/commits/7a1461cbe0d51f7d6b7da61d1fcffc5ac4ed95ed |
|
| https://github.com/FeldrinH |
| Fix flake8 lint error | https://github.com/matplotlib/matplotlib/pull/27667/commits/2f56a2aaa8d7d7456d3f578d2136e7f2ebeaa62a |
| 2f56a2a | https://github.com/matplotlib/matplotlib/pull/27667/commits/2f56a2aaa8d7d7456d3f578d2136e7f2ebeaa62a |
|
| https://github.com/FeldrinH |
| Actually fix flake8 lint | https://github.com/matplotlib/matplotlib/pull/27667/commits/f49c0e3d0bb51e9e7f613eb8967b82166e312c98 |
| f49c0e3 | https://github.com/matplotlib/matplotlib/pull/27667/commits/f49c0e3d0bb51e9e7f613eb8967b82166e312c98 |
| https://github.com/FeldrinH |
| FeldrinH | https://github.com/FeldrinH |
| Jan 18, 2024 | https://github.com/matplotlib/matplotlib/pull/27667#issuecomment-1899366118 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27667 |
| microsoft/pyright#7009 (comment) | https://github.com/microsoft/pyright/issues/7009#issuecomment-1899351582 |
| microsoft/pyright#7009 (comment) | https://github.com/microsoft/pyright/issues/7009#issuecomment-1894182975 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27667 |
| https://github.com/FeldrinH |
| FeldrinH | https://github.com/FeldrinH |
| Feb 22, 2024 | https://github.com/matplotlib/matplotlib/pull/27667#issuecomment-1960506385 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27667 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| v3.9.0 | https://github.com/matplotlib/matplotlib/milestone/78 |
| Feb 23, 2024 | https://github.com/matplotlib/matplotlib/pull/27667#event-11898161062 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Feb 23, 2024
| https://github.com/matplotlib/matplotlib/pull/27667#pullrequestreview-1897204604 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/27667/files/f49c0e3d0bb51e9e7f613eb8967b82166e312c98 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
topic: typing
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20typing%22 |
| Feb 23, 2024 | https://github.com/matplotlib/matplotlib/pull/27667#event-11898166590 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| b6f7a68 | https://github.com/matplotlib/matplotlib/commit/b6f7a68207fcaa2ddeb053334113c96abbdacdf6 |
| Feb 23, 2024 | https://github.com/matplotlib/matplotlib/pull/27667#event-11898167182 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| Feb 23, 2024 | https://github.com/matplotlib/matplotlib/pull/27667#issuecomment-1960555048 |
| @FeldrinH | https://github.com/FeldrinH |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27667 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27667 |
|
| https://github.com/apps/github-actions |
|
github-actions[bot]
| https://github.com/apps/github-actions |
|
| https://github.com/matplotlib/matplotlib/pull/27667/files/bafbe9c27488ab8e018274131c4f9315bcfb2682 |
|
| https://github.com/QuLogic |
|
QuLogic
| https://github.com/QuLogic |
|
| https://github.com/matplotlib/matplotlib/pull/27667/files/f49c0e3d0bb51e9e7f613eb8967b82166e312c98 |
|
| https://github.com/anntzer |
|
anntzer
| https://github.com/anntzer |
|
| https://github.com/matplotlib/matplotlib/pull/27667/files/bafbe9c27488ab8e018274131c4f9315bcfb2682 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27667 |
|
topic: pyplot API
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20pyplot%20API%22 |
|
topic: typing
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20typing%22 |
|
v3.9.0
| https://github.com/matplotlib/matplotlib/milestone/78 |
|
[MNT]: Improve return type of ioff and ion to improve Pyright analysis of bound variables
| https://github.com/matplotlib/matplotlib/issues/27659 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27667 |
|
| https://github.com/FeldrinH |
|
| https://github.com/ksunden |
|
| https://github.com/QuLogic |
|
| https://github.com/anntzer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |