René's URL Explorer Experiment


Title: Change return type of `ion` and `ioff` to fix unbound variable errors with Pyright by FeldrinH · Pull Request #27667 · matplotlib/matplotlib · GitHub

Open Graph Title: Change return type of `ion` and `ioff` to fix unbound variable errors with Pyright by FeldrinH · Pull Request #27667 · matplotlib/matplotlib

X Title: Change return type of `ion` and `ioff` to fix unbound variable errors with Pyright by FeldrinH · Pull Request #27667 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR summary Closes #27659. By changing the return type annotation to AbstractContextManager, Pyright considers the context managers returned by ion and ioff as not supressing errors and does not giv...

X Description: PR summary Closes #27659. By changing the return type annotation to AbstractContextManager, Pyright considers the context managers returned by ion and ioff as not supressing errors and does not giv...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/27667

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:448f7745-2739-8912-4124-bf2ac8bc5591
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E32:2AD163:25C8A53:336D197:6B0039AB
html-safe-noncec01df986a3384a84c5e295607a7342c2e73b6881715fca58dce7a60d97cb03a0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTMyOjJBRDE2MzoyNUM4QTUzOjMzNkQxOTc6NkIwMDM5QUIiLCJ2aXNpdG9yX2lkIjoiMjM5MjgwMDg4MTY4Mzc0MTA5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac86ea1e57ad25051566ad6961922089fbb6bd546ab562af1383e3df0457226ce2
hovercard-subject-tagpull_request:1685494093
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/27667/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bba5efb8a877e0da51bff6e6d3d2bab19c2e97542e6ebcfc0bd4344037344aa7/matplotlib/matplotlib/pull/27667
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bba5efb8a877e0da51bff6e6d3d2bab19c2e97542e6ebcfc0bd4344037344aa7/matplotlib/matplotlib/pull/27667
og:image:altPR summary Closes #27659. By changing the return type annotation to AbstractContextManager, Pyright considers the context managers returned by ion and ioff as not supressing errors and does not giv...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFeldrinH
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/27667#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27667
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27667
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/27667
Reloadhttps://github.com/matplotlib/matplotlib/pull/27667
Reloadhttps://github.com/matplotlib/matplotlib/pull/27667
matplotlibhttps://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Codehttps://github.com/matplotlib/matplotlib
Issues1k (1k)https://github.com/matplotlib/matplotlib/issues
Pull requests430 (430)https://github.com/matplotlib/matplotlib/pulls
Actionshttps://github.com/matplotlib/matplotlib/actions
Projectshttps://github.com/matplotlib/matplotlib/projects
Wikihttps://github.com/matplotlib/matplotlib/wiki
Security and qualityhttps://github.com/matplotlib/matplotlib/security
Insightshttps://github.com/matplotlib/matplotlib/insights
https://github.com/matplotlib/matplotlib
QuLogichttps://github.com/QuLogic
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
FeldrinH:ion-ioff-typinghttps://github.com/FeldrinH/matplotlib/tree/ion-ioff-typing
Conversationhttps://github.com/matplotlib/matplotlib/pull/27667
Commits4 (4)https://github.com/matplotlib/matplotlib/pull/27667/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/27667/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/27667/files
Change return type of ion and ioff to fix unbound variable errors with Pyrighthttps://github.com/matplotlib/matplotlib/pull/27667#top
QuLogichttps://github.com/QuLogic
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
FeldrinH:ion-ioff-typinghttps://github.com/FeldrinH/matplotlib/tree/ion-ioff-typing
https://github.com/FeldrinH
FeldrinHhttps://github.com/FeldrinH
Jan 18, 2024https://github.com/matplotlib/matplotlib/pull/27667#issue-2089006751
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667
#27659https://github.com/matplotlib/matplotlib/issues/27659
link the related issuehttps://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
testedhttps://matplotlib.org/devdocs/devel/testing.html
examplehttps://matplotlib.org/devdocs/devel/document.html#write-examples-and-tutorials
directive and release notehttps://matplotlib.org/devdocs/devel/api_changes.html#announce-changes-deprecations-and-new-features
generalhttps://matplotlib.org/devdocs/devel/document.html#write-rest-pages
docstringhttps://matplotlib.org/devdocs/devel/document.html#write-docstrings
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667
https://github.com/FeldrinH
Change return type of ion and ioff to fix unbound variable errors wit…https://github.com/matplotlib/matplotlib/pull/27667/commits/bafbe9c27488ab8e018274131c4f9315bcfb2682
bafbe9chttps://github.com/matplotlib/matplotlib/pull/27667/commits/bafbe9c27488ab8e018274131c4f9315bcfb2682
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
topic: pyplot API https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20pyplot%20API%22
Jan 18, 2024https://github.com/matplotlib/matplotlib/pull/27667#event-11529826402
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 18, 2024 https://github.com/matplotlib/matplotlib/pull/27667#pullrequestreview-1830521118
View reviewed changes https://github.com/matplotlib/matplotlib/pull/27667/files/bafbe9c27488ab8e018274131c4f9315bcfb2682
github-actionshttps://github.com/apps/github-actions
https://github.com/matplotlib/matplotlib/pull/27667#pullrequestreview-1830521118
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
on gitterhttps://gitter.im/matplotlib/matplotlib
the developer guidehttps://matplotlib.org/devdocs/devel/index.html
Code of Conducthttps://github.com/matplotlib/matplotlib/blob/main/CODE_OF_CONDUCT.md
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Jan 18, 2024 https://github.com/matplotlib/matplotlib/pull/27667#pullrequestreview-1830557149
View reviewed changes https://github.com/matplotlib/matplotlib/pull/27667/files/bafbe9c27488ab8e018274131c4f9315bcfb2682
https://github.com/ksunden
ksundenhttps://github.com/ksunden
Jan 18, 2024https://github.com/matplotlib/matplotlib/pull/27667#issuecomment-1899275421
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667
https://github.com/FeldrinH
FeldrinHhttps://github.com/FeldrinH
Jan 18, 2024https://github.com/matplotlib/matplotlib/pull/27667#issuecomment-1899311872
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667
microsoft/pyright#7009 (comment)https://github.com/microsoft/pyright/issues/7009#issuecomment-1894182975
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667
https://github.com/FeldrinH
FeldrinHhttps://github.com/FeldrinH
Jan 18, 2024https://github.com/matplotlib/matplotlib/pull/27667#issuecomment-1899332638
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667
FeldrinHhttps://github.com/FeldrinH
January 19, 2024 00:55https://github.com/matplotlib/matplotlib/pull/27667#commits-pushed-7a1461c
https://github.com/FeldrinH
Add comment explaining rationalehttps://github.com/matplotlib/matplotlib/pull/27667/commits/7a1461cbe0d51f7d6b7da61d1fcffc5ac4ed95ed
7a1461chttps://github.com/matplotlib/matplotlib/pull/27667/commits/7a1461cbe0d51f7d6b7da61d1fcffc5ac4ed95ed
https://github.com/FeldrinH
Fix flake8 lint errorhttps://github.com/matplotlib/matplotlib/pull/27667/commits/2f56a2aaa8d7d7456d3f578d2136e7f2ebeaa62a
2f56a2ahttps://github.com/matplotlib/matplotlib/pull/27667/commits/2f56a2aaa8d7d7456d3f578d2136e7f2ebeaa62a
https://github.com/FeldrinH
Actually fix flake8 linthttps://github.com/matplotlib/matplotlib/pull/27667/commits/f49c0e3d0bb51e9e7f613eb8967b82166e312c98
f49c0e3https://github.com/matplotlib/matplotlib/pull/27667/commits/f49c0e3d0bb51e9e7f613eb8967b82166e312c98
https://github.com/FeldrinH
FeldrinHhttps://github.com/FeldrinH
Jan 18, 2024https://github.com/matplotlib/matplotlib/pull/27667#issuecomment-1899366118
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667
microsoft/pyright#7009 (comment)https://github.com/microsoft/pyright/issues/7009#issuecomment-1899351582
microsoft/pyright#7009 (comment)https://github.com/microsoft/pyright/issues/7009#issuecomment-1894182975
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667
https://github.com/FeldrinH
FeldrinHhttps://github.com/FeldrinH
Feb 22, 2024https://github.com/matplotlib/matplotlib/pull/27667#issuecomment-1960506385
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
v3.9.0https://github.com/matplotlib/matplotlib/milestone/78
Feb 23, 2024https://github.com/matplotlib/matplotlib/pull/27667#event-11898161062
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Feb 23, 2024 https://github.com/matplotlib/matplotlib/pull/27667#pullrequestreview-1897204604
View reviewed changes https://github.com/matplotlib/matplotlib/pull/27667/files/f49c0e3d0bb51e9e7f613eb8967b82166e312c98
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
topic: typing https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20typing%22
Feb 23, 2024https://github.com/matplotlib/matplotlib/pull/27667#event-11898166590
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
b6f7a68https://github.com/matplotlib/matplotlib/commit/b6f7a68207fcaa2ddeb053334113c96abbdacdf6
Feb 23, 2024https://github.com/matplotlib/matplotlib/pull/27667#event-11898167182
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Feb 23, 2024https://github.com/matplotlib/matplotlib/pull/27667#issuecomment-1960555048
@FeldrinHhttps://github.com/FeldrinH
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27667
https://github.com/apps/github-actions
github-actions[bot] https://github.com/apps/github-actions
https://github.com/matplotlib/matplotlib/pull/27667/files/bafbe9c27488ab8e018274131c4f9315bcfb2682
https://github.com/QuLogic
QuLogic https://github.com/QuLogic
https://github.com/matplotlib/matplotlib/pull/27667/files/f49c0e3d0bb51e9e7f613eb8967b82166e312c98
https://github.com/anntzer
anntzer https://github.com/anntzer
https://github.com/matplotlib/matplotlib/pull/27667/files/bafbe9c27488ab8e018274131c4f9315bcfb2682
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667
topic: pyplot API https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20pyplot%20API%22
topic: typing https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20typing%22
v3.9.0 https://github.com/matplotlib/matplotlib/milestone/78
[MNT]: Improve return type of ioff and ion to improve Pyright analysis of bound variables https://github.com/matplotlib/matplotlib/issues/27659
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27667
https://github.com/FeldrinH
https://github.com/ksunden
https://github.com/QuLogic
https://github.com/anntzer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.