René's URL Explorer Experiment


Title: Fixed legend with legend location "best" when legend overlaps shaded area and text by alanlau28 · Pull Request #27469 · matplotlib/matplotlib · GitHub

Open Graph Title: Fixed legend with legend location "best" when legend overlaps shaded area and text by alanlau28 · Pull Request #27469 · matplotlib/matplotlib

X Title: Fixed legend with legend location "best" when legend overlaps shaded area and text by alanlau28 · Pull Request #27469 · matplotlib/matplotlib

Description: PR summary This PR fixes bug #27414 and #23323. The calculation of badness in the legend location for 'best' now considers PolyCollection and Text. For PolyCollection, the paths are now converted to lines to check for hit detection when placing a legend. For Text, the bounding box is now checked for overlap. PR checklist "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested Plotting related features are demonstrated in an example New Features and API Changes are noted with a directive and release note Documentation complies with general and docstring guidelines

Open Graph Description: PR summary This PR fixes bug #27414 and #23323. The calculation of badness in the legend location for 'best' now considers PolyCollection and Text. For PolyCollection, the paths are now c...

X Description: PR summary This PR fixes bug #27414 and #23323. The calculation of badness in the legend location for 'best' now considers PolyCollection and Text. For PolyCollection, the paths a...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/27469

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e21ecf0e-6a92-1e0e-600a-93d5b0b9ea44
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D2A:3321F9:AF303:EA620:6A52BDF5
html-safe-nonce5882821d3887f48b83a7337581e6d0154fd4030bbb535a622d9dcebaf23e7072
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDJBOjMzMjFGOTpBRjMwMzpFQTYyMDo2QTUyQkRGNSIsInZpc2l0b3JfaWQiOiI1MDI4ODcyODMyMzc0OTgwMDg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4312042e6c39cbc54e33cc14cb6a713b9653dce3dbff7077a24a0c16f212f53c
hovercard-subject-tagpull_request:1635526618
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/27469/files
twitter:imagehttps://avatars.githubusercontent.com/u/72107214?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/72107214?s=400&v=4
og:image:altPR summary This PR fixes bug #27414 and #23323. The calculation of badness in the legend location for 'best' now considers PolyCollection and Text. For PolyCollection, the paths are now c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/27469/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27469%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27469%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/27469/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/27469/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/27469/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27469/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27469/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
ksundenhttps://github.com/ksunden
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
alanlau28:fix-legend-lochttps://github.com/alanlau28/matplotlib/tree/fix-legend-loc
Conversation 15 https://github.com/matplotlib/matplotlib/pull/27469
Commits 1 https://github.com/matplotlib/matplotlib/pull/27469/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/27469/checks
Files changed https://github.com/matplotlib/matplotlib/pull/27469/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27469/files
Fixed legend with legend location "best" when legend overlaps shaded area and text https://github.com/matplotlib/matplotlib/pull/27469/files#top
Show all changes 1 commit https://github.com/matplotlib/matplotlib/pull/27469/files
87d05ae Fix legend auto-placement in the presence of text or PolyCollections alanlau28 Dec 8, 2023 https://github.com/matplotlib/matplotlib/pull/27469/commits/87d05aea59a339b54477cf405dadb5a7bb9a8c08
Clear filters https://github.com/matplotlib/matplotlib/pull/27469/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27469/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27469/files
27469-AL.rst https://github.com/matplotlib/matplotlib/pull/27469/files#diff-34250d5855078613e704089a08783ae58e3050789a7884b6549ee611964c90a1
legend.py https://github.com/matplotlib/matplotlib/pull/27469/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a
legend_stackplot.png https://github.com/matplotlib/matplotlib/pull/27469/files#diff-2225a4e852b9058c91114a016b42f17f820c73b9c3d276c7ecbf881999ab6e62
test_legend.py https://github.com/matplotlib/matplotlib/pull/27469/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579
doc/api/next_api_changes/behavior/27469-AL.rsthttps://github.com/matplotlib/matplotlib/pull/27469/files#diff-34250d5855078613e704089a08783ae58e3050789a7884b6549ee611964c90a1
View file https://github.com/alanlau28/matplotlib/blob/87d05aea59a339b54477cf405dadb5a7bb9a8c08/doc/api/next_api_changes/behavior/27469-AL.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/27469/{{ revealButtonHref }}
lib/matplotlib/legend.pyhttps://github.com/matplotlib/matplotlib/pull/27469/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a
View file https://github.com/alanlau28/matplotlib/blob/87d05aea59a339b54477cf405dadb5a7bb9a8c08/lib/matplotlib/legend.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/27469/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/27469/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a
https://github.com/matplotlib/matplotlib/pull/27469/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a
lib/matplotlib/tests/baseline_images/test_legend/legend_stackplot.pnghttps://github.com/matplotlib/matplotlib/pull/27469/files#diff-2225a4e852b9058c91114a016b42f17f820c73b9c3d276c7ecbf881999ab6e62
View file https://github.com/alanlau28/matplotlib/blob/87d05aea59a339b54477cf405dadb5a7bb9a8c08/lib/matplotlib/tests/baseline_images/test_legend/legend_stackplot.png
Open in desktop https://desktop.github.com
Reload?https://github.com/matplotlib/matplotlib/pull/27469/files
lib/matplotlib/tests/test_legend.pyhttps://github.com/matplotlib/matplotlib/pull/27469/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579
View file https://github.com/alanlau28/matplotlib/blob/87d05aea59a339b54477cf405dadb5a7bb9a8c08/lib/matplotlib/tests/test_legend.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/27469/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/27469/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.