| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c1816cf2-bf8f-ad4d-9577-ec0952183ad8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E130:2DCEA7:10060D9:154BE85:6A5333BA |
| html-safe-nonce | cdeda98001ec12926211ddb7298cff3f19a749b1c5817be57ee63451fcc602dc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTMwOjJEQ0VBNzoxMDA2MEQ5OjE1NEJFODU6NkE1MzMzQkEiLCJ2aXNpdG9yX2lkIjoiODEwODM2NjI0NzYyMjgxNjY5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8f26323899a2e99f2448669cce1b877c22c80c82dd59dfed486377d6cdc44daa |
| hovercard-subject-tag | pull_request:1625195583 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/27415/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f7976f7b50b143cb6c91663f6b458b61753c3889ca4e0684eb640e792a7fc212/matplotlib/matplotlib/pull/27415 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f7976f7b50b143cb6c91663f6b458b61753c3889ca4e0684eb640e792a7fc212/matplotlib/matplotlib/pull/27415 |
| og:image:alt | PR summary
When these were added in #20118, we had no type annotations, so it made sense to use the functional form. Now that we do, there's no reason not to use the class form.
Also, as FontEn... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | QuLogic |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/27415#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27415 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27415 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/27415 |
| Reload | https://github.com/matplotlib/matplotlib/pull/27415 |
| Reload | https://github.com/matplotlib/matplotlib/pull/27415 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27415 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27415 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
408
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| ksunden | https://github.com/ksunden |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| QuLogic:dataclass-class | https://github.com/QuLogic/matplotlib/tree/dataclass-class |
| Conversation | https://github.com/matplotlib/matplotlib/pull/27415 |
| Commits2 (2) | https://github.com/matplotlib/matplotlib/pull/27415/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/27415/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/27415/files |
| Use class form of data classes | https://github.com/matplotlib/matplotlib/pull/27415#top |
| ksunden | https://github.com/ksunden |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| QuLogic:dataclass-class | https://github.com/QuLogic/matplotlib/tree/dataclass-class |
|
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| Dec 1, 2023 | https://github.com/matplotlib/matplotlib/pull/27415#issue-2020326172 |
| #20118 | https://github.com/matplotlib/matplotlib/pull/20118 |
| link the related issue | https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
| tested | https://matplotlib.org/devdocs/devel/testing.html |
| example | https://matplotlib.org/devdocs/devel/document.html#write-examples-and-tutorials |
| directive and release note | https://matplotlib.org/devdocs/devel/coding_guide.html#new-features-and-api-changes |
| general | https://matplotlib.org/devdocs/devel/document.html#write-rest-pages |
| docstring | https://matplotlib.org/devdocs/devel/document.html#write-docstrings |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27415 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Maintenance
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3AMaintenance |
| Dec 1, 2023 | https://github.com/matplotlib/matplotlib/pull/27415#event-11118873280 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| v3.9.0 | https://github.com/matplotlib/matplotlib/milestone/78 |
| Dec 1, 2023 | https://github.com/matplotlib/matplotlib/pull/27415#event-11118873795 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Dec 1, 2023
| https://github.com/matplotlib/matplotlib/pull/27415#pullrequestreview-1759726127 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/27415/files |
| galleries/examples/widgets/menu.py | https://github.com/matplotlib/matplotlib/pull/27415/files#diff-f0d7ba8992830fad594510fe3073659abf39f8bb76f56b49abaa2deedfce12d3 |
| timhoffm | https://github.com/timhoffm |
| Dec 1, 2023 | https://github.com/matplotlib/matplotlib/pull/27415#discussion_r1412052090 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27415 |
| QuLogic | https://github.com/QuLogic |
| Jan 13, 2024 | https://github.com/matplotlib/matplotlib/pull/27415#discussion_r1451077262 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27415 |
| lib/matplotlib/font_manager.py | https://github.com/matplotlib/matplotlib/pull/27415/files#diff-aca801331b4c856bff720af0575b9ad63f402c893abd7d939e5547ba961ee324 |
| timhoffm | https://github.com/timhoffm |
| Dec 1, 2023 | https://github.com/matplotlib/matplotlib/pull/27415#discussion_r1412061426 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| matplotlib/lib/matplotlib/font_manager.py | https://github.com/matplotlib/matplotlib/blob/379989e9529b9c98dc866a338b272beedf1f697a/lib/matplotlib/font_manager.py#L937-L938 |
| 379989e | https://github.com/matplotlib/matplotlib/commit/379989e9529b9c98dc866a338b272beedf1f697a |
| https://github.com/jsonpickle/jsonpickle/pull/397/files | https://github.com/jsonpickle/jsonpickle/pull/397/files |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27415 |
| QuLogic | https://github.com/QuLogic |
| Jan 13, 2024 | https://github.com/matplotlib/matplotlib/pull/27415#discussion_r1451079910 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27415 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/d1fd3971f2e0b6296f116338de1ce56b24203af9..5d774d4301d695557100d1bb3b137fc2d8c54257 |
| d1fd397 | https://github.com/matplotlib/matplotlib/commit/d1fd3971f2e0b6296f116338de1ce56b24203af9 |
| 5d774d4 | https://github.com/matplotlib/matplotlib/commit/5d774d4301d695557100d1bb3b137fc2d8c54257 |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/d1fd3971f2e0b6296f116338de1ce56b24203af9..5d774d4301d695557100d1bb3b137fc2d8c54257 |
| January 13, 2024 01:48 | https://github.com/matplotlib/matplotlib/pull/27415#event-11475696002 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
topic: mpl_toolkit
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20mpl_toolkit%22 |
|
backend: pdf
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22backend%3A%20pdf%22 |
|
Documentation: examples
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Documentation%3A%20examples%22 |
| Jan 13, 2024 | https://github.com/matplotlib/matplotlib/pull/27415#event-11475696566 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
topic: mpl_toolkit
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20mpl_toolkit%22 |
| Jan 13, 2024 | https://github.com/matplotlib/matplotlib/pull/27415#event-11475727658 |
| QuLogic | https://github.com/QuLogic |
| January 13, 2024 01:46 | https://github.com/matplotlib/matplotlib/pull/27415#commits-pushed-cb5cb9c |
|
| https://github.com/QuLogic |
| Use class form of data classes | https://github.com/matplotlib/matplotlib/pull/27415/commits/cb5cb9cbe3102e88b403512dc05cba901edc82bd |
| cb5cb9c | https://github.com/matplotlib/matplotlib/pull/27415/commits/cb5cb9cbe3102e88b403512dc05cba901edc82bd |
| matplotlib#20118 | https://github.com/matplotlib/matplotlib/pull/20118 |
|
| https://github.com/QuLogic |
| DOC: Use a data class in the menu example | https://github.com/matplotlib/matplotlib/pull/27415/commits/5e5962f805d57727b0840fb858a943519987f127 |
| 5e5962f | https://github.com/matplotlib/matplotlib/pull/27415/commits/5e5962f805d57727b0840fb858a943519987f127 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/5d774d4301d695557100d1bb3b137fc2d8c54257..5e5962f805d57727b0840fb858a943519987f127 |
| 5d774d4 | https://github.com/matplotlib/matplotlib/commit/5d774d4301d695557100d1bb3b137fc2d8c54257 |
| 5e5962f | https://github.com/matplotlib/matplotlib/commit/5e5962f805d57727b0840fb858a943519987f127 |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/5d774d4301d695557100d1bb3b137fc2d8c54257..5e5962f805d57727b0840fb858a943519987f127 |
| January 13, 2024 06:46 | https://github.com/matplotlib/matplotlib/pull/27415#event-11476930102 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
topic: mpl_toolkit
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20mpl_toolkit%22 |
|
Documentation: API
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Documentation%3A%20API%22 |
| Jan 13, 2024 | https://github.com/matplotlib/matplotlib/pull/27415#event-11476930609 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
topic: mpl_toolkit
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20mpl_toolkit%22 |
| Jan 13, 2024 | https://github.com/matplotlib/matplotlib/pull/27415#event-11477643222 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Jan 14, 2024
| https://github.com/matplotlib/matplotlib/pull/27415#pullrequestreview-1820300775 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/27415/files/5e5962f805d57727b0840fb858a943519987f127 |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
|
Jan 15, 2024
| https://github.com/matplotlib/matplotlib/pull/27415#pullrequestreview-1822221195 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/27415/files/5e5962f805d57727b0840fb858a943519987f127 |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
| c447b60 | https://github.com/matplotlib/matplotlib/commit/c447b60486e196fd4c76d72c848a22662fbed0e4 |
| Jan 15, 2024 | https://github.com/matplotlib/matplotlib/pull/27415#event-11491890375 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| January 16, 2024 00:07 | https://github.com/matplotlib/matplotlib/pull/27415#event-11492928371 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27415 |
|
| https://github.com/ksunden |
|
ksunden
| https://github.com/ksunden |
|
| https://github.com/matplotlib/matplotlib/pull/27415/files/5e5962f805d57727b0840fb858a943519987f127 |
|
| https://github.com/timhoffm |
|
timhoffm
| https://github.com/timhoffm |
|
| https://github.com/matplotlib/matplotlib/pull/27415/files/5e5962f805d57727b0840fb858a943519987f127 |
|
backend: pdf
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22backend%3A%20pdf%22 |
|
Documentation: API
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Documentation%3A%20API%22 |
|
Documentation: examples
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Documentation%3A%20examples%22 |
|
Maintenance
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3AMaintenance |
|
v3.9.0
| https://github.com/matplotlib/matplotlib/milestone/78 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/27415 |
|
| https://github.com/QuLogic |
|
| https://github.com/ksunden |
|
| https://github.com/timhoffm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |