René's URL Explorer Experiment


Title: Fix build on PyPy by QuLogic · Pull Request #27359 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix build on PyPy by QuLogic · Pull Request #27359 · matplotlib/matplotlib

X Title: Fix build on PyPy by QuLogic · Pull Request #27359 · matplotlib/matplotlib

Description: PR summary It appears that Py_FileSystemDefaultEncodeErrors is not part of the limited API, and PyPy does not have it. This broke wheel building CI only, as PyPy isn't otherwise built. Since pybind11 does not have a wrapper for PyUnicode_EncodeFSDefault (the main reason I had switched to a encode call earlier), we need to call it ourselves manually. PR checklist [n/a] "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested [n/a] Plotting related features are demonstrated in an example [n/a] New Features and API Changes are noted with a directive and release note [n/a] Documentation complies with general and docstring guidelines

Open Graph Description: PR summary It appears that Py_FileSystemDefaultEncodeErrors is not part of the limited API, and PyPy does not have it. This broke wheel building CI only, as PyPy isn't otherwise built. Since py...

X Description: PR summary It appears that Py_FileSystemDefaultEncodeErrors is not part of the limited API, and PyPy does not have it. This broke wheel building CI only, as PyPy isn't otherwise built. Sinc...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/27359

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cebc088e-7c0e-4a49-4b66-99279e3295e8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAEE6:19C73D:A4F87D:DE69CE:6A5312AB
html-safe-nonced60f026fcfa9ca40ac011cd6d2156a425d67d6c639f457821816fc710913f44d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUU2OjE5QzczRDpBNEY4N0Q6REU2OUNFOjZBNTMxMkFCIiwidmlzaXRvcl9pZCI6Ijc2NTE3NjMzMzA4Nzc2OTA1MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac730f6078f046db2e6c5ccb96c3ac00664dcfbb9cd5117907571ff3ad15d8fe60
hovercard-subject-tagpull_request:1611647500
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/27359/files
twitter:imagehttps://avatars.githubusercontent.com/u/302469?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302469?s=400&v=4
og:image:altPR summary It appears that Py_FileSystemDefaultEncodeErrors is not part of the limited API, and PyPy does not have it. This broke wheel building CI only, as PyPy isn't otherwise built. Since py...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/27359/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27359%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F27359%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/27359/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/27359/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/27359/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27359/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27359/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
oscargushttps://github.com/oscargus
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
QuLogic:fix-pypyhttps://github.com/QuLogic/matplotlib/tree/fix-pypy
Conversation 6 https://github.com/matplotlib/matplotlib/pull/27359
Commits 1 https://github.com/matplotlib/matplotlib/pull/27359/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/27359/checks
Files changed https://github.com/matplotlib/matplotlib/pull/27359/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27359/files
Fix build on PyPy https://github.com/matplotlib/matplotlib/pull/27359/files#top
Show all changes 1 commit https://github.com/matplotlib/matplotlib/pull/27359/files
e08cbf1 Fix build on PyPy QuLogic Nov 21, 2023 https://github.com/matplotlib/matplotlib/pull/27359/commits/e08cbf197fde11619405895ec1067d1b1caf88a1
Clear filters https://github.com/matplotlib/matplotlib/pull/27359/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27359/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/27359/files
src/_tkagg.cpphttps://github.com/matplotlib/matplotlib/pull/27359/files#diff-3738bd01dcd1fd4455918f1845644a116249a0c94b2f8663e905a7ea909460d3
View file https://github.com/QuLogic/matplotlib/blob/e08cbf197fde11619405895ec1067d1b1caf88a1/src/_tkagg.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/27359/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/27359/files#diff-3738bd01dcd1fd4455918f1845644a116249a0c94b2f8663e905a7ea909460d3
https://github.com/matplotlib/matplotlib/pull/27359/files#diff-3738bd01dcd1fd4455918f1845644a116249a0c94b2f8663e905a7ea909460d3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.