Title: Add datetime testing skeleton by tacaswell · Pull Request #26859 · matplotlib/matplotlib · GitHub
Open Graph Title: Add datetime testing skeleton by tacaswell · Pull Request #26859 · matplotlib/matplotlib
X Title: Add datetime testing skeleton by tacaswell · Pull Request #26859 · matplotlib/matplotlib
Description: This is prep work for the 2023 GHC OSD event. Although we nominally support units through all of our plotting APIs, this is not actually tested. As the most common "unitful" data is likely datetime, this is using datetime as the vehicle to exhaustively test which of the methods correctly handle units. The ask of the volunteers will be to pick a method and write/find an example that passes datetime64 or timedelta64 arrays to as many of the inputs as make sense. Then if this works, open a PR adding the implementation as a test to this file + the output of the example when run as an image if this fails decide if: it should not work (for example ax.pie makes no sense with dates as the input so I pre-emptively removed it...although maybe with timedelta?) open a PR removing that stub test if it should work open an issue with the failing example Unfortunately I did not get the test image overhaul done in time so I want to avoid adding test images for now, but smoke tests are still an improvement and once that lands it should be possible to "just" add a decorator to the tests to generate the images in the future.
Open Graph Description: This is prep work for the 2023 GHC OSD event. Although we nominally support units through all of our plotting APIs, this is not actually tested. As the most common "unitful" data is like...
X Description: This is prep work for the 2023 GHC OSD event. Although we nominally support units through all of our plotting APIs, this is not actually tested. As the most common "unitful" data...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/26859
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4671e194-4709-0833-6694-19ed3aad37d4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F38:19F60D:19D8A62:221A623:6A51D60B |
| html-safe-nonce | 481ee9bb3ca05ea9e48bc2eaff019aba71a1c3a6f5e88fba2f88ea285e798709 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjM4OjE5RjYwRDoxOUQ4QTYyOjIyMUE2MjM6NkE1MUQ2MEIiLCJ2aXNpdG9yX2lkIjoiNzg3MDE3MzE5ODI0NzEyMjQ0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 21430aa49dcb7703826edd7b28f6266996febeca33083758a26826b1cc772403 |
| hovercard-subject-tag | pull_request:1525290311 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/26859/files |
| twitter:image | https://avatars.githubusercontent.com/u/199813?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/199813?s=400&v=4 |
| og:image:alt | This is prep work for the 2023 GHC OSD event. Although we nominally support units through all of our plotting APIs, this is not actually tested. As the most common "unitful" data is like... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width