René's URL Explorer Experiment


Title: Improve RectangleSelector Rotation revisited and rebased by dhomeier · Pull Request #26833 · matplotlib/matplotlib · GitHub

Open Graph Title: Improve RectangleSelector Rotation revisited and rebased by dhomeier · Pull Request #26833 · matplotlib/matplotlib

X Title: Improve RectangleSelector Rotation revisited and rebased by dhomeier · Pull Request #26833 · matplotlib/matplotlib

Description: PR summary This PR rebases the changes from #21945 onto (post-3.8.0) main. Since the merge conflicts after almost 2 years became prohibitive, I have applied the original modifications to a fresh PR. Almost all actual code changes are taken from @dstansby's original PR; from its summary: This modifies RectangleSelector and EllipseSelector to be drawn in display coordinates instead of display coordinates. This has a number of advantages: Allows the rectangle to be rotated past the previous +/- 45 degrees limit Fixes scaling the rectangle when it is rotated (to demonstrate, create a selector with rotation and try scaling before and then with this PR). Removes the need for _aspect_ratio_correction. Improves performance, because the event handling and artist drawing is all done in figure coordinates, removing transformations to data coordinates and back. Code to test: import matplotlib.pyplot as plt from matplotlib.widgets import RectangleSelector fig = plt.figure() ax = fig.add_subplot() selector = RectangleSelector(ax, lambda *args: None, interactive=True) selector.extents = (0.4, 0.7, 0.3, 0.4) selector.add_state('rotate') plt.show() This implementation preserves shapes in display coordinates as discussed in #21945 (comment) Renamed a property _geometry_state in response to #21945 (comment) Last (new) commit to fix MatplotlibDeprecationWarning: Setting data with a non sequence... raised by calling self._center_handle.set_data(*self.center) on a single coordinate array. The workaround does not feel very pretty; might discuss whether self.center should instead return a tuple (np.array[xc], np.array[yc]) in matplotlib/lib/matplotlib/widgets.py Line 3696 in 2c9919c but this would in turn break tests like assert_allclose(tool.center, (50, 65)). Closes #21937 PR checklist "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested Plotting related features are demonstrated in an example New Features and API Changes are noted with a directive and release note Documentation complies with general and docstring guidelines

Open Graph Description: PR summary This PR rebases the changes from #21945 onto (post-3.8.0) main. Since the merge conflicts after almost 2 years became prohibitive, I have applied the original modifications to a fresh PR...

X Description: PR summary This PR rebases the changes from #21945 onto (post-3.8.0) main. Since the merge conflicts after almost 2 years became prohibitive, I have applied the original modifications to a fresh PR...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/26833

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:02ed14a3-e306-52fc-02a7-4d4e9a568046
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CAC:166AAB:6084C9:817B8C:6A52FCD8
html-safe-nonceaf6ffce2411c3949e67a0939500fcd0ff75aee09306104169d99d85495ffeba8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0FDOjE2NkFBQjo2MDg0Qzk6ODE3QjhDOjZBNTJGQ0Q4IiwidmlzaXRvcl9pZCI6Ijg4NTQ2NTcwNTQ4NTEzOTg4NzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac950a6637eb5fb4521eb95fd4a6ba97f00c56872673d078b101aebd64e292b394
hovercard-subject-tagpull_request:1522082497
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/26833/files
twitter:imagehttps://avatars.githubusercontent.com/u/709020?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/709020?s=400&v=4
og:image:altPR summary This PR rebases the changes from #21945 onto (post-3.8.0) main. Since the merge conflicts after almost 2 years became prohibitive, I have applied the original modifications to a fresh PR...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/26833/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F26833%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F26833%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/26833/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/26833/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/26833/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/26833/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/26833/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
dhomeierhttps://github.com/dhomeier
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
dhomeier:selector-rotationhttps://github.com/dhomeier/matplotlib/tree/selector-rotation
Conversation 26 https://github.com/matplotlib/matplotlib/pull/26833
Commits 9 https://github.com/matplotlib/matplotlib/pull/26833/commits
Checks 3 https://github.com/matplotlib/matplotlib/pull/26833/checks
Files changed 3 https://github.com/matplotlib/matplotlib/pull/26833/files
Improve RectangleSelector Rotation revisited and rebased https://github.com/matplotlib/matplotlib/pull/26833/files#top
Show all changes 9 commits https://github.com/matplotlib/matplotlib/pull/26833/files
8063e15 Add edge midpoint helper methods dhomeier Sep 19, 2023 https://github.com/matplotlib/matplotlib/pull/26833/commits/8063e15085d171381cbae53462eb971bebf42cd2
728a749 Use assert_allclose in RectangleSelector tests dhomeier Sep 19, 2023 https://github.com/matplotlib/matplotlib/pull/26833/commits/728a7493b1b721a1ce6a574e3a0e6973b350745e
23e3bc0 Use display coordinates for RectangleSelector, update handles on resize dhomeier Sep 19, 2023 https://github.com/matplotlib/matplotlib/pull/26833/commits/23e3bc0a192e62d05b52f8461cbf0d402f3be2a0
78d0f02 Rectangle resize tests with multiple start/end corners dhomeier Sep 20, 2023 https://github.com/matplotlib/matplotlib/pull/26833/commits/78d0f0231871c88270a975363902d246ff60d77d
5ba3b5f Fix deprecation warnings from `self.visible` and `set_data(x, y)` dhomeier Sep 20, 2023 https://github.com/matplotlib/matplotlib/pull/26833/commits/5ba3b5fe8bb048d104932fdbdba497aba4ff963a
b7f12ab Fix case where axis limits are reversed astrofrog Jul 19, 2024 https://github.com/matplotlib/matplotlib/pull/26833/commits/b7f12abd350d24aa1328f4aebcc5bf13c7a10be6
c3b7e4b Corrections to comments dhomeier Dec 11, 2024 https://github.com/matplotlib/matplotlib/pull/26833/commits/c3b7e4bc307565849bffcde89840a398a09fbd91
fc74f95 Fix ellipse patch bbox edges and add selector tests dhomeier Dec 11, 2024 https://github.com/matplotlib/matplotlib/pull/26833/commits/fc74f9521ff01baf0a33f2990a5d8cd2b2650912
27c1c11 Let @rotation.setter rotate around center, too; update selector tests dhomeier Dec 30, 2024 https://github.com/matplotlib/matplotlib/pull/26833/commits/27c1c11f2e9743295ac469f461e7d88420ed9f99
Clear filters https://github.com/matplotlib/matplotlib/pull/26833/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/26833/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/26833/files
patches.py https://github.com/matplotlib/matplotlib/pull/26833/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
test_widgets.py https://github.com/matplotlib/matplotlib/pull/26833/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
widgets.py https://github.com/matplotlib/matplotlib/pull/26833/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
lib/matplotlib/patches.pyhttps://github.com/matplotlib/matplotlib/pull/26833/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
View file https://github.com/matplotlib/matplotlib/blob/27c1c11f2e9743295ac469f461e7d88420ed9f99/lib/matplotlib/patches.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/26833/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/26833/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
https://github.com/matplotlib/matplotlib/pull/26833/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
https://github.com/matplotlib/matplotlib/pull/26833/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
https://github.com/matplotlib/matplotlib/pull/26833/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
https://github.com/matplotlib/matplotlib/pull/26833/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
https://github.com/matplotlib/matplotlib/pull/26833/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
https://github.com/matplotlib/matplotlib/pull/26833/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
https://github.com/matplotlib/matplotlib/pull/26833/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
https://github.com/matplotlib/matplotlib/pull/26833/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
https://github.com/matplotlib/matplotlib/pull/26833/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
https://github.com/matplotlib/matplotlib/pull/26833/files#diff-03b74bfefbb7d4eca2804f274825899d191f8bacdbe99ea973d88925f15d1169
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/26833/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.