Title: Fixes for pycodestyle v2.11 by rcomer · Pull Request #26414 · matplotlib/matplotlib · GitHub
Open Graph Title: Fixes for pycodestyle v2.11 by rcomer · Pull Request #26414 · matplotlib/matplotlib
X Title: Fixes for pycodestyle v2.11 by rcomer · Pull Request #26414 · matplotlib/matplotlib
Description: PR summary flake8 is currently failing in CI with E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` I think this is the relevant change: PyCQA/pycodestyle#1086 In the bubble example, it looks like the type check was there just to make sure we get an array-like out of the method. We can achieve that with the keepdims keyword. Everywhere else I just replaced == with is as that preserves existing behaviour so seems safest. Possibly some places could have used isinstance instead but I do not know if there is an advantage to changing it to that (and I also do not know those parts of the code well enough to make that call). PR checklist "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested Plotting related features are demonstrated in an example New Features and API Changes are noted with a directive and release note Documentation complies with general and docstring guidelines
Open Graph Description: PR summary flake8 is currently failing in CI with E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` I think this is the relevant change: PyCQA...
X Description: PR summary flake8 is currently failing in CI with E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` I think this is the relevant change: PyCQA...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/26414
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e460bb45-4527-cd33-7240-ad9091b8e691 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A8AE:299504:382ADC:4A2073:6A52EDF9 |
| html-safe-nonce | 8631c00a57a30bf672f76b17d7001f07c017bfb9aed316f46abcd37285a1836b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEFFOjI5OTUwNDozODJBREM6NEEyMDczOjZBNTJFREY5IiwidmlzaXRvcl9pZCI6Ijg0MDAwNjExMDc2MDQyMjE0MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c405f92570339d7cafdfa2699f324a48d45c2ba3085e812a95a6bb4a9da83843 |
| hovercard-subject-tag | pull_request:1455093726 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/26414/files |
| twitter:image | https://avatars.githubusercontent.com/u/10599679?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10599679?s=400&v=4 |
| og:image:alt | PR summary flake8 is currently failing in CI with E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` I think this is the relevant change: PyCQA... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width