René's URL Explorer Experiment

Title: Limit Forward references in Mathtext parser by ksunden · Pull Request #26198 · matplotlib/matplotlib · GitHub

Open Graph Title: Limit Forward references in Mathtext parser by ksunden · Pull Request #26198 · matplotlib/matplotlib

X Title: Limit Forward references in Mathtext parser by ksunden · Pull Request #26198 · matplotlib/matplotlib

Description: PR summary Comment indicates that limiting forward references is important for performance, but many more were used than needed. This is a 75% reduction in forward reference instances. Many of these are included in the definition of remaining forward references but do not themselves need to be a forward reference (indeed only 1 thing in a given cycle actually needs to be such that it can be referred to prior to its definition) auto_delim is recursively self-referential, and thus must be all on its own placeable and accent form a tight loop, so one of those two needed to be a forward reference, and placeable was the easiest to keep (and most likely to be used in another definition that may introduce similar constraints) token is one of the more generic definitions, that is used in multiple other definitions. required_group and optional_group both caused failed tests when I tried to make them no longer forward references, has something to do with how __call__ works for Forward vs And objects in pyparsing (though did not dig too much deeper into it, beyond noticing that the names in future required_group("name") calls still had error messages that say "group", not their newer names, and that reverting to Forward instances fixed it). operatorname needed to move to avoid using forward references for simple, but does not actually have a cycle. Otherwise rewrapped some of the definitions to be one line and fixed a typing error that I noticed when looking into the parsing things. PR checklist [N/A] "closes #0000" is in the body of the PR description to link the related issue [N/A] new and changed code is tested [N/A] Plotting related features are demonstrated in an example [N/A] New Features and API Changes are noted with a directive and release note [N/A] Documentation complies with general and docstring guidelines @devRD I would appreciate your review on this. If this reorg would cause conflicts for other PRs already in flight, it can absolutely wait. I just saw the comment saying to minimize usage of Forward and then was immediately like "why is this a Forward" and kept going. The changes themselves are relatively minimal and would be easy to redo if needed: delete line that instantiates the Forward delete the << from <<= in the redefinition a few reorderings to maintain directionality without Forword references keep anything that is referred to before it is defined (and cannot be reordered) as a Forward (plus the optional/required_group)

Open Graph Description: PR summary Comment indicates that limiting forward references is important for performance, but many more were used than needed. This is a 75% reduction in forward reference instances. Many of thes...

X Description: PR summary Comment indicates that limiting forward references is important for performance, but many more were used than needed. This is a 75% reduction in forward reference instances. Many of thes...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/26198

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width