René's URL Explorer Experiment


Title: Tst/restore old tests by tacaswell · Pull Request #26131 · matplotlib/matplotlib · GitHub

Open Graph Title: Tst/restore old tests by tacaswell · Pull Request #26131 · matplotlib/matplotlib

X Title: Tst/restore old tests by tacaswell · Pull Request #26131 · matplotlib/matplotlib

Description: PR summary In 7b71257 via #4843 I intended to revert the changes from #4019 however, I incorrectly resolved the merge conflicts and also removed the tests added in #4023 and #4342. This is attempting to put them back. There are two complications: we have made changes to the text baseline calculations so the test images need to be regenerated The test marked as xfail is an Annotation defaulting to data coordinates when added directly to a Figure that does not have an Axes. I'm not clear why this ever worked (we must have had more complicated default coordinate behavior?!). I found this issue while looking at what images were in our repo that were not generated by running the test suite.

Open Graph Description: PR summary In 7b71257 via #4843 I intended to revert the changes from #4019 however, I incorrectly resolved the merge conflicts and also removed the tests added in #4023 and #4342. This is attempti...

X Description: PR summary In 7b71257 via #4843 I intended to revert the changes from #4019 however, I incorrectly resolved the merge conflicts and also removed the tests added in #4023 and #4342. This is attempti...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/26131

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d5b55491-cc00-33d1-86a1-77a5807e18bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id840E:69FA9:43ABFF:5BD7EF:6A553F22
html-safe-nonce5e4ccb6bb691776973d21a957ea83716517cbeb747b4a188aea691ff87a393c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDBFOjY5RkE5OjQzQUJGRjo1QkQ3RUY6NkE1NTNGMjIiLCJ2aXNpdG9yX2lkIjoiNzc0NDQ2MTQ5ODM1ODI1MTI5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9deabac306106099c5afb579387ca3ad497a49aaa2734280b621a59a797c6299
hovercard-subject-tagpull_request:1394486829
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/26131/files
twitter:imagehttps://avatars.githubusercontent.com/u/199813?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/199813?s=400&v=4
og:image:altPR summary In 7b71257 via #4843 I intended to revert the changes from #4019 however, I incorrectly resolved the merge conflicts and also removed the tests added in #4023 and #4342. This is attempti...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefbd8fce4d63ac394c5405faa20aa50d5c9e56b979ac43ee1b26f8e7c47c4cd89
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release811f50b757204c6a1b4da0ea780075b3e1cc9e57
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/26131/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F26131%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F26131%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/26131/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/26131/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/26131/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/26131/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/26131/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
ksundenhttps://github.com/ksunden
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
tacaswell:tst/restore_old_testshttps://github.com/tacaswell/matplotlib/tree/tst/restore_old_tests
Conversation 2 https://github.com/matplotlib/matplotlib/pull/26131
Commits 3 https://github.com/matplotlib/matplotlib/pull/26131/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/26131/checks
Files changed https://github.com/matplotlib/matplotlib/pull/26131/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/26131/files
Tst/restore old tests https://github.com/matplotlib/matplotlib/pull/26131/files#top
Show all changes 3 commits https://github.com/matplotlib/matplotlib/pull/26131/files
0e6e92e Revert "Revert " Merge pull request #4019 from myshen/annot_neg_coords"" tacaswell Jun 15, 2023 https://github.com/matplotlib/matplotlib/pull/26131/commits/0e6e92e12ec4376e69e710c2fe0d07aa9ceff85f
dff07ed TST: fix up axes-less Annotation tacaswell Jun 15, 2023 https://github.com/matplotlib/matplotlib/pull/26131/commits/dff07ed84d422d8c974c70135ea38c88e2f2b1c3
d96d68c TST: update test images for text baseline changes tacaswell Jun 15, 2023 https://github.com/matplotlib/matplotlib/pull/26131/commits/d96d68ced798d9af527a111331e60503f2367343
Clear filters https://github.com/matplotlib/matplotlib/pull/26131/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/26131/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/26131/files
basictext_wrap.png https://github.com/matplotlib/matplotlib/pull/26131/files#diff-d0e415a65ec1c502f83945520aff070f0d22bc16f6b1f7833e8780415d81d033
fonttext_wrap.png https://github.com/matplotlib/matplotlib/pull/26131/files#diff-2636f955f3f05a5b02b2358e703ae9dc80d3e240ef71a55b8ae9d0cc2230ac8d
test_text.py https://github.com/matplotlib/matplotlib/pull/26131/files#diff-48a87c3198fe994a8e31c16272b931d7dc307a88deba61086ca483ff44bacaa4
lib/matplotlib/tests/baseline_images/test_text/basictext_wrap.pnghttps://github.com/matplotlib/matplotlib/pull/26131/files#diff-d0e415a65ec1c502f83945520aff070f0d22bc16f6b1f7833e8780415d81d033
View file https://github.com/tacaswell/matplotlib/blob/d96d68ced798d9af527a111331e60503f2367343/lib/matplotlib/tests/baseline_images/test_text/basictext_wrap.png
Open in desktop https://desktop.github.com
Reload?https://github.com/matplotlib/matplotlib/pull/26131/files
lib/matplotlib/tests/baseline_images/test_text/fonttext_wrap.pnghttps://github.com/matplotlib/matplotlib/pull/26131/files#diff-2636f955f3f05a5b02b2358e703ae9dc80d3e240ef71a55b8ae9d0cc2230ac8d
View file https://github.com/tacaswell/matplotlib/blob/d96d68ced798d9af527a111331e60503f2367343/lib/matplotlib/tests/baseline_images/test_text/fonttext_wrap.png
Open in desktop https://desktop.github.com
Reload?https://github.com/matplotlib/matplotlib/pull/26131/files
lib/matplotlib/tests/test_text.pyhttps://github.com/matplotlib/matplotlib/pull/26131/files#diff-48a87c3198fe994a8e31c16272b931d7dc307a88deba61086ca483ff44bacaa4
View file https://github.com/tacaswell/matplotlib/blob/d96d68ced798d9af527a111331e60503f2367343/lib/matplotlib/tests/test_text.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/26131/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/26131/files#diff-48a87c3198fe994a8e31c16272b931d7dc307a88deba61086ca483ff44bacaa4
https://github.com/matplotlib/matplotlib/pull/26131/files#diff-48a87c3198fe994a8e31c16272b931d7dc307a88deba61086ca483ff44bacaa4
https://github.com/matplotlib/matplotlib/pull/26131/files#diff-48a87c3198fe994a8e31c16272b931d7dc307a88deba61086ca483ff44bacaa4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.