René's URL Explorer Experiment


Title: Getters setters by dutta712 · Pull Request #25901 · matplotlib/matplotlib · GitHub

Open Graph Title: Getters setters by dutta712 · Pull Request #25901 · matplotlib/matplotlib

X Title: Getters setters by dutta712 · Pull Request #25901 · matplotlib/matplotlib

Description: PR summary Hello, this is my first open source contribution to a project. This pull request addresses the concerns raised in #24617 which was cherry-picked from @garveyz2's PR which was then tagged as orphaned. Please guide me through any mistake which I've made, any missing files I needed to commit etc. I'm trying to learn contributing to open source and even though I've basically copied the entire solution, I feel like I've learnt a lot in that process.

Open Graph Description: PR summary Hello, this is my first open source contribution to a project. This pull request addresses the concerns raised in #24617 which was cherry-picked from @garveyz2's PR which was then ta...

X Description: PR summary Hello, this is my first open source contribution to a project. This pull request addresses the concerns raised in #24617 which was cherry-picked from @garveyz2's PR which was the...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/25901

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:df93e408-8f7f-1344-14d5-d10f32924920
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC238:2D29C2:798293:A87145:6A538B78
html-safe-nonce0102972c46963550878294e9bda5bf8fa1fedbfc6969b564df036f2d99432ae6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjM4OjJEMjlDMjo3OTgyOTM6QTg3MTQ1OjZBNTM4Qjc4IiwidmlzaXRvcl9pZCI6IjcwMjc0MjY3NzU2OTQyODE1OTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6948630bbf3010866feba9968b44acddc35ae981fa7539a70f9ab3f08f4a14f8
hovercard-subject-tagpull_request:1353732036
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/25901/files
twitter:imagehttps://avatars.githubusercontent.com/u/67039065?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/67039065?s=400&v=4
og:image:altPR summary Hello, this is my first open source contribution to a project. This pull request addresses the concerns raised in #24617 which was cherry-picked from @garveyz2's PR which was then ta...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/25901/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25901%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25901%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/25901/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/25901/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/25901/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25901/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25901/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
dutta712https://github.com/dutta712
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
dutta712:getters-settershttps://github.com/dutta712/matplotlib/tree/getters-setters
Conversation 21 https://github.com/matplotlib/matplotlib/pull/25901
Commits 8 https://github.com/matplotlib/matplotlib/pull/25901/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/25901/checks
Files changed 3 https://github.com/matplotlib/matplotlib/pull/25901/files
Getters setters https://github.com/matplotlib/matplotlib/pull/25901/files#top
Show all changes 8 commits https://github.com/matplotlib/matplotlib/pull/25901/files
5918332 added getters and setters subplotparams for figure garveyz2 Dec 11, 2022 https://github.com/matplotlib/matplotlib/pull/25901/commits/5918332ec9f79bd3dcb4dcc138cb84ef6856889b
6b995ea Added setter/getters for Figure for issue #24617 dutta712 May 17, 2023 https://github.com/matplotlib/matplotlib/pull/25901/commits/6b995ea938528034f2b3b41a10003290d10cb936
965305b initial fixes dutta712 May 26, 2023 https://github.com/matplotlib/matplotlib/pull/25901/commits/965305b601405995cd9c43644921083fe5f5b9e7
1c84734 Merge branch 'matplotlib:main' into getters-setters dutta712 May 26, 2023 https://github.com/matplotlib/matplotlib/pull/25901/commits/1c847348fbc918e41662f1fe3b41c1ce63d2f3a1
dcabceb Merge branch 'matplotlib:main' into getters-setters dutta712 May 26, 2023 https://github.com/matplotlib/matplotlib/pull/25901/commits/dcabceb9ad62d29ad52e426e854c0080fbab856e
67f3846 Fixed typo and removed whitespaces from blank lines dutta712 May 26, 2023 https://github.com/matplotlib/matplotlib/pull/25901/commits/67f3846b2d986676dd61c004d6bb256960e60436
49e2013 Added tests dutta712 May 27, 2023 https://github.com/matplotlib/matplotlib/pull/25901/commits/49e2013c4a7c493aa7729ca811dc583f94d111f7
4e43c51 added stubs for getters/setters subplotparams dutta712 Jun 2, 2023 https://github.com/matplotlib/matplotlib/pull/25901/commits/4e43c51ecaf4de9ae83aa3ef2c2325d8ea134ac4
Clear filters https://github.com/matplotlib/matplotlib/pull/25901/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25901/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25901/files
figure.py https://github.com/matplotlib/matplotlib/pull/25901/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
figure.pyi https://github.com/matplotlib/matplotlib/pull/25901/files#diff-b3caa5521fc735e54a17e5195018ff8cd78b70e3c0e4be2b020b082cd710023a
test_figure.py https://github.com/matplotlib/matplotlib/pull/25901/files#diff-7c50aec0865ef6fceff6a5cb00d4b7e57d396ecbcd3546e5fb494aabed99af33
lib/matplotlib/figure.pyhttps://github.com/matplotlib/matplotlib/pull/25901/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
View file https://github.com/matplotlib/matplotlib/blob/4e43c51ecaf4de9ae83aa3ef2c2325d8ea134ac4/lib/matplotlib/figure.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/25901/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/25901/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25901/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25901/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25901/files
melissawmhttps://github.com/melissawm
Jun 2, 2023https://github.com/matplotlib/matplotlib/pull/25901/files#r1214411333
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25901/files
https://github.com/matplotlib/matplotlib/pull/25901/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
https://github.com/matplotlib/matplotlib/pull/25901/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
https://github.com/matplotlib/matplotlib/pull/25901/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
lib/matplotlib/figure.pyihttps://github.com/matplotlib/matplotlib/pull/25901/files#diff-b3caa5521fc735e54a17e5195018ff8cd78b70e3c0e4be2b020b082cd710023a
View file https://github.com/matplotlib/matplotlib/blob/4e43c51ecaf4de9ae83aa3ef2c2325d8ea134ac4/lib/matplotlib/figure.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/25901/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/25901/files#diff-b3caa5521fc735e54a17e5195018ff8cd78b70e3c0e4be2b020b082cd710023a
https://github.com/matplotlib/matplotlib/pull/25901/files#diff-b3caa5521fc735e54a17e5195018ff8cd78b70e3c0e4be2b020b082cd710023a
lib/matplotlib/tests/test_figure.pyhttps://github.com/matplotlib/matplotlib/pull/25901/files#diff-7c50aec0865ef6fceff6a5cb00d4b7e57d396ecbcd3546e5fb494aabed99af33
View file https://github.com/matplotlib/matplotlib/blob/4e43c51ecaf4de9ae83aa3ef2c2325d8ea134ac4/lib/matplotlib/tests/test_figure.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/25901/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/25901/files#diff-7c50aec0865ef6fceff6a5cb00d4b7e57d396ecbcd3546e5fb494aabed99af33
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.