Title: Fix MarkerStyle types by QuLogic · Pull Request #25825 · matplotlib/matplotlib · GitHub
Open Graph Title: Fix MarkerStyle types by QuLogic · Pull Request #25825 · matplotlib/matplotlib
X Title: Fix MarkerStyle types by QuLogic · Pull Request #25825 · matplotlib/matplotlib
Description: PR summary When the {Cap,Join}Style Enum classes were added in #18544, they were supposed to be for documentation only. To that end, #22055 was a followup that ensured that only the strings were exposed from the getter side. However, when user-supplied cap/join style were added in #20914, they were only for the Enum type instead of the string, so correctly allow strings here as well. Also, specifically type hint the return values as literals, as was done in #25719. It is not possible for get_marker to return another MarkerStyle; the __init__ only takes one to make a full copy of it. And get_alt_path is only available for e.g., half-filled markers, but not all. PR checklist [n/a] "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested [n/a] Plotting related features are demonstrated in an example [n/a] New Features and API Changes are noted with a directive and release note [n/a] Documentation complies with general and docstring guidelines
Open Graph Description: PR summary When the {Cap,Join}Style Enum classes were added in #18544, they were supposed to be for documentation only. To that end, #22055 was a followup that ensured that only the strings were ex...
X Description: PR summary When the {Cap,Join}Style Enum classes were added in #18544, they were supposed to be for documentation only. To that end, #22055 was a followup that ensured that only the strings were ex...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/25825
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:56acf00d-97f7-446a-e4f5-86a487d2eed6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8878:139708:23D2333:316D91E:6A504467 |
| html-safe-nonce | 8ec3b0c0072ca04b770713fd5a317eebbaa482a1095de1831dff40ea3b81da15 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODc4OjEzOTcwODoyM0QyMzMzOjMxNkQ5MUU6NkE1MDQ0NjciLCJ2aXNpdG9yX2lkIjoiODk4MTE4NzM3MTIxMTk2NTU0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3e5bfecb233d4727c4b07ff78346dfab858a614650b4f73420694464ea5ea159 |
| hovercard-subject-tag | pull_request:1340616644 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/25825/files |
| twitter:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| og:image:alt | PR summary When the {Cap,Join}Style Enum classes were added in #18544, they were supposed to be for documentation only. To that end, #22055 was a followup that ensured that only the strings were ex... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d90666eaf032b7eb8975a378efe38e37f4ebb96c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width