René's URL Explorer Experiment


Title: Fix default return of Collection.get_{cap,join}style by QuLogic · Pull Request #25810 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix default return of Collection.get_{cap,join}style by QuLogic · Pull Request #25810 · matplotlib/matplotlib

X Title: Fix default return of Collection.get_{cap,join}style by QuLogic · Pull Request #25810 · matplotlib/matplotlib

Description: PR summary If neither are specified at object creation, the default is to be None. This broke get_{cap,join}style when the enum wrappers were created as they assume the internal value is always an enum value. $ python -c 'from matplotlib.collections import Collection; print(Collection().get_capstyle())' Traceback (most recent call last): File "", line 1, in File ".../lib/matplotlib/collections.py", line 643, in get_capstyle return self._capstyle.name AttributeError: 'NoneType' object has no attribute 'name' $ python -c 'from matplotlib.collections import Collection; print(Collection().get_joinstyle())' Traceback (most recent call last): File "", line 1, in File ".../lib/matplotlib/collections.py", line 657, in get_joinstyle return self._joinstyle.name AttributeError: 'NoneType' object has no attribute 'name' This was broken since the initial addition of the enums in #18544, so I'm not sure if it should be backported (minus the typing changes.) PR checklist [n/a] "closes #0000" is in the body of the PR description to link the related issue new and changed code is tested [n/a] Plotting related features are demonstrated in an example [n/a] New Features and API Changes are noted with a directive and release note [n/a] Documentation complies with general and docstring guidelines

Open Graph Description: PR summary If neither are specified at object creation, the default is to be None. This broke get_{cap,join}style when the enum wrappers were created as they assume the internal value is always an ...

X Description: PR summary If neither are specified at object creation, the default is to be None. This broke get_{cap,join}style when the enum wrappers were created as they assume the internal value is always an ...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/25810

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5414594f-7794-daef-5d45-2f0c89532f04
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCB7E:2AD6D5:A371CA:E2403C:6A5087F9
html-safe-nonce569e9203ec65ffa026a68f765fc7bbf29d1b27c098ef7725d2606ecf0581eb09
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjdFOjJBRDZENTpBMzcxQ0E6RTI0MDNDOjZBNTA4N0Y5IiwidmlzaXRvcl9pZCI6IjE1MTk5MjI5NzMxOTMzNTkyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0308871479a943ea20d32c70f4bb12eadfce73653478bbade01974c2752cce77
hovercard-subject-tagpull_request:1337538774
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/25810/files
twitter:imagehttps://avatars.githubusercontent.com/u/302469?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302469?s=400&v=4
og:image:altPR summary If neither are specified at object creation, the default is to be None. This broke get_{cap,join}style when the enum wrappers were created as they assume the internal value is always an ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/25810/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25810%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25810%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/25810/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/25810/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/25810/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25810/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25810/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 411 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
greglucashttps://github.com/greglucas
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
QuLogic:fix-default-collection-stylehttps://github.com/QuLogic/matplotlib/tree/fix-default-collection-style
Conversation 3 https://github.com/matplotlib/matplotlib/pull/25810
Commits 1 https://github.com/matplotlib/matplotlib/pull/25810/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/25810/checks
Files changed https://github.com/matplotlib/matplotlib/pull/25810/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25810/files
Fix default return of Collection.get_{cap,join}style https://github.com/matplotlib/matplotlib/pull/25810/files#top
Show all changes 1 commit https://github.com/matplotlib/matplotlib/pull/25810/files
4b99bc6 Fix default return of Collection.get_{cap,join}style QuLogic May 3, 2023 https://github.com/matplotlib/matplotlib/pull/25810/commits/4b99bc6c72add8b5535feec7154d6a5c160e1976
Clear filters https://github.com/matplotlib/matplotlib/pull/25810/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25810/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25810/files
collections.py https://github.com/matplotlib/matplotlib/pull/25810/files#diff-0563f83260b79acbd260c8f0207b01ba8182df37bf2ccd9216d9a3c6a70cbf29
collections.pyi https://github.com/matplotlib/matplotlib/pull/25810/files#diff-86daca72ccdaae5cb415c5e9f38f3462781263b431aad8dd173cc8942599eb53
test_collections.py https://github.com/matplotlib/matplotlib/pull/25810/files#diff-6862748ea80410b218b68ce4a5af65b38140420e1e408e76be5de3d241d34be6
lib/matplotlib/collections.pyhttps://github.com/matplotlib/matplotlib/pull/25810/files#diff-0563f83260b79acbd260c8f0207b01ba8182df37bf2ccd9216d9a3c6a70cbf29
View file https://github.com/QuLogic/matplotlib/blob/4b99bc6c72add8b5535feec7154d6a5c160e1976/lib/matplotlib/collections.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/25810/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/25810/files#diff-0563f83260b79acbd260c8f0207b01ba8182df37bf2ccd9216d9a3c6a70cbf29
https://github.com/matplotlib/matplotlib/pull/25810/files#diff-0563f83260b79acbd260c8f0207b01ba8182df37bf2ccd9216d9a3c6a70cbf29
https://github.com/matplotlib/matplotlib/pull/25810/files#diff-0563f83260b79acbd260c8f0207b01ba8182df37bf2ccd9216d9a3c6a70cbf29
lib/matplotlib/collections.pyihttps://github.com/matplotlib/matplotlib/pull/25810/files#diff-86daca72ccdaae5cb415c5e9f38f3462781263b431aad8dd173cc8942599eb53
View file https://github.com/QuLogic/matplotlib/blob/4b99bc6c72add8b5535feec7154d6a5c160e1976/lib/matplotlib/collections.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/25810/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/25810/files#diff-86daca72ccdaae5cb415c5e9f38f3462781263b431aad8dd173cc8942599eb53
https://github.com/matplotlib/matplotlib/pull/25810/files#diff-86daca72ccdaae5cb415c5e9f38f3462781263b431aad8dd173cc8942599eb53
lib/matplotlib/tests/test_collections.pyhttps://github.com/matplotlib/matplotlib/pull/25810/files#diff-6862748ea80410b218b68ce4a5af65b38140420e1e408e76be5de3d241d34be6
View file https://github.com/QuLogic/matplotlib/blob/4b99bc6c72add8b5535feec7154d6a5c160e1976/lib/matplotlib/tests/test_collections.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/25810/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/25810/files#diff-6862748ea80410b218b68ce4a5af65b38140420e1e408e76be5de3d241d34be6
https://github.com/matplotlib/matplotlib/pull/25810/files#diff-6862748ea80410b218b68ce4a5af65b38140420e1e408e76be5de3d241d34be6
https://github.com/matplotlib/matplotlib/pull/25810/files#diff-6862748ea80410b218b68ce4a5af65b38140420e1e408e76be5de3d241d34be6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.