| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:efa86758-6ea4-12da-4fa0-0bfa9b4cc76f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A148:24C5C6:B93B64:F6371B:6A518D1D |
| html-safe-nonce | 1e494fe20483d0d3bdc9e9c2171614e0bb097d64c8c7cc21df52df135cf0983a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTQ4OjI0QzVDNjpCOTNCNjQ6RjYzNzFCOjZBNTE4RDFEIiwidmlzaXRvcl9pZCI6IjM2NTEzNDY0MzgyMjU0OTczNzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | eb97a6661ca5ae8185907e207c520c2abaed794eebc6fc358d4a5a55cf9358f8 |
| hovercard-subject-tag | pull_request:1300702802 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/25607/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2936970c954543be682fd764a8f659e410d9804215263b6f3df1b0aac36b509b/matplotlib/matplotlib/pull/25607 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2936970c954543be682fd764a8f659e410d9804215263b6f3df1b0aac36b509b/matplotlib/matplotlib/pull/25607 |
| og:image:alt | PR Summary
Required changes for Figure.figure type hint
The core change here, which enables the plt.figure type hint is that
FigureBase.figure (and subclasses) is now type hinted as Figure instead ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ksunden |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/25607#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25607 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25607 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/25607 |
| Reload | https://github.com/matplotlib/matplotlib/pull/25607 |
| Reload | https://github.com/matplotlib/matplotlib/pull/25607 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25607 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25607 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
409
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| QuLogic | https://github.com/QuLogic |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| ksunden:figure_types | https://github.com/ksunden/matplotlib/tree/figure_types |
| Conversation | https://github.com/matplotlib/matplotlib/pull/25607 |
| Commits1 (1) | https://github.com/matplotlib/matplotlib/pull/25607/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/25607/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/25607/files |
| Missing return type hints for Figure | https://github.com/matplotlib/matplotlib/pull/25607#top |
| QuLogic | https://github.com/QuLogic |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| ksunden:figure_types | https://github.com/ksunden/matplotlib/tree/figure_types |
|
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
| Apr 3, 2023 | https://github.com/matplotlib/matplotlib/pull/25607#issue-1652785500 |
| Custom Figure subclasses | https://matplotlib.org/stable/gallery/subplots_axes_and_figures/custom_figure_class.html |
| #24976 (comment) | https://github.com/matplotlib/matplotlib/pull/24976#issuecomment-1483569458 |
| build | https://matplotlib.org/devel/documenting_mpl.html#building-the-docs |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25607 |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
| Apr 3, 2023 | https://github.com/matplotlib/matplotlib/pull/25607#event-8917488293 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Apr 3, 2023 | https://github.com/matplotlib/matplotlib/pull/25607#issuecomment-1495043031 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25607 |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
| Apr 3, 2023 | https://github.com/matplotlib/matplotlib/pull/25607#issuecomment-1495102339 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25607 |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/a009473b8d21cabac3214af9f7f8efb9a05c8600..d3c09181e896264961828ea0dc013b802446df8d |
| a009473 | https://github.com/matplotlib/matplotlib/commit/a009473b8d21cabac3214af9f7f8efb9a05c8600 |
| d3c0918 | https://github.com/matplotlib/matplotlib/commit/d3c09181e896264961828ea0dc013b802446df8d |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/a009473b8d21cabac3214af9f7f8efb9a05c8600..d3c09181e896264961828ea0dc013b802446df8d |
| April 3, 2023 23:08 | https://github.com/matplotlib/matplotlib/pull/25607#event-8918095395 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
topic: typing
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20typing%22 |
| Apr 12, 2023 | https://github.com/matplotlib/matplotlib/pull/25607#event-8980091814 |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
| v3.8.0 | https://github.com/matplotlib/matplotlib/milestone/77 |
| Apr 20, 2023 | https://github.com/matplotlib/matplotlib/pull/25607#event-9055158456 |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
| Apr 27, 2023 | https://github.com/matplotlib/matplotlib/pull/25607#issuecomment-1524251031 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25607 |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
| Apr 27, 2023 | https://github.com/matplotlib/matplotlib/pull/25607#event-9108864709 |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
| Apr 27, 2023 | https://github.com/matplotlib/matplotlib/pull/25607#event-9108864952 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Apr 27, 2023 | https://github.com/matplotlib/matplotlib/pull/25607#issuecomment-1526040587 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25607 |
|
| https://github.com/ksunden |
| Missing return types for Figure | https://github.com/matplotlib/matplotlib/pull/25607/commits/8edf04f929bfd061353158d4b997f54b4b618bbf |
| 8edf04f | https://github.com/matplotlib/matplotlib/pull/25607/commits/8edf04f929bfd061353158d4b997f54b4b618bbf |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/d3c09181e896264961828ea0dc013b802446df8d..8edf04f929bfd061353158d4b997f54b4b618bbf |
| d3c0918 | https://github.com/matplotlib/matplotlib/commit/d3c09181e896264961828ea0dc013b802446df8d |
| 8edf04f | https://github.com/matplotlib/matplotlib/commit/8edf04f929bfd061353158d4b997f54b4b618bbf |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/d3c09181e896264961828ea0dc013b802446df8d..8edf04f929bfd061353158d4b997f54b4b618bbf |
| April 27, 2023 17:38 | https://github.com/matplotlib/matplotlib/pull/25607#event-9117292037 |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
| Apr 27, 2023 | https://github.com/matplotlib/matplotlib/pull/25607#issuecomment-1526084862 |
| #25782 | https://github.com/matplotlib/matplotlib/pull/25782 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25607 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
|
Apr 27, 2023
| https://github.com/matplotlib/matplotlib/pull/25607#pullrequestreview-1404598735 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/25607/files/8edf04f929bfd061353158d4b997f54b4b618bbf |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Apr 28, 2023
| https://github.com/matplotlib/matplotlib/pull/25607#pullrequestreview-1405462054 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/25607/files/8edf04f929bfd061353158d4b997f54b4b618bbf |
| lib/matplotlib/figure.pyi | https://github.com/matplotlib/matplotlib/pull/25607/files/8edf04f929bfd061353158d4b997f54b4b618bbf#diff-b3caa5521fc735e54a17e5195018ff8cd78b70e3c0e4be2b020b082cd710023a |
| QuLogic | https://github.com/QuLogic |
| Apr 28, 2023 | https://github.com/matplotlib/matplotlib/pull/25607#discussion_r1180085425 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25607 |
| ksunden | https://github.com/ksunden |
| Apr 28, 2023 | https://github.com/matplotlib/matplotlib/pull/25607#discussion_r1180739455 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25607 |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
|
Apr 29, 2023
| https://github.com/matplotlib/matplotlib/pull/25607#ref-pullrequest-1688991774 |
|
[TYP/MNT] Remove unused imports from stub files
#25787
| https://github.com/matplotlib/matplotlib/pull/25787 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Apr 29, 2023
| https://github.com/matplotlib/matplotlib/pull/25607#pullrequestreview-1406743879 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/25607/files/8edf04f929bfd061353158d4b997f54b4b618bbf |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| 944155f | https://github.com/matplotlib/matplotlib/commit/944155f6354f85614fdfbf19a56a8b19ee1b0372 |
| Apr 29, 2023 | https://github.com/matplotlib/matplotlib/pull/25607#event-9129174048 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Apr 29, 2023
| https://github.com/matplotlib/matplotlib/pull/25607#ref-pullrequest-1689301894 |
|
ci: Increase retry count on PR conflict check
#25788
| https://github.com/matplotlib/matplotlib/pull/25788 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25607 |
|
| https://github.com/tacaswell |
|
tacaswell
| https://github.com/tacaswell |
|
| https://github.com/matplotlib/matplotlib/pull/25607/files/8edf04f929bfd061353158d4b997f54b4b618bbf |
|
| https://github.com/QuLogic |
|
QuLogic
| https://github.com/QuLogic |
|
| https://github.com/matplotlib/matplotlib/pull/25607/files/8edf04f929bfd061353158d4b997f54b4b618bbf |
|
topic: typing
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20typing%22 |
|
v3.8.0
| https://github.com/matplotlib/matplotlib/milestone/77 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25607 |
|
| https://github.com/ksunden |
|
| https://github.com/tacaswell |
|
| https://github.com/QuLogic |
|
| https://github.com/oscargus |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |