René's URL Explorer Experiment


Title: FIX: use locators in adjust_bbox by rcomer · Pull Request #25499 · matplotlib/matplotlib · GitHub

Open Graph Title: FIX: use locators in adjust_bbox by rcomer · Pull Request #25499 · matplotlib/matplotlib

X Title: FIX: use locators in adjust_bbox by rcomer · Pull Request #25499 · matplotlib/matplotlib

Description: PR Summary Fixes #22625. The problem was that _ColorbarAxesLocator was not used to set the aspect ratio before adjust_bbox stripped it off. A simpler but presumably less efficient fix might be to trigger a draw before calling adjust_bbox. We already do that if bbox_inches == "tight". matplotlib/lib/matplotlib/backend_bases.py Lines 2358 to 2361 in 78bf53c if layout_engine is not None or bbox_inches == "tight": # we need to trigger a draw before printing to make sure # CL works. "tight" also needs a draw to get the right # locations: PR Checklist Documentation and Tests Has pytest style unit tests (and pytest passes) [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error). [N/A] New plotting related features are documented with examples. Release Notes [N/A] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/ [N/A] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/ [N/A] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

Open Graph Description: PR Summary Fixes #22625. The problem was that _ColorbarAxesLocator was not used to set the aspect ratio before adjust_bbox stripped it off. A simpler but presumably less efficient fix might be to...

X Description: PR Summary Fixes #22625. The problem was that _ColorbarAxesLocator was not used to set the aspect ratio before adjust_bbox stripped it off. A simpler but presumably less efficient fix might be to...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/25499

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d22213d8-b922-a500-2994-00799ce8f521
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD7B2:118815:279E75D:3871ACC:6A510052
html-safe-nonceb87f2ccd69cb29db213b1cbb9df7adc81321a222d049215991474caf7e51e344
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0IyOjExODgxNToyNzlFNzVEOjM4NzFBQ0M6NkE1MTAwNTIiLCJ2aXNpdG9yX2lkIjoiNjA2MDg2OTI0NTAwMDAyNDE0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0d5eff970ad81771a35657d6a77de9df233aa525dfe21de830d3c8312c2c8543
hovercard-subject-tagpull_request:1281236615
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/25499/files
twitter:imagehttps://avatars.githubusercontent.com/u/10599679?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10599679?s=400&v=4
og:image:altPR Summary Fixes #22625. The problem was that _ColorbarAxesLocator was not used to set the aspect ratio before adjust_bbox stripped it off. A simpler but presumably less efficient fix might be to...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None38906a4da4e3e9fd88dfeacee232f5932c0c5f7495de3b4efc53ddfac7173d12
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release90441ea9b98e7491aa6ebcd135fccce4e2396f48
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/25499/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25499%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25499%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/25499/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/25499/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/25499/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25499/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25499/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 410 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
oscargushttps://github.com/oscargus
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
rcomer:colorbar-bbox_incheshttps://github.com/rcomer/matplotlib/tree/colorbar-bbox_inches
Conversation 7 https://github.com/matplotlib/matplotlib/pull/25499
Commits 1 https://github.com/matplotlib/matplotlib/pull/25499/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/25499/checks
Files changed https://github.com/matplotlib/matplotlib/pull/25499/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25499/files
FIX: use locators in adjust_bbox https://github.com/matplotlib/matplotlib/pull/25499/files#top
Show all changes 1 commit https://github.com/matplotlib/matplotlib/pull/25499/files
50aa98a FIX: use locators in adjust_bbox rcomer Mar 18, 2023 https://github.com/matplotlib/matplotlib/pull/25499/commits/50aa98a0f7c1fd1971322f7531294e6716963698
Clear filters https://github.com/matplotlib/matplotlib/pull/25499/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25499/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25499/files
_tight_bbox.py https://github.com/matplotlib/matplotlib/pull/25499/files#diff-dec11aaa3a10e77f6534e23e5c1779472c15c6a04fbd14a29bd3e1a5c382b09e
test_figure.py https://github.com/matplotlib/matplotlib/pull/25499/files#diff-7c50aec0865ef6fceff6a5cb00d4b7e57d396ecbcd3546e5fb494aabed99af33
lib/matplotlib/_tight_bbox.pyhttps://github.com/matplotlib/matplotlib/pull/25499/files#diff-dec11aaa3a10e77f6534e23e5c1779472c15c6a04fbd14a29bd3e1a5c382b09e
View file https://github.com/rcomer/matplotlib/blob/50aa98a0f7c1fd1971322f7531294e6716963698/lib/matplotlib/_tight_bbox.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/25499/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/25499/files#diff-dec11aaa3a10e77f6534e23e5c1779472c15c6a04fbd14a29bd3e1a5c382b09e
https://github.com/matplotlib/matplotlib/pull/25499/files#diff-dec11aaa3a10e77f6534e23e5c1779472c15c6a04fbd14a29bd3e1a5c382b09e
lib/matplotlib/tests/test_figure.pyhttps://github.com/matplotlib/matplotlib/pull/25499/files#diff-7c50aec0865ef6fceff6a5cb00d4b7e57d396ecbcd3546e5fb494aabed99af33
View file https://github.com/rcomer/matplotlib/blob/50aa98a0f7c1fd1971322f7531294e6716963698/lib/matplotlib/tests/test_figure.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/25499/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/25499/files#diff-7c50aec0865ef6fceff6a5cb00d4b7e57d396ecbcd3546e5fb494aabed99af33
greglucashttps://github.com/greglucas
Mar 19, 2023https://github.com/matplotlib/matplotlib/pull/25499/files#r1141239594
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25499/files
rcomerhttps://github.com/rcomer
Mar 19, 2023https://github.com/matplotlib/matplotlib/pull/25499/files#r1141455362
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25499/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25499/files
greglucashttps://github.com/greglucas
Mar 19, 2023https://github.com/matplotlib/matplotlib/pull/25499/files#r1141483447
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#22103https://github.com/matplotlib/matplotlib/pull/22103
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25499/files
https://github.com/matplotlib/matplotlib/pull/25499/files#diff-7c50aec0865ef6fceff6a5cb00d4b7e57d396ecbcd3546e5fb494aabed99af33
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.