Title: Fix incorrect stride calculations in LogLocator.tick_values() by II-Day-II · Pull Request #25405 · matplotlib/matplotlib · GitHub
Open Graph Title: Fix incorrect stride calculations in LogLocator.tick_values() by II-Day-II · Pull Request #25405 · matplotlib/matplotlib
X Title: Fix incorrect stride calculations in LogLocator.tick_values() by II-Day-II · Pull Request #25405 · matplotlib/matplotlib
Description: PR Summary Resolves #24092 A simplification of the stride calculation in this commit seems to have introduced some incorrect behavior, as the simplified version isn't mathematically equivalent to the old one. This caused the method to return an empty array when it shouldn't, which meant ticks would not appear on the grid axes. This PR reverts the stride calculation in the case where mpl.rcParams['_internal.classic_mode'] is False to one equivalent to the while-loop the simplification replaced, as well as adding tests for the scenario described in #24092. PR Checklist Documentation and Tests Has pytest style unit tests (and pytest passes) [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error). [N/A] New plotting related features are documented with examples. Release Notes [N/A] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/ [N/A] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/ [N/A] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst
Open Graph Description: PR Summary Resolves #24092 A simplification of the stride calculation in this commit seems to have introduced some incorrect behavior, as the simplified version isn't mathematically equivalent ...
X Description: PR Summary Resolves #24092 A simplification of the stride calculation in this commit seems to have introduced some incorrect behavior, as the simplified version isn't mathematically equival...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/25405
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1bb8195e-52fe-7328-5f03-2418e82541e7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8D4E:14105D:918C6:BFB21:6A52BDEC |
| html-safe-nonce | 919e9a3619f88de9b88803e7c8c791b1d51b6a863d678d356e8d67d96a447def |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDRFOjE0MTA1RDo5MThDNjpCRkIyMTo2QTUyQkRFQyIsInZpc2l0b3JfaWQiOiI1MTA2MTQ1MTU5ODI5NzQ0NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1f537602a5bf80c1a99225b656a04f0aa39b0013288f882c8893b1b355f4d81e |
| hovercard-subject-tag | pull_request:1266084300 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/25405/files |
| twitter:image | https://avatars.githubusercontent.com/u/74981560?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/74981560?s=400&v=4 |
| og:image:alt | PR Summary Resolves #24092 A simplification of the stride calculation in this commit seems to have introduced some incorrect behavior, as the simplified version isn't mathematically equivalent ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width