| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b1baed9d-03a1-d217-955b-78e7b9f69e47 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AB44:2FD3E:102BCC4:1588C49:6A5299C7 |
| html-safe-nonce | 721cea98bac90cfcbd2a509e0838c8bc8af6d02ca2cc890fea0bb68d4c73ca44 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjQ0OjJGRDNFOjEwMkJDQzQ6MTU4OEM0OTo2QTUyOTlDNyIsInZpc2l0b3JfaWQiOiIxMzkxODY2NzcyMDQzNTA0MDcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 937856d67e6667830a29d1dafd342308f0795a1a4002f5ccc47b39846beedd81 |
| hovercard-subject-tag | pull_request:1246124055 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/25253/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b984726e649acc4c58f4cdbe7113f3c8085a4c6ed0f67ed9b5b679c4d60364b6/matplotlib/matplotlib/pull/25253 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b984726e649acc4c58f4cdbe7113f3c8085a4c6ed0f67ed9b5b679c4d60364b6/matplotlib/matplotlib/pull/25253 |
| og:image:alt | PR Summary
Towards #23846
This PR migrates the ttconv module to using pybind11. Most of the conversion uses pybind11 data structures. Some notes for reviewers:
The Python C-API was required to con... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | thomasjpfan |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/25253#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25253 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25253 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/25253 |
| Reload | https://github.com/matplotlib/matplotlib/pull/25253 |
| Reload | https://github.com/matplotlib/matplotlib/pull/25253 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
408
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| oscargus | https://github.com/oscargus |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| thomasjpfan:ttconv_pybind11_pr | https://github.com/thomasjpfan/matplotlib/tree/ttconv_pybind11_pr |
| Conversation | https://github.com/matplotlib/matplotlib/pull/25253 |
| Commits2 (2) | https://github.com/matplotlib/matplotlib/pull/25253/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/25253/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/25253/files |
| Use pybind11 in ttconv module | https://github.com/matplotlib/matplotlib/pull/25253#top |
| oscargus | https://github.com/oscargus |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| thomasjpfan:ttconv_pybind11_pr | https://github.com/thomasjpfan/matplotlib/tree/ttconv_pybind11_pr |
|
| https://github.com/thomasjpfan |
| thomasjpfan | https://github.com/thomasjpfan |
| Feb 18, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#issue-1590462759 |
| #23846 | https://github.com/matplotlib/matplotlib/issues/23846 |
| pybind11 reference | https://pybind11.readthedocs.io/en/stable/advanced/cast/strings.html#explicit-conversions |
| pybind11::handle | https://pybind11.readthedocs.io/en/stable/reference.html#_CPPv46handle |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Feb 18, 2023
| https://github.com/matplotlib/matplotlib/pull/25253#pullrequestreview-1304665070 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/25253/files |
| github-actions | https://github.com/apps/github-actions |
| https://github.com/matplotlib/matplotlib/pull/25253#pullrequestreview-1304665070 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| on gitter | https://gitter.im/matplotlib/matplotlib |
| the developer guide | https://matplotlib.org/devdocs/devel/index.html |
| Code of Conduct | https://github.com/matplotlib/matplotlib/blob/main/CODE_OF_CONDUCT.md |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
|
Feb 20, 2023
| https://github.com/matplotlib/matplotlib/pull/25253#pullrequestreview-1305266169 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/25253/files |
| src/_ttconv.cpp | https://github.com/matplotlib/matplotlib/pull/25253/files#diff-b7a10c7895f1e804f2dbb36c0a7ed7eb4a3ef5c1be615f807af9c2af11cd515c |
| oscargus | https://github.com/oscargus |
| Feb 20, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#discussion_r1111602847 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @ianthomas23 | https://github.com/ianthomas23 |
| @anntzer | https://github.com/anntzer |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| anntzer | https://github.com/anntzer |
| Feb 20, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#discussion_r1111664168 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://pybind11.readthedocs.io/en/stable/advanced/exceptions.html#handling-exceptions-from-python-in-c | https://pybind11.readthedocs.io/en/stable/advanced/exceptions.html#handling-exceptions-from-python-in-c |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| thomasjpfan | https://github.com/thomasjpfan |
| Feb 20, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#discussion_r1112102136 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| matplotlib/src/_ttconv.cpp | https://github.com/matplotlib/matplotlib/blob/de8e9d01b0d5bb19c9916f1b49b7eb207899b09a/src/_ttconv.cpp#L139-L142 |
| de8e9d0 | https://github.com/matplotlib/matplotlib/commit/de8e9d01b0d5bb19c9916f1b49b7eb207899b09a |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| anntzer | https://github.com/anntzer |
| Feb 20, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#discussion_r1112117123 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| thomasjpfan | https://github.com/thomasjpfan |
| Feb 20, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#discussion_r1112128717 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
|
topic: text/fonts
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20text%2Ffonts%22 |
| Feb 20, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#event-8558681955 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Feb 20, 2023
| https://github.com/matplotlib/matplotlib/pull/25253#ref-issue-1591570316 |
|
[MNT]: Make _ttconv.convert_ttf_to_ps take a binary file as output argument, not a text file
#25265
| https://github.com/matplotlib/matplotlib/issues/25265 |
| https://github.com/thomasjpfan |
| thomasjpfan | https://github.com/thomasjpfan |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/a53da5174bd8cef31079be337b31fe4962799c73..f14a5664b489a982c670087f109efcd66c59733d |
| a53da51 | https://github.com/matplotlib/matplotlib/commit/a53da5174bd8cef31079be337b31fe4962799c73 |
| f14a566 | https://github.com/matplotlib/matplotlib/commit/f14a5664b489a982c670087f109efcd66c59733d |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/a53da5174bd8cef31079be337b31fe4962799c73..f14a5664b489a982c670087f109efcd66c59733d |
| February 20, 2023 15:57 | https://github.com/matplotlib/matplotlib/pull/25253#event-8563147394 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| anntzer | https://github.com/anntzer |
| February 20, 2023 22:21 | https://github.com/matplotlib/matplotlib/pull/25253#event-8565305076 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Feb 20, 2023
| https://github.com/matplotlib/matplotlib/pull/25253#pullrequestreview-1306395385 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/25253/files |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| stale review | https://github.com/matplotlib/matplotlib/pull/25253#pullrequestreview-1306395385 |
| February 20, 2023 22:31 | https://github.com/matplotlib/matplotlib/pull/25253#event-8565353319 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Feb 20, 2023
| https://github.com/matplotlib/matplotlib/pull/25253#pullrequestreview-1306398560 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/25253/files |
| src/_ttconv.cpp | https://github.com/matplotlib/matplotlib/pull/25253/files#diff-b7a10c7895f1e804f2dbb36c0a7ed7eb4a3ef5c1be615f807af9c2af11cd515c |
| anntzer | https://github.com/anntzer |
| Feb 20, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#discussion_r1112369969 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Feb 20, 2023
| https://github.com/matplotlib/matplotlib/pull/25253#pullrequestreview-1306400051 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/25253/files |
| src/_ttconv.cpp | https://github.com/matplotlib/matplotlib/pull/25253/files#diff-b7a10c7895f1e804f2dbb36c0a7ed7eb4a3ef5c1be615f807af9c2af11cd515c |
| anntzer | https://github.com/anntzer |
| Feb 20, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#discussion_r1112371110 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| thomasjpfan | https://github.com/thomasjpfan |
| Feb 21, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#discussion_r1113383311 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://pybind11.readthedocs.io/en/stable/advanced/functions.html#allow-prohibiting-none-arguments | https://pybind11.readthedocs.io/en/stable/advanced/functions.html#allow-prohibiting-none-arguments |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
|
status: needs revision
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20revision%22 |
| Feb 20, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#event-8565383713 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Feb 20, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#issuecomment-1437646529 |
| #20866 | https://github.com/matplotlib/matplotlib/pull/20866 |
| #20391 | https://github.com/matplotlib/matplotlib/pull/20391 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
| Feb 21, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#issuecomment-1437991781 |
| @thomasjpfan | https://github.com/thomasjpfan |
| #23846 | https://github.com/matplotlib/matplotlib/issues/23846 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| https://github.com/thomasjpfan |
| thomasjpfan | https://github.com/thomasjpfan |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/f14a5664b489a982c670087f109efcd66c59733d..b074140430103af385670efafad8d77be2b43456 |
| f14a566 | https://github.com/matplotlib/matplotlib/commit/f14a5664b489a982c670087f109efcd66c59733d |
| b074140 | https://github.com/matplotlib/matplotlib/commit/b074140430103af385670efafad8d77be2b43456 |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/f14a5664b489a982c670087f109efcd66c59733d..b074140430103af385670efafad8d77be2b43456 |
| February 21, 2023 17:35 | https://github.com/matplotlib/matplotlib/pull/25253#event-8573485258 |
| https://github.com/thomasjpfan |
| thomasjpfan | https://github.com/thomasjpfan |
| Feb 21, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#issuecomment-1438874308 |
| #20866 | https://github.com/matplotlib/matplotlib/pull/20866 |
| #23846 | https://github.com/matplotlib/matplotlib/issues/23846 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| https://github.com/thomasjpfan |
| thomasjpfan | https://github.com/thomasjpfan |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/b074140430103af385670efafad8d77be2b43456..8da08a7bd9f0c93dc8de8a83cf4f2fef3629b91f |
| b074140 | https://github.com/matplotlib/matplotlib/commit/b074140430103af385670efafad8d77be2b43456 |
| 8da08a7 | https://github.com/matplotlib/matplotlib/commit/8da08a7bd9f0c93dc8de8a83cf4f2fef3629b91f |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/b074140430103af385670efafad8d77be2b43456..8da08a7bd9f0c93dc8de8a83cf4f2fef3629b91f |
| February 23, 2023 03:21 | https://github.com/matplotlib/matplotlib/pull/25253#event-8587336518 |
| https://github.com/ianthomas23 |
| ianthomas23 | https://github.com/ianthomas23 |
|
Feb 23, 2023
| https://github.com/matplotlib/matplotlib/pull/25253#pullrequestreview-1310981846 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/25253/files |
| ianthomas23 | https://github.com/ianthomas23 |
| https://github.com/matplotlib/matplotlib/pull/25253#pullrequestreview-1310981846 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| src/_ttconv.cpp | https://github.com/matplotlib/matplotlib/pull/25253/files#diff-b7a10c7895f1e804f2dbb36c0a7ed7eb4a3ef5c1be615f807af9c2af11cd515c |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| src/_ttconv.cpp | https://github.com/matplotlib/matplotlib/pull/25253/files#diff-b7a10c7895f1e804f2dbb36c0a7ed7eb4a3ef5c1be615f807af9c2af11cd515c |
| ianthomas23 | https://github.com/ianthomas23 |
| Feb 23, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#discussion_r1115492952 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| src/_ttconv.cpp | https://github.com/matplotlib/matplotlib/pull/25253/files#diff-b7a10c7895f1e804f2dbb36c0a7ed7eb4a3ef5c1be615f807af9c2af11cd515c |
| ianthomas23 | https://github.com/ianthomas23 |
| Feb 23, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#discussion_r1115495418 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| https://github.com/thomasjpfan |
| thomasjpfan | https://github.com/thomasjpfan |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/8da08a7bd9f0c93dc8de8a83cf4f2fef3629b91f..dcb5e312590435804a38e123820fc2e77138daca |
| 8da08a7 | https://github.com/matplotlib/matplotlib/commit/8da08a7bd9f0c93dc8de8a83cf4f2fef3629b91f |
| dcb5e31 | https://github.com/matplotlib/matplotlib/commit/dcb5e312590435804a38e123820fc2e77138daca |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/8da08a7bd9f0c93dc8de8a83cf4f2fef3629b91f..dcb5e312590435804a38e123820fc2e77138daca |
| February 23, 2023 14:54 | https://github.com/matplotlib/matplotlib/pull/25253#event-8592641920 |
|
| https://github.com/thomasjpfan |
| Use pybind11 in ttconv module | https://github.com/matplotlib/matplotlib/pull/25253/commits/c38348bf1b6d101374736aa7d267b49b80b90806 |
| c38348b | https://github.com/matplotlib/matplotlib/pull/25253/commits/c38348bf1b6d101374736aa7d267b49b80b90806 |
| https://github.com/thomasjpfan |
| thomasjpfan | https://github.com/thomasjpfan |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/dcb5e312590435804a38e123820fc2e77138daca..c38348bf1b6d101374736aa7d267b49b80b90806 |
| dcb5e31 | https://github.com/matplotlib/matplotlib/commit/dcb5e312590435804a38e123820fc2e77138daca |
| c38348b | https://github.com/matplotlib/matplotlib/commit/c38348bf1b6d101374736aa7d267b49b80b90806 |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/dcb5e312590435804a38e123820fc2e77138daca..c38348bf1b6d101374736aa7d267b49b80b90806 |
| February 24, 2023 11:54 | https://github.com/matplotlib/matplotlib/pull/25253#event-8601121134 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
status: needs rebase
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20rebase%22 |
| Mar 25, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#event-8845385749 |
|
| https://github.com/oscargus |
| Merge branch 'main' into ttconv_pybind11_pr | https://github.com/matplotlib/matplotlib/pull/25253/commits/3205f852683deba26c8a38acac42f61a66aa1871 |
| 3205f85 | https://github.com/matplotlib/matplotlib/pull/25253/commits/3205f852683deba26c8a38acac42f61a66aa1871 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
status: needs rebase
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20rebase%22 |
| Mar 30, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#event-8888018368 |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
| Mar 30, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#issuecomment-1490362861 |
| @anntzer | https://github.com/anntzer |
| #20866 | https://github.com/matplotlib/matplotlib/pull/20866 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Mar 30, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#issuecomment-1490501648 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Mar 30, 2023
| https://github.com/matplotlib/matplotlib/pull/25253#pullrequestreview-1365390858 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/25253/files/3205f852683deba26c8a38acac42f61a66aa1871 |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
| e5fc57c | https://github.com/matplotlib/matplotlib/commit/e5fc57c8c15846f966a85f6ccd3e584af2179170 |
| Mar 30, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#event-8891794693 |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
| Mar 30, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#issuecomment-1490947548 |
| @thomasjpfan | https://github.com/thomasjpfan |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| v3.8.0 | https://github.com/matplotlib/matplotlib/milestone/77 |
| Mar 30, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#event-8891802977 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
|
status: needs revision
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20revision%22 |
| Mar 30, 2023 | https://github.com/matplotlib/matplotlib/pull/25253#event-8891803196 |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
|
Mar 30, 2023
| https://github.com/matplotlib/matplotlib/pull/25253#ref-issue-1367618175 |
|
[MNT]: Pybind11 transition plan
#23846
| https://github.com/matplotlib/matplotlib/issues/23846 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25253 |
|
| https://github.com/oscargus |
|
oscargus
| https://github.com/oscargus |
|
| https://github.com/matplotlib/matplotlib/pull/25253/files/25f80746278cfcfe2f5f4a071d6b580c72c2a1db |
|
| https://github.com/apps/github-actions |
|
github-actions[bot]
| https://github.com/apps/github-actions |
|
| https://github.com/matplotlib/matplotlib/pull/25253/files/25f80746278cfcfe2f5f4a071d6b580c72c2a1db |
|
| https://github.com/ianthomas23 |
|
ianthomas23
| https://github.com/ianthomas23 |
|
| https://github.com/matplotlib/matplotlib/pull/25253/files/8da08a7bd9f0c93dc8de8a83cf4f2fef3629b91f |
|
| https://github.com/anntzer |
|
anntzer
| https://github.com/anntzer |
|
| https://github.com/matplotlib/matplotlib/pull/25253/files/3205f852683deba26c8a38acac42f61a66aa1871 |
|
topic: text/fonts
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20text%2Ffonts%22 |
|
First Time Contributors
| https://github.com/orgs/matplotlib/projects/1 |
|
v3.8.0
| https://github.com/matplotlib/matplotlib/milestone/77 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/25253 |
|
| https://github.com/thomasjpfan |
|
| https://github.com/anntzer |
|
| https://github.com/oscargus |
|
| https://github.com/ianthomas23 |
|
| https://github.com/tacaswell |
|
| https://github.com/jklymak |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |