Title: MAINT: don't format logs in log call. by Carreau · Pull Request #25073 · matplotlib/matplotlib · GitHub
Open Graph Title: MAINT: don't format logs in log call. by Carreau · Pull Request #25073 · matplotlib/matplotlib
X Title: MAINT: don't format logs in log call. by Carreau · Pull Request #25073 · matplotlib/matplotlib
Description: In particular f-string: There are many reason not to use f-string in logs, F-strings are eager, so might be slow. So this may affect performance (we can filter before formatting). prevent structured logging or handler to highlight. Security (untrusted input can lead to DOS on formatting, https://discuss.python.org/t/safer-logging-methods-for-f-strings-and-new-style-formatting/13802) But also % formatting in a couple of places. PR Checklist Documentation and Tests Has pytest style unit tests (and pytest passes) Documentation is sphinx and numpydoc compliant (the docs should build without error). New plotting related features are documented with examples. Release Notes New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/ API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/ Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst
Open Graph Description: In particular f-string: There are many reason not to use f-string in logs, F-strings are eager, so might be slow. So this may affect performance (we can filter before formatting). prevent structur...
X Description: In particular f-string: There are many reason not to use f-string in logs, F-strings are eager, so might be slow. So this may affect performance (we can filter before formatting). prevent structur...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/25073
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4dc05d95-c2d4-708f-eea7-24eef339cdd1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A0E4:183E3C:1F43F7:2A47F2:6A51871B |
| html-safe-nonce | 584e8a1fefb1223f05764960b87388ade3bd63ba51f362f39583902ac6aacf1c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEU0OjE4M0UzQzoxRjQzRjc6MkE0N0YyOjZBNTE4NzFCIiwidmlzaXRvcl9pZCI6IjIyNTU1MTk2NTY1NzkyNzA0MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1fb6ff02a9e59e0a62a73a776488a78d423c50695d03a21cf381c82f76ac11fc |
| hovercard-subject-tag | pull_request:1216171493 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/25073/files |
| twitter:image | https://avatars.githubusercontent.com/u/335567?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/335567?s=400&v=4 |
| og:image:alt | In particular f-string: There are many reason not to use f-string in logs, F-strings are eager, so might be slow. So this may affect performance (we can filter before formatting). prevent structur... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cb77a7b8b06cd86c243be33fd8e7922d70a9d243 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width