René's URL Explorer Experiment


Title: MAINT: don't format logs in log call. by Carreau · Pull Request #25073 · matplotlib/matplotlib · GitHub

Open Graph Title: MAINT: don't format logs in log call. by Carreau · Pull Request #25073 · matplotlib/matplotlib

X Title: MAINT: don't format logs in log call. by Carreau · Pull Request #25073 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: In particular f-string: There are many reason not to use f-string in logs, F-strings are eager, so might be slow. So this may affect performance (we can filter before formatting). prevent structur...

X Description: In particular f-string: There are many reason not to use f-string in logs, F-strings are eager, so might be slow. So this may affect performance (we can filter before formatting). prevent structur...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/25073

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b5f9e4dd-ce5d-9729-3a98-b3909a9d0df7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB7D8:E7634:26D7F37:3785963:6A5102D3
html-safe-nonceac7d8e59ace9350e86f2aecf9cc92e435c4ee6203bce9c1240dcb5fb393f1d94
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0Q4OkU3NjM0OjI2RDdGMzc6Mzc4NTk2Mzo2QTUxMDJEMyIsInZpc2l0b3JfaWQiOiI0MTgzMjY4MjYzNzA1MjQ4NDY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace57100dcc8f64bffe8776e50bc51ea06cdb6c8c01ea76427dfbce637d903421e
hovercard-subject-tagpull_request:1216171493
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/25073/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bdce11c09d7a6cd2f5ead27b4a7f9cf8a4c0d770bc535b42b4a4b20c574abbdc/matplotlib/matplotlib/pull/25073
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bdce11c09d7a6cd2f5ead27b4a7f9cf8a4c0d770bc535b42b4a4b20c574abbdc/matplotlib/matplotlib/pull/25073
og:image:altIn particular f-string: There are many reason not to use f-string in logs, F-strings are eager, so might be slow. So this may affect performance (we can filter before formatting). prevent structur...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameCarreau
hostnamegithub.com
expected-hostnamegithub.com
None38906a4da4e3e9fd88dfeacee232f5932c0c5f7495de3b4efc53ddfac7173d12
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release90441ea9b98e7491aa6ebcd135fccce4e2396f48
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/25073#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25073
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25073
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/25073
Reloadhttps://github.com/matplotlib/matplotlib/pull/25073
Reloadhttps://github.com/matplotlib/matplotlib/pull/25073
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 410 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
jklymakhttps://github.com/jklymak
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
Carreau:log-fhttps://github.com/Carreau/matplotlib/tree/log-f
Conversationhttps://github.com/matplotlib/matplotlib/pull/25073
Commits2 (2)https://github.com/matplotlib/matplotlib/pull/25073/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/25073/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/25073/files
MAINT: don't format logs in log call.https://github.com/matplotlib/matplotlib/pull/25073#top
jklymakhttps://github.com/jklymak
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
Carreau:log-fhttps://github.com/Carreau/matplotlib/tree/log-f
https://github.com/Carreau
Carreauhttps://github.com/Carreau
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#issue-1556193968
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://discuss.python.org/t/safer-logging-methods-for-f-strings-and-new-style-formatting/13802https://discuss.python.org/t/safer-logging-methods-for-f-strings-and-new-style-formatting/13802
buildhttps://matplotlib.org/devel/documenting_mpl.html#building-the-docs
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/Carreau
MAINT: don't format logs in log call.https://github.com/matplotlib/matplotlib/pull/25073/commits/90a753bf8e89d4b8c8db53c6cfec5c91691fbb19
90a753bhttps://github.com/matplotlib/matplotlib/pull/25073/commits/90a753bf8e89d4b8c8db53c6cfec5c91691fbb19
https://discuss.python.org/t/safer-logging-methods-for-f-strings-and-new-style-formatting/13802https://discuss.python.org/t/safer-logging-methods-for-f-strings-and-new-style-formatting/13802
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Jan 25, 2023 https://github.com/matplotlib/matplotlib/pull/25073#pullrequestreview-1268861818
View reviewed changes https://github.com/matplotlib/matplotlib/pull/25073/files/90a753bf8e89d4b8c8db53c6cfec5c91691fbb19
lib/matplotlib/_mathtext.pyhttps://github.com/matplotlib/matplotlib/pull/25073/files/90a753bf8e89d4b8c8db53c6cfec5c91691fbb19#diff-b9cdf0225738fe9cda199638468c30de458b0e1f83fbc041e04206b9a2ad90f7
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/Carreau
https://github.com/QuLogic
Update lib/matplotlib/_mathtext.pyhttps://github.com/matplotlib/matplotlib/pull/25073/commits/9fceadf47252465dd52d8e3fbce3e497c8b0c37e
9fceadfhttps://github.com/matplotlib/matplotlib/pull/25073/commits/9fceadf47252465dd52d8e3fbce3e497c8b0c37e
https://github.com/story645
story645https://github.com/story645
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#issuecomment-1403711269
contributing codehttps://matplotlib.org/devdocs/devel/contributing.html#using-logging-for-debug-messages
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Jan 25, 2023 https://github.com/matplotlib/matplotlib/pull/25073#pullrequestreview-1269777106
View reviewed changes https://github.com/matplotlib/matplotlib/pull/25073/files/9fceadf47252465dd52d8e3fbce3e497c8b0c37e
https://github.com/jklymak
jklymakhttps://github.com/jklymak
aaf01bfhttps://github.com/matplotlib/matplotlib/commit/aaf01bf0918d6d072a9824581aa3e5bccf1ad7e0
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#event-8356985374
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#issuecomment-1403959959
@meeseeksdevhttps://github.com/meeseeksdev
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/jklymak
jklymakhttps://github.com/jklymak
v3.7.0https://github.com/matplotlib/matplotlib/milestone/70
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#event-8356990150
https://github.com/apps/lumberbot-app
lumberbot-apphttps://github.com/apps/lumberbot-app
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#issuecomment-1403960530
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Jan 25, 2023 https://github.com/matplotlib/matplotlib/pull/25073#ref-issue-1557010858
Add note in contrib guide admonishing against use of f strings in logs #25080 https://github.com/matplotlib/matplotlib/issues/25080
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#issuecomment-1403963492
@meeseeksdevhttps://github.com/meeseeksdev
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/apps/lumberbot-app
lumberbot-apphttps://github.com/apps/lumberbot-app
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#issuecomment-1403963610
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#issuecomment-1403963908
@meeseeksdevhttps://github.com/meeseeksdev
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/apps/lumberbot-app
lumberbot-apphttps://github.com/apps/lumberbot-app
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#issuecomment-1403964031
#25073https://github.com/matplotlib/matplotlib/pull/25073
suggest an improvementhttps://github.com/MeeseeksBox/MeeseeksDev
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/apps/lumberbot-app
lumberbot-apphttps://github.com/apps/lumberbot-app
Still Needs Manual Backport https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Still%20Needs%20Manual%20Backport%22
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#event-8357019038
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#issuecomment-1403964692
@Carreauhttps://github.com/Carreau
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/ksunden
ksundenhttps://github.com/ksunden
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#issuecomment-1403972861
#24980https://github.com/matplotlib/matplotlib/pull/24980
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#issuecomment-1403977104
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/greglucas
greglucashttps://github.com/greglucas
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#issuecomment-1404045323
@Carreauhttps://github.com/Carreau
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Still Needs Manual Backport https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Still%20Needs%20Manual%20Backport%22
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#event-8357920092
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
v3.7.0https://github.com/matplotlib/matplotlib/milestone/70
v3.8.0https://github.com/matplotlib/matplotlib/milestone/77
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#event-8357920473
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#issuecomment-1404102279
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/Carreau
Carreauhttps://github.com/Carreau
Jan 25, 2023https://github.com/matplotlib/matplotlib/pull/25073#issuecomment-1404123773
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F25073
https://github.com/QuLogic
QuLogic https://github.com/QuLogic
https://github.com/matplotlib/matplotlib/pull/25073/files/90a753bf8e89d4b8c8db53c6cfec5c91691fbb19
https://github.com/jklymak
jklymak https://github.com/jklymak
https://github.com/matplotlib/matplotlib/pull/25073/files/9fceadf47252465dd52d8e3fbce3e497c8b0c37e
v3.8.0 https://github.com/matplotlib/matplotlib/milestone/77
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/25073
https://github.com/Carreau
https://github.com/story645
https://github.com/jklymak
https://github.com/ksunden
https://github.com/greglucas
https://github.com/tacaswell
https://github.com/QuLogic
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.