Title: FIX: adjust_bbox should not modify layout engine by rcomer · Pull Request #24971 · matplotlib/matplotlib · GitHub
Open Graph Title: FIX: adjust_bbox should not modify layout engine by rcomer · Pull Request #24971 · matplotlib/matplotlib
X Title: FIX: adjust_bbox should not modify layout engine by rcomer · Pull Request #24971 · matplotlib/matplotlib
Description: PR Summary Fixes #24954 (I think!) I don't claim to fully understand everything that's going on here, but it seems to me that these lines are doing the same job as matplotlib/lib/matplotlib/backend_bases.py Lines 2356 to 2357 in 018c5ef # we have already done layout above, so turn it off: stack.enter_context(self.figure._cm_set(layout_engine='none')) Since restore_bbox gets called within the above context manager, the final result is the layout engine continues to be what was set with fig.set_layout_engine(None). PR Checklist Documentation and Tests Has pytest style unit tests (and pytest passes) [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error). [N/A] New plotting related features are documented with examples. Release Notes [N/A] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/ [N/A] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/ [N/A] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst
Open Graph Description: PR Summary Fixes #24954 (I think!) I don't claim to fully understand everything that's going on here, but it seems to me that these lines are doing the same job as matplotli...
X Description: PR Summary Fixes #24954 (I think!) I don't claim to fully understand everything that's going on here, but it seems to me that these lines are doing the same job as m...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/24971
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ced8bb3a-bc29-bea7-b5ec-9d4b8eefa8eb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DE28:57C75:4249DA:5E0503:6A50FA06 |
| html-safe-nonce | 2f965a2d264480662bfdbe36c9ec4f9aab5d16930e2cdb168fb7ed09c91e45b6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTI4OjU3Qzc1OjQyNDlEQTo1RTA1MDM6NkE1MEZBMDYiLCJ2aXNpdG9yX2lkIjoiNDMzNTI3MjI3MTYxNjczNTc1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fd91ce95b254547122c1c956b9ffbc81c9473e200d3c2e752c54d1cfbf4565f8 |
| hovercard-subject-tag | pull_request:1196800556 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/24971/files |
| twitter:image | https://avatars.githubusercontent.com/u/10599679?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10599679?s=400&v=4 |
| og:image:alt | PR Summary Fixes #24954 (I think!) I don't claim to fully understand everything that's going on here, but it seems to me that these lines are doing the same job as matplotli... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5266e58c17a510c403505cc811606465e90a881d2007ee7df1c4800d5c659838 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8d836581d020676cc0ef4a83cd2fe17e4af02c3d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width