| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:609d0e39-4f41-0bf5-4e70-f570c1322b62 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CA98:1E565C:D8F5B9:12226EF:6A52AA5A |
| html-safe-nonce | 73fcdd2cc044e1be20235c4371a9886ef5645e07e57b4c6977d92c225b9af2e2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTk4OjFFNTY1QzpEOEY1Qjk6MTIyMjZFRjo2QTUyQUE1QSIsInZpc2l0b3JfaWQiOiIxMzU4NDgyMjgyMTgzODI5MzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e0b6558e2008e7bd50c090d36d0d459effe6ce658a0e23ec2d04a9262743bfcc |
| hovercard-subject-tag | pull_request:1196789944 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/24970/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5a9338a44880782c5296fd43e93d21dcf1b8041bfdd324acbd5b8b7ed6c2a144/matplotlib/matplotlib/pull/24970 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5a9338a44880782c5296fd43e93d21dcf1b8041bfdd324acbd5b8b7ed6c2a144/matplotlib/matplotlib/pull/24970 |
| og:image:alt | PR Summary
Since we use subtraction to compute the lookup table indices we need to cast uints in addition to floats, so we can move the cast outside of the float block.
closes #24865
PR Checklist
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | greglucas |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/24970#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F24970 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F24970 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/24970 |
| Reload | https://github.com/matplotlib/matplotlib/pull/24970 |
| Reload | https://github.com/matplotlib/matplotlib/pull/24970 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/24970 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/24970 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
408
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| QuLogic | https://github.com/QuLogic |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| greglucas:cmap-cast | https://github.com/greglucas/matplotlib/tree/cmap-cast |
| Conversation | https://github.com/matplotlib/matplotlib/pull/24970 |
| Commits1 (1) | https://github.com/matplotlib/matplotlib/pull/24970/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/24970/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/24970/files |
| FIX: Handle uint8 indices properly for colormap lookups | https://github.com/matplotlib/matplotlib/pull/24970#top |
| QuLogic | https://github.com/QuLogic |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| greglucas:cmap-cast | https://github.com/greglucas/matplotlib/tree/cmap-cast |
|
| https://github.com/greglucas |
| greglucas | https://github.com/greglucas |
| Jan 13, 2023 | https://github.com/matplotlib/matplotlib/pull/24970#issue-1532379691 |
| #24865 | https://github.com/matplotlib/matplotlib/issues/24865 |
| build | https://matplotlib.org/devel/documenting_mpl.html#building-the-docs |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/24970 |
|
| https://github.com/greglucas |
| FIX: Handle uint8 indices properly for colormap lookups | https://github.com/matplotlib/matplotlib/pull/24970/commits/9229e5a2e9d186dcb2f0d27b7be26156afe5424d |
| 9229e5a | https://github.com/matplotlib/matplotlib/pull/24970/commits/9229e5a2e9d186dcb2f0d27b7be26156afe5424d |
| https://github.com/greglucas |
| greglucas | https://github.com/greglucas |
| v3.7.0 | https://github.com/matplotlib/matplotlib/milestone/70 |
| Jan 13, 2023 | https://github.com/matplotlib/matplotlib/pull/24970#event-8221296299 |
| https://github.com/greglucas |
| greglucas | https://github.com/greglucas |
|
topic: color/color & colormaps
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20color%2Fcolor%20%26%20colormaps%22 |
| Jan 13, 2023 | https://github.com/matplotlib/matplotlib/pull/24970#event-8221298113 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Jan 13, 2023
| https://github.com/matplotlib/matplotlib/pull/24970#pullrequestreview-1247981603 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/24970/files/9229e5a2e9d186dcb2f0d27b7be26156afe5424d |
| lib/matplotlib/colors.py | https://github.com/matplotlib/matplotlib/pull/24970/files/9229e5a2e9d186dcb2f0d27b7be26156afe5424d#diff-3c08c967cdebbe0574ff68dceb5faba6cbb89ca53492e0fc3feeabc37cea37b6 |
| anntzer | https://github.com/anntzer |
| Jan 13, 2023 | https://github.com/matplotlib/matplotlib/pull/24970#discussion_r1069665158 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/24970 |
| greglucas | https://github.com/greglucas |
| Jan 13, 2023 | https://github.com/matplotlib/matplotlib/pull/24970#discussion_r1069688074 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/24970 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/24970 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
|
Jan 13, 2023
| https://github.com/matplotlib/matplotlib/pull/24970#pullrequestreview-1248598816 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/24970/files/9229e5a2e9d186dcb2f0d27b7be26156afe5424d |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Jan 14, 2023
| https://github.com/matplotlib/matplotlib/pull/24970#pullrequestreview-1248693455 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/24970/files/9229e5a2e9d186dcb2f0d27b7be26156afe5424d |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| 99d39bd | https://github.com/matplotlib/matplotlib/commit/99d39bd767cead981d4ebe78ca7b018cc571dd60 |
| Jan 14, 2023 | https://github.com/matplotlib/matplotlib/pull/24970#event-8225559420 |
| https://github.com/meeseeksmachine |
| meeseeksmachine | https://github.com/meeseeksmachine |
|
Jan 14, 2023
| https://github.com/matplotlib/matplotlib/pull/24970#ref-pullrequest-1533080946 |
|
Backport PR #24970 on branch v3.7.x (FIX: Handle uint8 indices properly for colormap lookups)
#24977
| https://github.com/matplotlib/matplotlib/pull/24977 |
| meeseeksmachine | https://github.com/meeseeksmachine |
|
Jan 14, 2023
| https://github.com/matplotlib/matplotlib/pull/24970#ref-commit-bbedbf9 |
|
| https://github.com/QuLogic |
|
| https://github.com/meeseeksmachine |
| Backport PR | https://github.com/meeseeksmachine/matplotlib/commit/bbedbf9a9326e4861520045687aff4986ae0a438 |
| matplotlib#24970 | https://github.com/matplotlib/matplotlib/pull/24970 |
| : FIX: Handle uint8 indices properly for … | https://github.com/meeseeksmachine/matplotlib/commit/bbedbf9a9326e4861520045687aff4986ae0a438 |
| bbedbf9 | https://github.com/meeseeksmachine/matplotlib/commit/bbedbf9a9326e4861520045687aff4986ae0a438 |
| rcomer | https://github.com/rcomer |
|
Jan 14, 2023
| https://github.com/matplotlib/matplotlib/pull/24970#ref-commit-6c7cda8 |
|
| https://github.com/rcomer |
| Merge pull request | https://github.com/matplotlib/matplotlib/commit/6c7cda8221f8c94ef5eb151f2c8f1e47d786e797 |
| #24977 | https://github.com/matplotlib/matplotlib/pull/24977 |
| from meeseeksmachine/auto-backport-of-pr-24… | https://github.com/matplotlib/matplotlib/commit/6c7cda8221f8c94ef5eb151f2c8f1e47d786e797 |
| 6c7cda8 | https://github.com/matplotlib/matplotlib/commit/6c7cda8221f8c94ef5eb151f2c8f1e47d786e797 |
| #24970 | https://github.com/matplotlib/matplotlib/pull/24970 |
| https://github.com/greglucas |
| greglucas | https://github.com/greglucas |
| January 31, 2023 17:32 | https://github.com/matplotlib/matplotlib/pull/24970#event-8402167047 |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
|
Feb 20, 2023
| https://github.com/matplotlib/matplotlib/pull/24970#ref-pullrequest-1592305660 |
|
merge up 3.7.0
#25270
| https://github.com/matplotlib/matplotlib/pull/25270 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F24970 |
|
| https://github.com/anntzer |
|
anntzer
| https://github.com/anntzer |
|
| https://github.com/matplotlib/matplotlib/pull/24970/files/9229e5a2e9d186dcb2f0d27b7be26156afe5424d |
|
| https://github.com/tacaswell |
|
tacaswell
| https://github.com/tacaswell |
|
| https://github.com/matplotlib/matplotlib/pull/24970/files/9229e5a2e9d186dcb2f0d27b7be26156afe5424d |
|
| https://github.com/QuLogic |
|
QuLogic
| https://github.com/QuLogic |
|
| https://github.com/matplotlib/matplotlib/pull/24970/files/9229e5a2e9d186dcb2f0d27b7be26156afe5424d |
|
topic: color/color & colormaps
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20color%2Fcolor%20%26%20colormaps%22 |
|
v3.7.0
| https://github.com/matplotlib/matplotlib/milestone/70 |
|
[Bug]: NumPy 1.24 deprecation warnings
| https://github.com/matplotlib/matplotlib/issues/24865 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/24970 |
|
| https://github.com/greglucas |
|
| https://github.com/tacaswell |
|
| https://github.com/QuLogic |
|
| https://github.com/anntzer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |