Title: Use masked stack to preserve mask info by chahak13 · Pull Request #24732 · matplotlib/matplotlib · GitHub
Open Graph Title: Use masked stack to preserve mask info by chahak13 · Pull Request #24732 · matplotlib/matplotlib
X Title: Use masked stack to preserve mask info by chahak13 · Pull Request #24732 · matplotlib/matplotlib
Description: PR Summary As pointed out in #24545 , scatter was not masking datetime correctly. This issue would be true for any data with units because of the following lines matplotlib/lib/matplotlib/collections.py Lines 323 to 325 in cc85fb6 xs = self.convert_xunits(offsets[:, 0]) ys = self.convert_yunits(offsets[:, 1]) offsets = np.column_stack([xs, ys]) Whenever self.have_units() was True, it would use np.column_stack instead of np.ma.column_stack which would lead to the loss of mask information. Changing that to the masked version resolves #24545 . PR Checklist Documentation and Tests Has pytest style unit tests (and pytest passes) Documentation is sphinx and numpydoc compliant (the docs should build without error). New plotting related features are documented with examples. Release Notes New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/ API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/ Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst
Open Graph Description: PR Summary As pointed out in #24545 , scatter was not masking datetime correctly. This issue would be true for any data with units because of the following lines matplotlib/lib/matpl...
X Description: PR Summary As pointed out in #24545 , scatter was not masking datetime correctly. This issue would be true for any data with units because of the following lines matplotlib/lib/matpl...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/24732
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:44390f95-7964-7bd9-f775-761c34a4f2e4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 97C0:1E9FD2:1422FF:1C42AA:6A51119B |
| html-safe-nonce | 9f714e090ea4741bdac904a3f8fad4e88b9d7db9e50bccecf3ca390b39a6ff5c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0MwOjFFOUZEMjoxNDIyRkY6MUM0MkFBOjZBNTExMTlCIiwidmlzaXRvcl9pZCI6IjUyMTg5ODQ5MzgzNDc0OTk5MzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8c8f89d31773df8c4790e0436453b477eb28c24b11041f51cc08e2f1417ea802 |
| hovercard-subject-tag | pull_request:1166336010 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/24732/files |
| twitter:image | https://avatars.githubusercontent.com/u/29800965?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/29800965?s=400&v=4 |
| og:image:alt | PR Summary As pointed out in #24545 , scatter was not masking datetime correctly. This issue would be true for any data with units because of the following lines matplotlib/lib/matpl... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b076e100febaa00374cd89239f915d00dd3187f7c68b12bc2b7688181305344d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f9137f6d981cbbfd780af369f80ce890b2d0d2d4 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width
