René's URL Explorer Experiment


Title: BUG: Fix bug with mutable input modification by larsoner · Pull Request #24657 · matplotlib/matplotlib · GitHub

Open Graph Title: BUG: Fix bug with mutable input modification by larsoner · Pull Request #24657 · matplotlib/matplotlib

X Title: BUG: Fix bug with mutable input modification by larsoner · Pull Request #24657 · matplotlib/matplotlib

Description: PR Summary On main, imsave (and thus fig.savefig) modifies the mutable pil_kwargs without making a copy. The modified tests fail on main but pass on this PR. PR Checklist Documentation and Tests Has pytest style unit tests (and pytest passes) Documentation is sphinx and numpydoc compliant (the docs should build without error). New plotting related features are documented with examples. Release Notes New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/ API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/ Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

Open Graph Description: PR Summary On main, imsave (and thus fig.savefig) modifies the mutable pil_kwargs without making a copy. The modified tests fail on main but pass on this PR. PR Checklist Documentation and Tests ...

X Description: PR Summary On main, imsave (and thus fig.savefig) modifies the mutable pil_kwargs without making a copy. The modified tests fail on main but pass on this PR. PR Checklist Documentation and Tests ...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/24657

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f48bd294-9d41-f2f9-dfc4-90e3adecb659
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA4FE:1FCD98:14E82BE:1BB10D5:6A51B6F1
html-safe-nonce5ffc45cf88a9eb1fe6a098fa8e9d2202942ad0b02332dac6f210336a96b24d3b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEZFOjFGQ0Q5ODoxNEU4MkJFOjFCQjEwRDU6NkE1MUI2RjEiLCJ2aXNpdG9yX2lkIjoiNTk3MzY2MDI0MzI5MjQzNjIwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9ff9085fc07544f22ba1ab923f34e6cf54e6431dec176a5580e860585ef1ca25
hovercard-subject-tagpull_request:1152166121
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/24657/files
twitter:imagehttps://avatars.githubusercontent.com/u/2365790?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2365790?s=400&v=4
og:image:altPR Summary On main, imsave (and thus fig.savefig) modifies the mutable pil_kwargs without making a copy. The modified tests fail on main but pass on this PR. PR Checklist Documentation and Tests ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/24657/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F24657%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F24657%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/24657/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/24657/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/24657/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24657/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24657/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
jklymakhttps://github.com/jklymak
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
larsoner:savefighttps://github.com/larsoner/matplotlib/tree/savefig
Conversation 0 https://github.com/matplotlib/matplotlib/pull/24657
Commits 1 https://github.com/matplotlib/matplotlib/pull/24657/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/24657/checks
Files changed https://github.com/matplotlib/matplotlib/pull/24657/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24657/files
BUG: Fix bug with mutable input modification https://github.com/matplotlib/matplotlib/pull/24657/files#top
Show all changes 1 commit https://github.com/matplotlib/matplotlib/pull/24657/files
76e087d BUG: Fix bug with mutable input modification larsoner Dec 7, 2022 https://github.com/matplotlib/matplotlib/pull/24657/commits/76e087dbfc13cdd5950cf20472d72259bb897813
Clear filters https://github.com/matplotlib/matplotlib/pull/24657/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24657/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24657/files
image.py https://github.com/matplotlib/matplotlib/pull/24657/files#diff-25ae7458ece3baeb36f57b6d14661c66781454a7a0532e5847eb4ed425ec0f5f
test_agg.py https://github.com/matplotlib/matplotlib/pull/24657/files#diff-0cf0af95209d6becfb32b9cc668d6b0f2df30fd7269427361de3ed2af83df228
test_image.py https://github.com/matplotlib/matplotlib/pull/24657/files#diff-8a96f32702b9c91b992e6cc9cb438eaaa26993101dbf40ea31ccbc097b47f68a
lib/matplotlib/image.pyhttps://github.com/matplotlib/matplotlib/pull/24657/files#diff-25ae7458ece3baeb36f57b6d14661c66781454a7a0532e5847eb4ed425ec0f5f
View file https://github.com/larsoner/matplotlib/blob/76e087dbfc13cdd5950cf20472d72259bb897813/lib/matplotlib/image.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/24657/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/24657/files#diff-25ae7458ece3baeb36f57b6d14661c66781454a7a0532e5847eb4ed425ec0f5f
https://github.com/matplotlib/matplotlib/pull/24657/files#diff-25ae7458ece3baeb36f57b6d14661c66781454a7a0532e5847eb4ed425ec0f5f
lib/matplotlib/tests/test_agg.pyhttps://github.com/matplotlib/matplotlib/pull/24657/files#diff-0cf0af95209d6becfb32b9cc668d6b0f2df30fd7269427361de3ed2af83df228
View file https://github.com/larsoner/matplotlib/blob/76e087dbfc13cdd5950cf20472d72259bb897813/lib/matplotlib/tests/test_agg.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/24657/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/24657/files#diff-0cf0af95209d6becfb32b9cc668d6b0f2df30fd7269427361de3ed2af83df228
https://github.com/matplotlib/matplotlib/pull/24657/files#diff-0cf0af95209d6becfb32b9cc668d6b0f2df30fd7269427361de3ed2af83df228
lib/matplotlib/tests/test_image.pyhttps://github.com/matplotlib/matplotlib/pull/24657/files#diff-8a96f32702b9c91b992e6cc9cb438eaaa26993101dbf40ea31ccbc097b47f68a
View file https://github.com/larsoner/matplotlib/blob/76e087dbfc13cdd5950cf20472d72259bb897813/lib/matplotlib/tests/test_image.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/24657/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/24657/files#diff-8a96f32702b9c91b992e6cc9cb438eaaa26993101dbf40ea31ccbc097b47f68a
https://github.com/matplotlib/matplotlib/pull/24657/files#diff-8a96f32702b9c91b992e6cc9cb438eaaa26993101dbf40ea31ccbc097b47f68a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.