René's URL Explorer Experiment


Title: Make LogLocator only return one tick out of range by dstansby · Pull Request #24436 · matplotlib/matplotlib · GitHub

Open Graph Title: Make LogLocator only return one tick out of range by dstansby · Pull Request #24436 · matplotlib/matplotlib

X Title: Make LogLocator only return one tick out of range by dstansby · Pull Request #24436 · matplotlib/matplotlib

Description: PR Summary I'm working on thoroughly testing LogLocator, and this PR is a start. There is a new parametrized test that checks the tick locations for a given vmin, vmax. I have also changed the logic for geting the tick locations slightly. Before the locator was returning two ticks below vmin, and two ticks above vmax. Looking through the commit history I cannot find any reason to do this, so to make the logic clear I have changed this to returning one tick below vmin/one ablove vmax (as is needed for clipping and potentially autoscaling). I've then documented this logic in the docstring. The changed tests are just removing the extra tick at each end - because there is still a single "out of bounds" tick returned at each end no figures should change with this PR. PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation Documentation is sphinx and numpydoc compliant (the docs should build without error). New plotting related features are documented with examples. Release Notes New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/ API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/ Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

Open Graph Description: PR Summary I'm working on thoroughly testing LogLocator, and this PR is a start. There is a new parametrized test that checks the tick locations for a given vmin, vmax. I have also changed the ...

X Description: PR Summary I'm working on thoroughly testing LogLocator, and this PR is a start. There is a new parametrized test that checks the tick locations for a given vmin, vmax. I have also changed ...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/24436

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f5ee4adc-81e2-4ef4-ed5d-bf52f9496dd6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC296:288515:116C1EA:17582A7:6A533AC7
html-safe-nonce56c852d6fbf5d638ec91e40553b553f023c8c4cefe136c638d0a888ffe1dcebe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjk2OjI4ODUxNToxMTZDMUVBOjE3NTgyQTc6NkE1MzNBQzciLCJ2aXNpdG9yX2lkIjoiNTk3OTM2MDUxMTAwMjg4NDgwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac044a537182b3674a1156146602b1ff8c1c28cf652ee37f551249129acf064355
hovercard-subject-tagpull_request:1119905980
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/24436/files
twitter:imagehttps://avatars.githubusercontent.com/u/6197628?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6197628?s=400&v=4
og:image:altPR Summary I'm working on thoroughly testing LogLocator, and this PR is a start. There is a new parametrized test that checks the tick locations for a given vmin, vmax. I have also changed the ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/24436/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F24436%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F24436%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/24436/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/24436/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/24436/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24436/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24436/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
dstansbyhttps://github.com/dstansby
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
dstansby:test-loglocatorhttps://github.com/dstansby/matplotlib/tree/test-loglocator
Conversation 13 https://github.com/matplotlib/matplotlib/pull/24436
Commits 7 https://github.com/matplotlib/matplotlib/pull/24436/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/24436/checks
Files changed 5 https://github.com/matplotlib/matplotlib/pull/24436/files
Make LogLocator only return one tick out of range https://github.com/matplotlib/matplotlib/pull/24436/files#top
Show all changes 7 commits https://github.com/matplotlib/matplotlib/pull/24436/files
d495301 Move invalid vmin to separate test dstansby Nov 12, 2022 https://github.com/matplotlib/matplotlib/pull/24436/commits/d4953012957aaa82e8e204f8a677bc678329faed
5e733de Add some new LogLocator tests dstansby Nov 12, 2022 https://github.com/matplotlib/matplotlib/pull/24436/commits/5e733de11fc14cb2aaeed92ccec04eb9ff60ede7
4ba7411 Add note about out of bounds ticks dstansby Dec 1, 2022 https://github.com/matplotlib/matplotlib/pull/24436/commits/4ba7411cd405b0f29edcc690a5475b07ee3b306c
737aa02 Simplify log locator logic dstansby Dec 1, 2022 https://github.com/matplotlib/matplotlib/pull/24436/commits/737aa02141fd9a4bfff54fa7e151aae310c36c45
36adb34 Fix tests dstansby Dec 1, 2022 https://github.com/matplotlib/matplotlib/pull/24436/commits/36adb34d7996a0fe1f7345c897a834f95de0f02c
792236a Add changelog entry dstansby Dec 1, 2022 https://github.com/matplotlib/matplotlib/pull/24436/commits/792236adfb1d33df1876132e70e0288916b8fa9d
a8ba49d Fix non-positive warning dstansby Dec 15, 2022 https://github.com/matplotlib/matplotlib/pull/24436/commits/a8ba49d87163cd42bb581771e9bbeb536f765be4
Clear filters https://github.com/matplotlib/matplotlib/pull/24436/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24436/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24436/files
24436-DS.rst https://github.com/matplotlib/matplotlib/pull/24436/files#diff-a41e3905932fb745a3a492a03d38da39ff7686b75ec6c493ea66103b19e16504
test_axes.py https://github.com/matplotlib/matplotlib/pull/24436/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
test_colorbar.py https://github.com/matplotlib/matplotlib/pull/24436/files#diff-4e87144ecd6481ec6a62c5d63a0598eb1a1514fe1df2631acb62e5d5232b6fc7
test_ticker.py https://github.com/matplotlib/matplotlib/pull/24436/files#diff-fd4f809a4a2ca8b97875eff013bac232c55ca3f92f165117f778960ca1795869
ticker.py https://github.com/matplotlib/matplotlib/pull/24436/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66
doc/api/next_api_changes/behavior/24436-DS.rsthttps://github.com/matplotlib/matplotlib/pull/24436/files#diff-a41e3905932fb745a3a492a03d38da39ff7686b75ec6c493ea66103b19e16504
View file https://github.com/dstansby/matplotlib/blob/a8ba49d87163cd42bb581771e9bbeb536f765be4/doc/api/next_api_changes/behavior/24436-DS.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/24436/{{ revealButtonHref }}
jklymakhttps://github.com/jklymak
Feb 2, 2023https://github.com/matplotlib/matplotlib/pull/24436/files#r1094861707
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24436/files
tacaswellhttps://github.com/tacaswell
Feb 2, 2023https://github.com/matplotlib/matplotlib/pull/24436/files#r1094941948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24436/files
lib/matplotlib/tests/test_axes.pyhttps://github.com/matplotlib/matplotlib/pull/24436/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
View file https://github.com/dstansby/matplotlib/blob/a8ba49d87163cd42bb581771e9bbeb536f765be4/lib/matplotlib/tests/test_axes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/24436/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
lib/matplotlib/tests/test_colorbar.pyhttps://github.com/matplotlib/matplotlib/pull/24436/files#diff-4e87144ecd6481ec6a62c5d63a0598eb1a1514fe1df2631acb62e5d5232b6fc7
View file https://github.com/dstansby/matplotlib/blob/a8ba49d87163cd42bb581771e9bbeb536f765be4/lib/matplotlib/tests/test_colorbar.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/24436/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-4e87144ecd6481ec6a62c5d63a0598eb1a1514fe1df2631acb62e5d5232b6fc7
tacaswellhttps://github.com/tacaswell
Feb 2, 2023https://github.com/matplotlib/matplotlib/pull/24436/files#r1094929192
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24436/files
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-4e87144ecd6481ec6a62c5d63a0598eb1a1514fe1df2631acb62e5d5232b6fc7
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-4e87144ecd6481ec6a62c5d63a0598eb1a1514fe1df2631acb62e5d5232b6fc7
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-4e87144ecd6481ec6a62c5d63a0598eb1a1514fe1df2631acb62e5d5232b6fc7
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-4e87144ecd6481ec6a62c5d63a0598eb1a1514fe1df2631acb62e5d5232b6fc7
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-4e87144ecd6481ec6a62c5d63a0598eb1a1514fe1df2631acb62e5d5232b6fc7
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-4e87144ecd6481ec6a62c5d63a0598eb1a1514fe1df2631acb62e5d5232b6fc7
lib/matplotlib/tests/test_ticker.pyhttps://github.com/matplotlib/matplotlib/pull/24436/files#diff-fd4f809a4a2ca8b97875eff013bac232c55ca3f92f165117f778960ca1795869
View file https://github.com/dstansby/matplotlib/blob/a8ba49d87163cd42bb581771e9bbeb536f765be4/lib/matplotlib/tests/test_ticker.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/24436/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-fd4f809a4a2ca8b97875eff013bac232c55ca3f92f165117f778960ca1795869
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-fd4f809a4a2ca8b97875eff013bac232c55ca3f92f165117f778960ca1795869
lib/matplotlib/ticker.pyhttps://github.com/matplotlib/matplotlib/pull/24436/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66
View file https://github.com/dstansby/matplotlib/blob/a8ba49d87163cd42bb581771e9bbeb536f765be4/lib/matplotlib/ticker.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/24436/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66
tacaswellhttps://github.com/tacaswell
Feb 2, 2023https://github.com/matplotlib/matplotlib/pull/24436/files#r1094937681
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24436/files
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66
tacaswellhttps://github.com/tacaswell
Feb 2, 2023https://github.com/matplotlib/matplotlib/pull/24436/files#r1094935973
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24436/files
https://github.com/matplotlib/matplotlib/pull/24436/files#diff-ffc88dbb928475229d0fc50ae389ef3f0dabc9c5b8abf42b6eb7a0af28afdb66
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.