Title: Remove comment about cmap from voxels docstring by ksunden · Pull Request #24284 · matplotlib/matplotlib · GitHub
Open Graph Title: Remove comment about cmap from voxels docstring by ksunden · Pull Request #24284 · matplotlib/matplotlib
X Title: Remove comment about cmap from voxels docstring by ksunden · Pull Request #24284 · matplotlib/matplotlib
Description: PR Summary voxels does not use cmap at all, and thus does not modify shade in relation to cmap being passed in, this appears to be copy/pasted from 3D methods which do use cmap. PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation Documentation is sphinx and numpydoc compliant (the docs should build without error). New plotting related features are documented with examples. Release Notes New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/ API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/ Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst
Open Graph Description: PR Summary voxels does not use cmap at all, and thus does not modify shade in relation to cmap being passed in, this appears to be copy/pasted from 3D methods which do use cmap. PR Checklist Tests...
X Description: PR Summary voxels does not use cmap at all, and thus does not modify shade in relation to cmap being passed in, this appears to be copy/pasted from 3D methods which do use cmap. PR Checklist Tests...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/24284
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7bd877ec-0a22-fd2e-0065-1fb2fe8ee654 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AC48:16BCD3:2F20DE2:40FAEDA:6A4F1714 |
| html-safe-nonce | bb4864e4e58936a1389b0f66edad0ff8a26c17d59f42a3bf81b469116871fcd8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzQ4OjE2QkNEMzoyRjIwREUyOjQwRkFFREE6NkE0RjE3MTQiLCJ2aXNpdG9yX2lkIjoiOTAyNzc0MzYwOTgxNDcxODIyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3f512e8495962f9e094cbcb8a0b4060e64fd23432e32623c4f13fcc3e8bd583c |
| hovercard-subject-tag | pull_request:1101993074 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/24284/files |
| twitter:image | https://avatars.githubusercontent.com/u/2501846?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2501846?s=400&v=4 |
| og:image:alt | PR Summary voxels does not use cmap at all, and thus does not modify shade in relation to cmap being passed in, this appears to be copy/pasted from 3D methods which do use cmap. PR Checklist Tests... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width