René's URL Explorer Experiment


Title: Plot directive: delegate file handling to Sphinx by MikhailRyazanov · Pull Request #24205 · matplotlib/matplotlib · GitHub

Open Graph Title: Plot directive: delegate file handling to Sphinx by MikhailRyazanov · Pull Request #24205 · matplotlib/matplotlib

X Title: Plot directive: delegate file handling to Sphinx by MikhailRyazanov · Pull Request #24205 · matplotlib/matplotlib

Description: PR Summary This PR solves multiple problems with file handling in matplotlib.sphinxext.plot_directive described in issue #24005 (and #13858) by delegating all files copying and links generation to the Sphinx :download: role instead of trying to do so explicitly (which apparently cannot be done properly with the current approach). PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation [N/A] New features are documented, with examples if plot related. [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

Open Graph Description: PR Summary This PR solves multiple problems with file handling in matplotlib.sphinxext.plot_directive described in issue #24005 (and #13858) by delegating all files copying and links generation to ...

X Description: PR Summary This PR solves multiple problems with file handling in matplotlib.sphinxext.plot_directive described in issue #24005 (and #13858) by delegating all files copying and links generation to ...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/24205

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fe112f41-c493-49cf-7b21-ea4ac968bdf8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9DE2:19C73D:632B5B:856252:6A52FCD3
html-safe-nonce0e09789291756c9d02606f1e14eae8026d160229cc0f0561ae3f44d16b331065
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REUyOjE5QzczRDo2MzJCNUI6ODU2MjUyOjZBNTJGQ0QzIiwidmlzaXRvcl9pZCI6IjQxMTQ1NTA2ODEwNDk5NTU1MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8f161bd2c6582629618ed39fffb582fddcc0e7d1ab50ad25f38b065ffd1aec24
hovercard-subject-tagpull_request:1089896627
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/24205/files
twitter:imagehttps://avatars.githubusercontent.com/u/12854133?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12854133?s=400&v=4
og:image:altPR Summary This PR solves multiple problems with file handling in matplotlib.sphinxext.plot_directive described in issue #24005 (and #13858) by delegating all files copying and links generation to ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/24205/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F24205%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F24205%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/24205/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/24205/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/24205/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24205/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24205/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
QuLogichttps://github.com/QuLogic
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
MikhailRyazanov:downloadhttps://github.com/MikhailRyazanov/matplotlib/tree/download
Conversation 13 https://github.com/matplotlib/matplotlib/pull/24205
Commits 2 https://github.com/matplotlib/matplotlib/pull/24205/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/24205/checks
Files changed https://github.com/matplotlib/matplotlib/pull/24205/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24205/files
Plot directive: delegate file handling to Sphinx https://github.com/matplotlib/matplotlib/pull/24205/files#top
Show all changes 2 commits https://github.com/matplotlib/matplotlib/pull/24205/files
8e43937 Use :download: instead of trying to make links MikhailRyazanov Nov 20, 2022 https://github.com/matplotlib/matplotlib/pull/24205/commits/8e4393727fdc16aadf88ac183bcd31a11d769e54
3e304bb Update tests MikhailRyazanov Nov 20, 2022 https://github.com/matplotlib/matplotlib/pull/24205/commits/3e304bb42bbb384a973e85bca05f57d0497116fd
Clear filters https://github.com/matplotlib/matplotlib/pull/24205/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24205/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24205/files
plot_directive.py https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1565d78306cf72de5a28f4e2b196ee2cb09026d1f8aa2dc26178c3a47f3347b8
test_sphinxext.py https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1f3f5913fefc55a6629cfdb5478de2a2613e9c768fc5565125578b19694a829e
lib/matplotlib/sphinxext/plot_directive.pyhttps://github.com/matplotlib/matplotlib/pull/24205/files#diff-1565d78306cf72de5a28f4e2b196ee2cb09026d1f8aa2dc26178c3a47f3347b8
View file https://github.com/MikhailRyazanov/matplotlib/blob/3e304bb42bbb384a973e85bca05f57d0497116fd/lib/matplotlib/sphinxext/plot_directive.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/24205/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1565d78306cf72de5a28f4e2b196ee2cb09026d1f8aa2dc26178c3a47f3347b8
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1565d78306cf72de5a28f4e2b196ee2cb09026d1f8aa2dc26178c3a47f3347b8
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1565d78306cf72de5a28f4e2b196ee2cb09026d1f8aa2dc26178c3a47f3347b8
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1565d78306cf72de5a28f4e2b196ee2cb09026d1f8aa2dc26178c3a47f3347b8
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1565d78306cf72de5a28f4e2b196ee2cb09026d1f8aa2dc26178c3a47f3347b8
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1565d78306cf72de5a28f4e2b196ee2cb09026d1f8aa2dc26178c3a47f3347b8
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1565d78306cf72de5a28f4e2b196ee2cb09026d1f8aa2dc26178c3a47f3347b8
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1565d78306cf72de5a28f4e2b196ee2cb09026d1f8aa2dc26178c3a47f3347b8
lib/matplotlib/tests/test_sphinxext.pyhttps://github.com/matplotlib/matplotlib/pull/24205/files#diff-1f3f5913fefc55a6629cfdb5478de2a2613e9c768fc5565125578b19694a829e
View file https://github.com/MikhailRyazanov/matplotlib/blob/3e304bb42bbb384a973e85bca05f57d0497116fd/lib/matplotlib/tests/test_sphinxext.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/24205/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1f3f5913fefc55a6629cfdb5478de2a2613e9c768fc5565125578b19694a829e
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1f3f5913fefc55a6629cfdb5478de2a2613e9c768fc5565125578b19694a829e
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1f3f5913fefc55a6629cfdb5478de2a2613e9c768fc5565125578b19694a829e
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1f3f5913fefc55a6629cfdb5478de2a2613e9c768fc5565125578b19694a829e
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1f3f5913fefc55a6629cfdb5478de2a2613e9c768fc5565125578b19694a829e
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1f3f5913fefc55a6629cfdb5478de2a2613e9c768fc5565125578b19694a829e
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1f3f5913fefc55a6629cfdb5478de2a2613e9c768fc5565125578b19694a829e
https://github.com/matplotlib/matplotlib/pull/24205/files#diff-1f3f5913fefc55a6629cfdb5478de2a2613e9c768fc5565125578b19694a829e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.