René's URL Explorer Experiment


Title: Do not pass width_ratios or height_ratios to inner layouts in subplot_mosaic by joshbarrass · Pull Request #24188 · matplotlib/matplotlib · GitHub

Open Graph Title: Do not pass width_ratios or height_ratios to inner layouts in subplot_mosaic by joshbarrass · Pull Request #24188 · matplotlib/matplotlib

X Title: Do not pass width_ratios or height_ratios to inner layouts in subplot_mosaic by joshbarrass · Pull Request #24188 · matplotlib/matplotlib

Description: PR Summary Fixes #24099 Constructs a new gridspec_kw dictionary with the "width_ratios" and "height_ratios" removed, which is passed to the inner layouts instead of the original. This prevents an error from occurring when one of the inner layouts is not compatible with one of the specified ratios. PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation [N/A] New features are documented, with examples if plot related. [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). Documentation is sphinx and numpydoc compliant (the docs should build without error).

Open Graph Description: PR Summary Fixes #24099 Constructs a new gridspec_kw dictionary with the "width_ratios" and "height_ratios" removed, which is passed to the inner layouts instead of the original...

X Description: PR Summary Fixes #24099 Constructs a new gridspec_kw dictionary with the "width_ratios" and "height_ratios" removed, which is passed to the inner layouts instead...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/24188

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1f7bc620-a1ea-2f48-7b26-a64e0fc28a1a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE93C:1B4753:83F492:B37F1A:6A51F910
html-safe-noncec58aa879c16154b1b97f39937f2525bc3f2bf43f704eaee82bc2bea6ee31f1e2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTNDOjFCNDc1Mzo4M0Y0OTI6QjM3RjFBOjZBNTFGOTEwIiwidmlzaXRvcl9pZCI6IjQwNTcwMjg0MDMwOTc4OTMxMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac35010330abdedbb4882449f2e06b476086fc08d6e96f50db3e8ab977708b6401
hovercard-subject-tagpull_request:1088415419
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/24188/files
twitter:imagehttps://avatars.githubusercontent.com/u/20770871?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20770871?s=400&v=4
og:image:altPR Summary Fixes #24099 Constructs a new gridspec_kw dictionary with the "width_ratios" and "height_ratios" removed, which is passed to the inner layouts instead of the original...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/24188/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F24188%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F24188%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/24188/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/24188/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/24188/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24188/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24188/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
joshbarrasshttps://github.com/joshbarrass
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
joshbarrass:mainhttps://github.com/joshbarrass/matplotlib/tree/main
Conversation 2 https://github.com/matplotlib/matplotlib/pull/24188
Commits 5 https://github.com/matplotlib/matplotlib/pull/24188/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/24188/checks
Files changed https://github.com/matplotlib/matplotlib/pull/24188/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24188/files
Do not pass width_ratios or height_ratios to inner layouts in subplot_mosaic https://github.com/matplotlib/matplotlib/pull/24188/files#top
Show all changes 5 commits https://github.com/matplotlib/matplotlib/pull/24188/files
8522e9e Do not pass width/height ratios to nested layouts joshbarrass Oct 16, 2022 https://github.com/matplotlib/matplotlib/pull/24188/commits/8522e9ed4fccdfa741296d75c9303b6d3593b512
666ab55 Add test case for width_ratios joshbarrass Oct 16, 2022 https://github.com/matplotlib/matplotlib/pull/24188/commits/666ab555b670e4ef01fd0ef24f6fbd4b9f87a770
57a0a01 Add test case for height_ratios joshbarrass Oct 16, 2022 https://github.com/matplotlib/matplotlib/pull/24188/commits/57a0a01ef976b14aebb69bd89f4b770d55c05ba7
e23ebe3 Add behaviour change file joshbarrass Oct 16, 2022 https://github.com/matplotlib/matplotlib/pull/24188/commits/e23ebe348e5a27e997daf1d80b3510acf3fe494b
56b629d Double backticks in rst joshbarrass Oct 16, 2022 https://github.com/matplotlib/matplotlib/pull/24188/commits/56b629dd83495cf0d4b67cd5287b919b073d37e0
Clear filters https://github.com/matplotlib/matplotlib/pull/24188/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24188/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/24188/files
24188-JB.rst https://github.com/matplotlib/matplotlib/pull/24188/files#diff-59e26c09bd146d87cd30e08396e46f0057d0bf1adabfa157e41610e2591f6557
figure.py https://github.com/matplotlib/matplotlib/pull/24188/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
test_figure.py https://github.com/matplotlib/matplotlib/pull/24188/files#diff-7c50aec0865ef6fceff6a5cb00d4b7e57d396ecbcd3546e5fb494aabed99af33
doc/api/next_api_changes/behavior/24188-JB.rsthttps://github.com/matplotlib/matplotlib/pull/24188/files#diff-59e26c09bd146d87cd30e08396e46f0057d0bf1adabfa157e41610e2591f6557
View file https://github.com/joshbarrass/matplotlib/blob/56b629dd83495cf0d4b67cd5287b919b073d37e0/doc/api/next_api_changes/behavior/24188-JB.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/24188/{{ revealButtonHref }}
lib/matplotlib/figure.pyhttps://github.com/matplotlib/matplotlib/pull/24188/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
View file https://github.com/joshbarrass/matplotlib/blob/56b629dd83495cf0d4b67cd5287b919b073d37e0/lib/matplotlib/figure.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/24188/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/24188/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
https://github.com/matplotlib/matplotlib/pull/24188/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
https://github.com/matplotlib/matplotlib/pull/24188/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
https://github.com/matplotlib/matplotlib/pull/24188/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
https://github.com/matplotlib/matplotlib/pull/24188/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
lib/matplotlib/tests/test_figure.pyhttps://github.com/matplotlib/matplotlib/pull/24188/files#diff-7c50aec0865ef6fceff6a5cb00d4b7e57d396ecbcd3546e5fb494aabed99af33
View file https://github.com/joshbarrass/matplotlib/blob/56b629dd83495cf0d4b67cd5287b919b073d37e0/lib/matplotlib/tests/test_figure.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/24188/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/24188/files#diff-7c50aec0865ef6fceff6a5cb00d4b7e57d396ecbcd3546e5fb494aabed99af33
https://github.com/matplotlib/matplotlib/pull/24188/files#diff-7c50aec0865ef6fceff6a5cb00d4b7e57d396ecbcd3546e5fb494aabed99af33
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.