Title: FIX: add missing method to ColormapRegistry by tacaswell · Pull Request #24111 · matplotlib/matplotlib · GitHub
Open Graph Title: FIX: add missing method to ColormapRegistry by tacaswell · Pull Request #24111 · matplotlib/matplotlib
X Title: FIX: add missing method to ColormapRegistry by tacaswell · Pull Request #24111 · matplotlib/matplotlib
Description: PR Summary After putting pending deprecations on cm.get_cmap we discovered that downstream libraries (pandas) were using the deprecated method to normalize between None (to get the default colormap), strings, and Colormap instances. This adds a method to ColormapRegistry to do this normalization. This can not replace our internal helper due to variations in what exceptions are raised. Closes #23981 I opted to edit the existing deprecation message as this seemed like the lest-bad option. PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation New features are documented, with examples if plot related. New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). Documentation is sphinx and numpydoc compliant (the docs should build without error).
Open Graph Description: PR Summary After putting pending deprecations on cm.get_cmap we discovered that downstream libraries (pandas) were using the deprecated method to normalize between None (to get the default colormap...
X Description: PR Summary After putting pending deprecations on cm.get_cmap we discovered that downstream libraries (pandas) were using the deprecated method to normalize between None (to get the default colormap...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/24111
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c5055e81-e90f-7289-86b5-67019a552877 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DAEE:2DAA69:1F1A233:2C713EC:6A50F0C2 |
| html-safe-nonce | 7c749ae80ec5c36e7a52ae01bd8149e29bfa09eb06a9ad5a40fa11dfd5deccfa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUVFOjJEQUE2OToxRjFBMjMzOjJDNzEzRUM6NkE1MEYwQzIiLCJ2aXNpdG9yX2lkIjoiNDE4MDM2MzQ0NDE3ODk3Mjg2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 184062857940a5fe16b282cb117415f138cd50f6ecaa9be56b07e68df705e74f |
| hovercard-subject-tag | pull_request:1079645225 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/24111/files |
| twitter:image | https://avatars.githubusercontent.com/u/199813?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/199813?s=400&v=4 |
| og:image:alt | PR Summary After putting pending deprecations on cm.get_cmap we discovered that downstream libraries (pandas) were using the deprecated method to normalize between None (to get the default colormap... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5266e58c17a510c403505cc811606465e90a881d2007ee7df1c4800d5c659838 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5ec60191a48933536a90c8a19f47142fcd0d4739 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width